Skip to content

GitLab

T
tangled
Commit 038d1068 authored by samuong's avatar samuong Committed by Commit bot
Browse files
Options

[chromedriver] Update NavigationTracker state after Page.navigationToHistoryEntry commands. 

BUG=chromedriver:1118
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/1165553011

Cr-Commit-Position: refs/heads/master@{#333184}
parent 3a4eab3f
Show whitespace changes
Inline Side-by-side
Showing with 3 additions and 2 deletions
chrome/test/chromedriver/chrome/navigation_tracker.cc
View file @ 038d1068
...@@ -181,7 +181,8 @@ Status NavigationTracker::OnEvent(DevToolsClient* client, ...@@ -181,7 +181,8 @@ Status NavigationTracker::OnEvent(DevToolsClient* client,
Status NavigationTracker::OnCommandSuccess(DevToolsClient* client, Status NavigationTracker::OnCommandSuccess(DevToolsClient* client,
const std::string& method) { const std::string& method) {
if (method == "Page.navigate" && loading_state_ != kLoading) { if ((method == "Page.navigate" || method == "Page.navigateToHistoryEntry") &&
loading_state_ != kLoading) {
// At this point the browser has initiated the navigation, but besides that, // At this point the browser has initiated the navigation, but besides that,
// it is unknown what will happen. // it is unknown what will happen.
// //
......
chrome/test/data/chromedriver/outer.html
View file @ 038d1068
...@@ -5,6 +5,6 @@ ...@@ -5,6 +5,6 @@
</head> </head>
<body> <body>
<p>Two</p> <p>Two</p>
<iframe src="inner.html"> <iframe src="inner.html"></iframe>
</body> </body>
</html> </html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment