[omnibox] Convert base::Closure in //components/omnibox to Once or Repeating

This CL converts base::Closure in //components/omnibox to Once or
Repeating

Bug: 1007711
Change-Id: I6c1de227ecbf051841d43bd3eb85d88a9f23d564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088294
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746976}

components/omnibox/browser/autocomplete_provider_unittest.cc

@@ -67,20 +67,22 @@ class TestingSchemeClassifier : public AutocompleteSchemeClassifier {
 class AutocompleteProviderClientWithClosure
     : public MockAutocompleteProviderClient {
  public:
-  AutocompleteProviderClientWithClosure() {}
+  AutocompleteProviderClientWithClosure() = default;
 
-  void set_closure(const base::Closure& closure) { closure_ = closure; }
+  void set_closure(const base::RepeatingClosure& closure) {
+    closure_ = closure;
+  }
 
  private:
   void OnAutocompleteControllerResultReady(
       AutocompleteController* controller) override {
-    if (!closure_.is_null())
+    if (closure_)
       closure_.Run();
     if (base::RunLoop::IsRunningOnCurrentThread())
       base::RunLoop::QuitCurrentWhenIdleDeprecated();
   }
 
-  base::Closure closure_;
+  base::RepeatingClosure closure_;
 
   DISALLOW_COPY_AND_ASSIGN(AutocompleteProviderClientWithClosure);
 };

components/omnibox/browser/base_search_provider_unittest.cc

@@ -79,7 +79,8 @@ class BaseSearchProviderTest : public testing::Test {
             nullptr /* PrefService */,
             std::unique_ptr<SearchTermsData>(new SearchTermsData),
             nullptr /* KeywordWebDataService */,
-            std::unique_ptr<TemplateURLServiceClient>(), base::Closure()));
+            std::unique_ptr<TemplateURLServiceClient>(),
+            base::RepeatingClosure()));
     client_.reset(new MockAutocompleteProviderClient());
     client_->set_template_url_service(std::move(template_url_service));
     provider_ = new NiceMock<TestBaseSearchProvider>(

components/omnibox/browser/in_memory_url_index_unittest.cc

@@ -96,7 +96,7 @@ void StringToTerms(const char* search_string,
 // Observer class so the unit tests can wait while the cache is being saved.
 class CacheFileSaverObserver : public InMemoryURLIndex::SaveCacheObserver {
  public:
-  explicit CacheFileSaverObserver(const base::Closure& task);
+  explicit CacheFileSaverObserver(const base::RepeatingClosure& task);
 
   bool succeeded() { return succeeded_; }
 
@@ -104,16 +104,15 @@ class CacheFileSaverObserver : public InMemoryURLIndex::SaveCacheObserver {
   // SaveCacheObserver implementation.
   void OnCacheSaveFinished(bool succeeded) override;
 
-  base::Closure task_;
+  base::RepeatingClosure task_;
   bool succeeded_;
 
   DISALLOW_COPY_AND_ASSIGN(CacheFileSaverObserver);
 };
 
-CacheFileSaverObserver::CacheFileSaverObserver(const base::Closure& task)
-    : task_(task),
-      succeeded_(false) {
-}
+CacheFileSaverObserver::CacheFileSaverObserver(
+    const base::RepeatingClosure& task)
+    : task_(task), succeeded_(false) {}
 
 void CacheFileSaverObserver::OnCacheSaveFinished(bool succeeded) {
   succeeded_ = succeeded;

components/omnibox/browser/test_omnibox_client.cc

@@ -48,7 +48,8 @@ TestOmniboxClient::CreateAutocompleteProviderClient() {
           nullptr /* PrefService */,
           std::unique_ptr<SearchTermsData>(new SearchTermsData),
           nullptr /* KeywordWebDataService */,
-          std::unique_ptr<TemplateURLServiceClient>(), base::Closure()));
+          std::unique_ptr<TemplateURLServiceClient>(),
+          base::RepeatingClosure()));
 
   // Save a reference to the created TemplateURLService for test use.
   template_url_service_ = template_url_service.get();