Skip to content

GitLab

T
tangled
Commit 0459ad31 authored by rbpotter's avatar rbpotter Committed by Commit Bot
Browse files
Options

Settings: remove unnecessary wrapper from autofill_page_test 

Bug: 1026426
Change-Id: I3f46461373385d91008a5ae9d81498a122eca5e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088357
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatardpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747486}
parent f9f0999e
Hide whitespace changes
Inline Side-by-side
Showing with 286 additions and 288 deletions
chrome/test/data/webui/settings/autofill_page_test.js
View file @ 0459ad31
......@@ -2,337 +2,335 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
cr.define('settings_autofill_page', function() {
suite('PasswordsAndForms', function() {
/**
* Creates a new passwords and forms element.
* @return {!Object}
*/
function createAutofillElement(prefsElement) {
const element = document.createElement('settings-autofill-page');
element.prefs = prefsElement.prefs;
document.body.appendChild(element);
element.$$('dom-if[route-path="/passwords"]').if = true;
element.$$('dom-if[route-path="/payments"]').if = true;
element.$$('dom-if[route-path="/addresses"]').if = true;
Polymer.dom.flush();
return element;
}
/**
* @pram {boolean} autofill Whether autofill is enabled or not.
* @param {boolean} passwords Whether passwords are enabled or not.
* @return {!Promise<!Element>} The |prefs| element.
*/
function createPrefs(autofill, passwords) {
return new Promise(function(resolve) {
CrSettingsPrefs.deferInitialization = true;
const prefs = document.createElement('settings-prefs');
prefs.initialize(new settings.FakeSettingsPrivate([
{
key: 'autofill.enabled',
type: chrome.settingsPrivate.PrefType.BOOLEAN,
value: autofill,
},
{
key: 'autofill.profile_enabled',
type: chrome.settingsPrivate.PrefType.BOOLEAN,
value: true,
},
{
key: 'autofill.credit_card_enabled',
type: chrome.settingsPrivate.PrefType.BOOLEAN,
value: true,
},
{
key: 'credentials_enable_service',
type: chrome.settingsPrivate.PrefType.BOOLEAN,
value: passwords,
},
{
key: 'credentials_enable_autosignin',
type: chrome.settingsPrivate.PrefType.BOOLEAN,
value: true,
},
]));
CrSettingsPrefs.initialized.then(function() {
resolve(prefs);
});
suite('PasswordsAndForms', function() {
/**
* Creates a new passwords and forms element.
* @return {!Object}
*/
function createAutofillElement(prefsElement) {
const element = document.createElement('settings-autofill-page');
element.prefs = prefsElement.prefs;
document.body.appendChild(element);
element.$$('dom-if[route-path="/passwords"]').if = true;
element.$$('dom-if[route-path="/payments"]').if = true;
element.$$('dom-if[route-path="/addresses"]').if = true;
Polymer.dom.flush();
return element;
}
/**
* @pram {boolean} autofill Whether autofill is enabled or not.
* @param {boolean} passwords Whether passwords are enabled or not.
* @return {!Promise<!Element>} The |prefs| element.
*/
function createPrefs(autofill, passwords) {
return new Promise(function(resolve) {
CrSettingsPrefs.deferInitialization = true;
const prefs = document.createElement('settings-prefs');
prefs.initialize(new settings.FakeSettingsPrivate([
{
key: 'autofill.enabled',
type: chrome.settingsPrivate.PrefType.BOOLEAN,
value: autofill,
},
{
key: 'autofill.profile_enabled',
type: chrome.settingsPrivate.PrefType.BOOLEAN,
value: true,
},
{
key: 'autofill.credit_card_enabled',
type: chrome.settingsPrivate.PrefType.BOOLEAN,
value: true,
},
{
key: 'credentials_enable_service',
type: chrome.settingsPrivate.PrefType.BOOLEAN,
value: passwords,
},
{
key: 'credentials_enable_autosignin',
type: chrome.settingsPrivate.PrefType.BOOLEAN,
value: true,
},
]));
CrSettingsPrefs.initialized.then(function() {
resolve(prefs);
});
}
/**
* Cleans up prefs so tests can continue to run.
* @param {!Element} prefs The prefs element.
*/
function destroyPrefs(prefs) {
CrSettingsPrefs.resetForTesting();
CrSettingsPrefs.deferInitialization = false;
prefs.resetForTesting();
}
/**
* Creates PasswordManagerExpectations with the values expected after first
* creating the element.
* @return {!autofill_test_util.PasswordManagerExpectations}
*/
function basePasswordExpectations() {
const expected = new autofill_test_util.PasswordManagerExpectations();
expected.requested.passwords = 1;
expected.requested.exceptions = 1;
expected.requested.accountStorageOptInState = 1;
expected.listening.passwords = 1;
expected.listening.exceptions = 1;
expected.listening.accountStorageOptInState = 1;
return expected;
}
/**
* Creates AutofillManagerExpectations with the values expected after first
* creating the element.
* @return {!autofill_test_util.AutofillManagerExpectations}
*/
function baseAutofillExpectations() {
const expected = new autofill_test_util.AutofillManagerExpectations();
expected.requestedAddresses = 1;
expected.listeningAddresses = 1;
return expected;
}
/**
* Creates PaymentsManagerExpectations with the values expected after first
* creating the element.
* @return {!autofill_test_util.PaymentsManagerExpectations}
*/
function basePaymentsExpectations() {
const expected = new autofill_test_util.PaymentsManagerExpectations();
expected.requestedCreditCards = 1;
expected.listeningCreditCards = 1;
return expected;
}
let passwordManager;
let autofillManager;
let paymentsManager;
setup(async function() {
PolymerTest.clearBody();
await settings.forceLazyLoaded();
// Override the PasswordManagerImpl for testing.
passwordManager = new TestPasswordManagerProxy();
PasswordManagerImpl.instance_ = passwordManager;
// Override the AutofillManagerImpl for testing.
autofillManager = new autofill_test_util.TestAutofillManager();
settings.AutofillManagerImpl.instance_ = autofillManager;
// Override the PaymentsManagerImpl for testing.
paymentsManager = new autofill_test_util.TestPaymentsManager();
settings.PaymentsManagerImpl.instance_ = paymentsManager;
});
}
/**
* Cleans up prefs so tests can continue to run.
* @param {!Element} prefs The prefs element.
*/
function destroyPrefs(prefs) {
CrSettingsPrefs.resetForTesting();
CrSettingsPrefs.deferInitialization = false;
prefs.resetForTesting();
}
/**
* Creates PasswordManagerExpectations with the values expected after first
* creating the element.
* @return {!autofill_test_util.PasswordManagerExpectations}
*/
function basePasswordExpectations() {
const expected = new autofill_test_util.PasswordManagerExpectations();
expected.requested.passwords = 1;
expected.requested.exceptions = 1;
expected.requested.accountStorageOptInState = 1;
expected.listening.passwords = 1;
expected.listening.exceptions = 1;
expected.listening.accountStorageOptInState = 1;
return expected;
}
/**
* Creates AutofillManagerExpectations with the values expected after first
* creating the element.
* @return {!autofill_test_util.AutofillManagerExpectations}
*/
function baseAutofillExpectations() {
const expected = new autofill_test_util.AutofillManagerExpectations();
expected.requestedAddresses = 1;
expected.listeningAddresses = 1;
return expected;
}
/**
* Creates PaymentsManagerExpectations with the values expected after first
* creating the element.
* @return {!autofill_test_util.PaymentsManagerExpectations}
*/
function basePaymentsExpectations() {
const expected = new autofill_test_util.PaymentsManagerExpectations();
expected.requestedCreditCards = 1;
expected.listeningCreditCards = 1;
return expected;
}
let passwordManager;
let autofillManager;
let paymentsManager;
setup(async function() {
PolymerTest.clearBody();
await settings.forceLazyLoaded();
// Override the PasswordManagerImpl for testing.
passwordManager = new TestPasswordManagerProxy();
PasswordManagerImpl.instance_ = passwordManager;
// Override the AutofillManagerImpl for testing.
autofillManager = new autofill_test_util.TestAutofillManager();
settings.AutofillManagerImpl.instance_ = autofillManager;
// Override the PaymentsManagerImpl for testing.
paymentsManager = new autofill_test_util.TestPaymentsManager();
settings.PaymentsManagerImpl.instance_ = paymentsManager;
});
test('baseLoadAndRemove', function() {
return createPrefs(true, true).then(function(prefs) {
const element = createAutofillElement(prefs);
test('baseLoadAndRemove', function() {
return createPrefs(true, true).then(function(prefs) {
const element = createAutofillElement(prefs);
const passwordsExpectations = basePasswordExpectations();
passwordManager.assertExpectations(passwordsExpectations);
const passwordsExpectations = basePasswordExpectations();
passwordManager.assertExpectations(passwordsExpectations);
const autofillExpectations = baseAutofillExpectations();
autofillManager.assertExpectations(autofillExpectations);
const autofillExpectations = baseAutofillExpectations();
autofillManager.assertExpectations(autofillExpectations);
const paymentsExpectations = basePaymentsExpectations();
paymentsManager.assertExpectations(paymentsExpectations);
const paymentsExpectations = basePaymentsExpectations();
paymentsManager.assertExpectations(paymentsExpectations);
element.remove();
Polymer.dom.flush();
element.remove();
Polymer.dom.flush();
passwordsExpectations.listening.passwords = 0;
passwordsExpectations.listening.exceptions = 0;
passwordsExpectations.listening.accountStorageOptInState = 0;
passwordManager.assertExpectations(passwordsExpectations);
passwordsExpectations.listening.passwords = 0;
passwordsExpectations.listening.exceptions = 0;
passwordsExpectations.listening.accountStorageOptInState = 0;
passwordManager.assertExpectations(passwordsExpectations);
autofillExpectations.listeningAddresses = 0;
autofillManager.assertExpectations(autofillExpectations);
autofillExpectations.listeningAddresses = 0;
autofillManager.assertExpectations(autofillExpectations);
paymentsExpectations.listeningCreditCards = 0;
paymentsManager.assertExpectations(paymentsExpectations);
paymentsExpectations.listeningCreditCards = 0;
paymentsManager.assertExpectations(paymentsExpectations);
destroyPrefs(prefs);
});
destroyPrefs(prefs);
});
});
test('loadPasswordsAsync', function() {
return createPrefs(true, true).then(function(prefs) {
const element = createAutofillElement(prefs);
test('loadPasswordsAsync', function() {
return createPrefs(true, true).then(function(prefs) {
const element = createAutofillElement(prefs);
const list = [
autofill_test_util.createPasswordEntry(),
autofill_test_util.createPasswordEntry()
];
const list = [
autofill_test_util.createPasswordEntry(),
autofill_test_util.createPasswordEntry()
];
passwordManager.lastCallback.addSavedPasswordListChangedListener(list);
Polymer.dom.flush();
passwordManager.lastCallback.addSavedPasswordListChangedListener(list);
Polymer.dom.flush();
assertDeepEquals(
list,
element.$$('#passwordSection')
.savedPasswords.map(entry => entry.entry));
assertDeepEquals(
list,
element.$$('#passwordSection')
.savedPasswords.map(entry => entry.entry));
// The callback is coming from the manager, so the element shouldn't
// have additional calls to the manager after the base expectations.
passwordManager.assertExpectations(basePasswordExpectations());
autofillManager.assertExpectations(baseAutofillExpectations());
paymentsManager.assertExpectations(basePaymentsExpectations());
// The callback is coming from the manager, so the element shouldn't
// have additional calls to the manager after the base expectations.
passwordManager.assertExpectations(basePasswordExpectations());
autofillManager.assertExpectations(baseAutofillExpectations());
paymentsManager.assertExpectations(basePaymentsExpectations());
destroyPrefs(prefs);
});
destroyPrefs(prefs);
});
});
test('loadExceptionsAsync', function() {
return createPrefs(true, true).then(function(prefs) {
const element = createAutofillElement(prefs);
test('loadExceptionsAsync', function() {
return createPrefs(true, true).then(function(prefs) {
const element = createAutofillElement(prefs);
const list = [
autofill_test_util.createExceptionEntry(),
autofill_test_util.createExceptionEntry()
];
passwordManager.lastCallback.addExceptionListChangedListener(list);
Polymer.dom.flush();
const list = [
autofill_test_util.createExceptionEntry(),
autofill_test_util.createExceptionEntry()
];
passwordManager.lastCallback.addExceptionListChangedListener(list);
Polymer.dom.flush();
assertEquals(list, element.$$('#passwordSection').passwordExceptions);
assertEquals(list, element.$$('#passwordSection').passwordExceptions);
// The callback is coming from the manager, so the element shouldn't
// have additional calls to the manager after the base expectations.
passwordManager.assertExpectations(basePasswordExpectations());
autofillManager.assertExpectations(baseAutofillExpectations());
paymentsManager.assertExpectations(basePaymentsExpectations());
// The callback is coming from the manager, so the element shouldn't
// have additional calls to the manager after the base expectations.
passwordManager.assertExpectations(basePasswordExpectations());
autofillManager.assertExpectations(baseAutofillExpectations());
paymentsManager.assertExpectations(basePaymentsExpectations());
destroyPrefs(prefs);
});
destroyPrefs(prefs);
});
});
test('loadAddressesAsync', function() {
return createPrefs(true, true).then(function(prefs) {
const element = createAutofillElement(prefs);
const addressList = [
autofill_test_util.createAddressEntry(),
autofill_test_util.createAddressEntry()
];
const cardList = [
autofill_test_util.createCreditCardEntry(),
autofill_test_util.createCreditCardEntry()
];
autofillManager.lastCallback.setPersonalDataManagerListener(
addressList, cardList);
Polymer.dom.flush();
assertEquals(addressList, element.$$('#autofillSection').addresses);
// The callback is coming from the manager, so the element shouldn't
// have additional calls to the manager after the base expectations.
passwordManager.assertExpectations(basePasswordExpectations());
autofillManager.assertExpectations(baseAutofillExpectations());
paymentsManager.assertExpectations(basePaymentsExpectations());
destroyPrefs(prefs);
});
test('loadAddressesAsync', function() {
return createPrefs(true, true).then(function(prefs) {
const element = createAutofillElement(prefs);
const addressList = [
autofill_test_util.createAddressEntry(),
autofill_test_util.createAddressEntry()
];
const cardList = [
autofill_test_util.createCreditCardEntry(),
autofill_test_util.createCreditCardEntry()
];
autofillManager.lastCallback.setPersonalDataManagerListener(
addressList, cardList);
Polymer.dom.flush();
assertEquals(addressList, element.$$('#autofillSection').addresses);
// The callback is coming from the manager, so the element shouldn't
// have additional calls to the manager after the base expectations.
passwordManager.assertExpectations(basePasswordExpectations());
autofillManager.assertExpectations(baseAutofillExpectations());
paymentsManager.assertExpectations(basePaymentsExpectations());
destroyPrefs(prefs);
});
});
test('loadCreditCardsAsync', function() {
return createPrefs(true, true).then(function(prefs) {
const element = createAutofillElement(prefs);
const addressList = [
autofill_test_util.createAddressEntry(),
autofill_test_util.createAddressEntry()
];
const cardList = [
autofill_test_util.createCreditCardEntry(),
autofill_test_util.createCreditCardEntry()
];
paymentsManager.lastCallback.setPersonalDataManagerListener(
addressList, cardList);
Polymer.dom.flush();
assertEquals(cardList, element.$$('#paymentsSection').creditCards);
// The callback is coming from the manager, so the element shouldn't
// have additional calls to the manager after the base expectations.
passwordManager.assertExpectations(basePasswordExpectations());
autofillManager.assertExpectations(baseAutofillExpectations());
paymentsManager.assertExpectations(basePaymentsExpectations());
destroyPrefs(prefs);
});
test('loadCreditCardsAsync', function() {
return createPrefs(true, true).then(function(prefs) {
const element = createAutofillElement(prefs);
const addressList = [
autofill_test_util.createAddressEntry(),
autofill_test_util.createAddressEntry()
];
const cardList = [
autofill_test_util.createCreditCardEntry(),
autofill_test_util.createCreditCardEntry()
];
paymentsManager.lastCallback.setPersonalDataManagerListener(
addressList, cardList);
Polymer.dom.flush();
assertEquals(cardList, element.$$('#paymentsSection').creditCards);
// The callback is coming from the manager, so the element shouldn't
// have additional calls to the manager after the base expectations.
passwordManager.assertExpectations(basePasswordExpectations());
autofillManager.assertExpectations(baseAutofillExpectations());
paymentsManager.assertExpectations(basePaymentsExpectations());
destroyPrefs(prefs);
});
});
});
suite('PasswordsUITest', function() {
/** @type {SettingsAutofillPageElement} */
let autofillPage = null;
/** @type {settings.OpenWindowProxy} */
let openWindowProxy = null;
suite('PasswordsUITest', function() {
/** @type {SettingsAutofillPageElement} */
let autofillPage = null;
/** @type {settings.OpenWindowProxy} */
let openWindowProxy = null;
suiteSetup(function() {
// Forces navigation to Google Password Manager to be off by default.
loadTimeData.overrideValues({
navigateToGooglePasswordManager: false,
});
suiteSetup(function() {
// Forces navigation to Google Password Manager to be off by default.
loadTimeData.overrideValues({
navigateToGooglePasswordManager: false,
});
});
setup(function() {
openWindowProxy = new TestOpenWindowProxy();
settings.OpenWindowProxyImpl.instance_ = openWindowProxy;
setup(function() {
openWindowProxy = new TestOpenWindowProxy();
settings.OpenWindowProxyImpl.instance_ = openWindowProxy;
PolymerTest.clearBody();
autofillPage = document.createElement('settings-autofill-page');
autofillPage.prefs = {
profile: {
password_manager_leak_detection: {},
},
};
document.body.appendChild(autofillPage);
PolymerTest.clearBody();
autofillPage = document.createElement('settings-autofill-page');
autofillPage.prefs = {
profile: {
password_manager_leak_detection: {},
},
};
document.body.appendChild(autofillPage);
Polymer.dom.flush();
});
Polymer.dom.flush();
});
teardown(function() {
autofillPage.remove();
});
teardown(function() {
autofillPage.remove();
});
test('Google Password Manager Off', function() {
assertTrue(!!autofillPage.$$('#passwordManagerButton'));
autofillPage.$$('#passwordManagerButton').click();
Polymer.dom.flush();
test('Google Password Manager Off', function() {
assertTrue(!!autofillPage.$$('#passwordManagerButton'));
autofillPage.$$('#passwordManagerButton').click();
Polymer.dom.flush();
assertEquals(
settings.Router.getInstance().getCurrentRoute(),
settings.routes.PASSWORDS);
});
assertEquals(
settings.Router.getInstance().getCurrentRoute(),
settings.routes.PASSWORDS);
});
test('Google Password Manager On', function() {
// Hardcode this value so that the test is independent of the production
// implementation that might include additional query parameters.
const googlePasswordManagerUrl = 'https://passwords.google.com';
test('Google Password Manager On', function() {
// Hardcode this value so that the test is independent of the production
// implementation that might include additional query parameters.
const googlePasswordManagerUrl = 'https://passwords.google.com';
loadTimeData.overrideValues({
navigateToGooglePasswordManager: true,
googlePasswordManagerUrl: googlePasswordManagerUrl,
});
loadTimeData.overrideValues({
navigateToGooglePasswordManager: true,
googlePasswordManagerUrl: googlePasswordManagerUrl,
});
assertTrue(!!autofillPage.$$('#passwordManagerButton'));
autofillPage.$$('#passwordManagerButton').click();
Polymer.dom.flush();
assertTrue(!!autofillPage.$$('#passwordManagerButton'));
autofillPage.$$('#passwordManagerButton').click();
Polymer.dom.flush();
return openWindowProxy.whenCalled('openURL').then(url => {
assertEquals(googlePasswordManagerUrl, url);
});
return openWindowProxy.whenCalled('openURL').then(url => {
assertEquals(googlePasswordManagerUrl, url);
});
});
});
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment