Commit 04743335 authored by bauerb's avatar bauerb Committed by Commit bot

Ignore files with non-sane filenames in the Android stack symbolizing tool.

BUG=498683

Review URL: https://codereview.chromium.org/1175033002

Cr-Commit-Position: refs/heads/master@{#333798}
parent 5e00a87e
...@@ -26,7 +26,8 @@ include, but are not limited to, the following: ...@@ -26,7 +26,8 @@ include, but are not limited to, the following:
Added memoization of addr2line and objdump. Added memoization of addr2line and objdump.
Added option to change the amount of symbolization done. Added option to change the amount of symbolization done.
Updated output directories to use environment variable. Updated output directories to use environment variable.
When calling addr2line, check the symbol is a file (and not a directory). When calling addr2line, check the symbol is a file that looks like it contains
symbols.
Added support for parsing LOG(FATAL) and DCHECK errors and their Added support for parsing LOG(FATAL) and DCHECK errors and their
stack traces, as emitted by src/base/debug/stack_trace_android.cc stack traces, as emitted by src/base/debug/stack_trace_android.cc
Added support for finding symbols when library is loaded directly from the APK. Added support for finding symbols when library is loaded directly from the APK.
......
...@@ -452,6 +452,9 @@ def CallAddr2LineForSet(lib, unique_addrs): ...@@ -452,6 +452,9 @@ def CallAddr2LineForSet(lib, unique_addrs):
symbols = SYMBOLS_DIR + lib symbols = SYMBOLS_DIR + lib
if not os.path.splitext(symbols)[1] in ['', '.so', '.apk']:
return None
if not os.path.isfile(symbols): if not os.path.isfile(symbols):
return None return None
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment