Add text selection ActionBar tests

Currently there is insufficient coverage for text selection ActionBar
menu interaction. Add several basic tests covering such functionality.

Review URL: https://codereview.chromium.org/538103003

Cr-Commit-Position: refs/heads/master@{#301408}

content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -283,6 +283,7 @@ public class ContentViewCore
     private ActionMode mActionMode;
     private boolean mUnselectAllOnActionModeDismiss;
     private boolean mPreserveSelectionOnNextLossOfFocus;
+    private SelectActionModeCallback.ActionHandler mActionHandler;
 
     // Delegate that will handle GET downloads, and be notified of completion of POST downloads.
     private ContentViewDownloadDelegate mDownloadDelegate;
@@ -562,8 +563,8 @@ public class ContentViewCore
                             @Override
                             public void onReceiveResult(int resultCode, Bundle resultData) {
                                 getContentViewClient().onImeStateChangeRequested(
-                                        resultCode == InputMethodManager.RESULT_SHOWN ||
-                                        resultCode == InputMethodManager.RESULT_UNCHANGED_SHOWN);
+                                        resultCode == InputMethodManager.RESULT_SHOWN
+                                        || resultCode == InputMethodManager.RESULT_UNCHANGED_SHOWN);
                                 if (resultCode == InputMethodManager.RESULT_SHOWN) {
                                     // If OSK is newly shown, delay the form focus until
                                     // the onSizeChanged (in order to adjust relative to the
@@ -572,8 +573,8 @@ public class ContentViewCore
                                     // always be called, crbug.com/294908.
                                     getContainerView().getWindowVisibleDisplayFrame(
                                             mFocusPreOSKViewportRect);
-                                } else if (hasFocus() && resultCode ==
-                                        InputMethodManager.RESULT_UNCHANGED_SHOWN) {
+                                } else if (hasFocus() && resultCode
+                                        == InputMethodManager.RESULT_UNCHANGED_SHOWN) {
                                     // If the OSK was already there, focus the form immediately.
                                     assert mWebContents != null;
                                     mWebContents.scrollFocusedEditableNodeIntoView();
@@ -1731,6 +1732,11 @@ public class ContentViewCore
         return mDownloadDelegate;
     }
 
+    @VisibleForTesting
+    public SelectActionModeCallback.ActionHandler getSelectActionHandler() {
+        return mActionHandler;
+    }
+
     private void showSelectActionBar() {
         if (mActionMode != null) {
             mActionMode.invalidate();
@@ -1738,8 +1744,8 @@ public class ContentViewCore
         }
 
         // Start a new action mode with a SelectActionModeCallback.
-        SelectActionModeCallback.ActionHandler actionHandler =
-                new SelectActionModeCallback.ActionHandler() {
+        if (mActionHandler == null) {
+            mActionHandler = new SelectActionModeCallback.ActionHandler() {
                 @Override
                 public void selectAll() {
                     mImeAdapter.selectAll();
@@ -1845,12 +1851,13 @@ public class ContentViewCore
                             PackageManager.MATCH_DEFAULT_ONLY).size() > 0;
                 }
             };
+        }
         mActionMode = null;
         // On ICS, startActionMode throws an NPE when getParent() is null.
         if (mContainerView.getParent() != null) {
             assert mWebContents != null;
             mActionMode = mContainerView.startActionMode(
-                    getContentViewClient().getSelectActionModeCallback(getContext(), actionHandler,
+                    getContentViewClient().getSelectActionModeCallback(getContext(), mActionHandler,
                             mWebContents.isIncognito()));
         }
         mUnselectAllOnActionModeDismiss = true;
@@ -2528,10 +2535,9 @@ public class ContentViewCore
             return mBrowserAccessibilityManager.getAccessibilityNodeProvider();
         }
 
-        if (mNativeAccessibilityAllowed &&
-                !mNativeAccessibilityEnabled &&
-                mNativeContentViewCore != 0 &&
-                Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {
+        if (mNativeAccessibilityAllowed && !mNativeAccessibilityEnabled
+                && mNativeContentViewCore != 0
+                && Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {
             mNativeAccessibilityEnabled = true;
             nativeSetAccessibilityEnabled(mNativeContentViewCore, true);
         }
@@ -2579,8 +2585,8 @@ public class ContentViewCore
         try {
             // On JellyBean and higher, native accessibility is the default so script
             // injection is only allowed if enabled via a flag.
-            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN &&
-                    !CommandLine.getInstance().hasSwitch(
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN
+                    && !CommandLine.getInstance().hasSwitch(
                             ContentSwitches.ENABLE_ACCESSIBILITY_SCRIPT_INJECTION)) {
                 return false;
             }

content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

@@ -22,19 +22,20 @@ import org.chromium.content_shell_apk.ContentShellTestBase;
  */
 public class ContentViewCoreSelectionTest extends ContentShellTestBase {
     private static final String DATA_URL = UrlUtils.encodeHtmlDataUri(
-            "<html><head><meta name=\"viewport\"" +
-            "content=\"width=device-width, initial-scale=1.1, maximum-scale=1.5\" /></head>" +
-            "<body><form action=\"about:blank\">" +
-            "<input id=\"empty_input_text\" type=\"text\" />" +
-            "<br/><p><span id=\"plain_text_1\">This is Plain Text One</span></p>" +
-            "<br/><p><span id=\"plain_text_2\">This is Plain Text Two</span></p>" +
-            "<br/><input id=\"empty_input_text\" type=\"text\" />" +
-            "<br/><input id=\"input_text\" type=\"text\" value=\"Sample Text\" />" +
-            "<br/><textarea id=\"empty_textarea\" rows=\"2\" cols=\"20\"></textarea>" +
-            "<br/><textarea id=\"textarea\" rows=\"2\" cols=\"20\">Sample Text</textarea>" +
-            "<br/><input id=\"readonly_text\" type=\"text\" readonly value=\"Sample Text\"/>" +
-            "<br/><input id=\"disabled_text\" type=\"text\" disabled value=\"Sample Text\" />" +
-            "</form></body></html>");
+            "<html><head><meta name=\"viewport\""
+            + "content=\"width=device-width, initial-scale=1.1, maximum-scale=1.5\" /></head>"
+            + "<body><form action=\"about:blank\">"
+            + "<input id=\"empty_input_text\" type=\"text\" />"
+            + "<br/><p><span id=\"plain_text_1\">This is Plain Text One</span></p>"
+            + "<br/><p><span id=\"plain_text_2\">This is Plain Text Two</span></p>"
+            + "<br/><input id=\"empty_input_text\" type=\"text\" />"
+            + "<br/><input id=\"input_text\" type=\"text\" value=\"Sample Text\" />"
+            + "<br/><textarea id=\"empty_textarea\" rows=\"2\" cols=\"20\"></textarea>"
+            + "<br/><textarea id=\"textarea\" rows=\"2\" cols=\"20\">Sample Text</textarea>"
+            + "<br/><input id=\"readonly_text\" type=\"text\" readonly value=\"Sample Text\"/>"
+            + "<br/><input id=\"disabled_text\" type=\"text\" disabled value=\"Sample Text\" />"
+            + "<br/><input id=\"input_password\" type=\"password\" value=\"Sample Password\" />"
+            + "</form></body></html>");
 
     private ContentViewCore mContentViewCore;
 
@@ -199,6 +200,28 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
         assertFalse(mContentViewCore.hasInsertion());
     }
 
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testActionBarConfiguredCorrectlyForInput() throws Throwable {
+        DOMUtils.longPressNode(this, mContentViewCore, "input_text");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        assertTrue(mContentViewCore.getSelectActionHandler().isSelectionEditable());
+        assertFalse(mContentViewCore.getSelectActionHandler().isSelectionPassword());
+    }
+
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testActionBarConfiguredCorrectlyForPassword() throws Throwable {
+        DOMUtils.longPressNode(this, mContentViewCore, "input_password");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        assertTrue(mContentViewCore.getSelectActionHandler().isSelectionEditable());
+        assertTrue(mContentViewCore.getSelectActionHandler().isSelectionPassword());
+    }
+
     private void assertWaitForSelectActionBarVisible(
             final boolean visible) throws InterruptedException {
         assertTrue(CriteriaHelper.pollForCriteria(new Criteria() {