[Modern] Removes all div lines on a few settings pages

Removes divs from Clear Browsing Data, Accessibility,
   Site Settings, and Site Settings sub pages

Bug: 834600
Change-Id: I28afdc9e4a3823b082dc22da6c44653eabfcdb84
Reviewed-on: https://chromium-review.googlesource.com/1044273
Commit-Queue: Daniel Park <danielpark@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556153}

chrome/android/java/res/layout/clear_browsing_data_tab_content.xml

@@ -17,8 +17,6 @@
         android:layout_weight="1"
         android:layout_height="0dp"/>
 
-    <View style="@style/Divider"/>
-
     <Button
         android:id="@+id/clear_button"
         android:layout_gravity="end"

chrome/android/java/res/layout/divider_preference_with_bottom_padding.xml

-<?xml version="1.0" encoding="utf-8"?>
-<!-- Copyright 2017 The Chromium Authors. All rights reserved.
-     Use of this source code is governed by a BSD-style license that can be
-     found in the LICENSE file. -->
-
-<LinearLayout
-    xmlns:android="http://schemas.android.com/apk/res/android"
-    android:layout_height="wrap_content"
-    android:layout_width="match_parent"
-    android:paddingBottom="8dp">
-    <View style="@style/Divider"/>
-</LinearLayout>

chrome/android/java/res/xml/clear_browsing_data_preferences_tab.xml

@@ -13,10 +13,6 @@
         android:title="@string/clear_browsing_data_tab_period_title"
         chrome:singleLine="true" />
 
-    <Preference
-        android:layout="@layout/divider_preference_with_bottom_padding"
-        android:selectable="false"/>
-
     <org.chromium.chrome.browser.preferences.ClearBrowsingDataCheckBoxPreference
         android:key="clear_history_checkbox"
         android:persistent="false"

chrome/android/java/res/xml/website_preferences.xml

@@ -11,8 +11,7 @@
          for that category on/off.-->
     <org.chromium.chrome.browser.preferences.ChromeSwitchPreference
         android:key="read_write_toggle"
-        android:defaultValue="true"
-        chrome:drawDivider="true" />
+        android:defaultValue="true" />
     <!-- A toggle for allowing third-party cookies, only shown for the Cookies category. -->
     <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference
         android:key="third_party_cookies"

chrome/android/java/src/org/chromium/chrome/browser/preferences/AccessibilityPreferences.java

@@ -79,6 +79,7 @@ public class AccessibilityPreferences extends PreferenceFragment
         super.onActivityCreated(savedInstanceState);
 
         ((ListView) getView().findViewById(android.R.id.list)).setItemsCanFocus(true);
+        ((ListView) getView().findViewById(android.R.id.list)).setDivider(null);
     }
 
     @Override

chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java

@@ -9,6 +9,7 @@ import android.os.Bundle;
 import android.preference.Preference;
 import android.preference.Preference.OnPreferenceClickListener;
 import android.preference.PreferenceFragment;
+import android.widget.ListView;
 
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ChromeFeatureList;
@@ -114,6 +115,12 @@ public class SiteSettingsPreferences extends PreferenceFragment
         return -1;
     }
 
+    @Override
+    public void onActivityCreated(Bundle savedInstanceState) {
+        super.onActivityCreated(savedInstanceState);
+        ((ListView) getView().findViewById(android.R.id.list)).setDivider(null);
+    }
+
     private void configurePreferences() {
         if (mMediaSubMenu) {
             // The Media sub-menu only contains Protected Content and Autoplay, so remove all other