Delete (now) useless FakeGaiaCookieManagerService factory method.

The deleted factory was created a FakeGaiaCookieManagerService
which was just a passthrough wrapper around GaiaCookieManagerService.

Since FakeGaiaCookieManagerService was only acting as a pass-through the
net effect of creating it was zero.

Bug: 907782
Change-Id: I45453afbdd21584c96e328cdd24136072bce83ff
Reviewed-on: https://chromium-review.googlesource.com/c/1421999Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626044}

chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc

@@ -12,14 +12,6 @@
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "services/network/test/test_url_loader_factory.h"
 
-std::unique_ptr<KeyedService> BuildFakeGaiaCookieManagerService(
-    content::BrowserContext* context) {
-  Profile* profile = Profile::FromBrowserContext(context);
-  return std::make_unique<FakeGaiaCookieManagerService>(
-      ProfileOAuth2TokenServiceFactory::GetForProfile(profile),
-      ChromeSigninClientFactory::GetForProfile(profile));
-}
-
 std::unique_ptr<KeyedService> BuildFakeGaiaCookieManagerServiceWithURLLoader(
     network::TestURLLoaderFactory* test_url_loader_factory,
     content::BrowserContext* context) {

chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h

@@ -18,10 +18,6 @@ namespace network {
 class TestURLLoaderFactory;
 }
 
-// Helper functions to be used with KeyedService::SetTestingFactory().
-std::unique_ptr<KeyedService> BuildFakeGaiaCookieManagerService(
-    content::BrowserContext* context);
-
 // Builds a FakeGaiaCookieManagerService which uses the provided
 // |test_url_loader_factory| for cookie-related requests.
 std::unique_ptr<KeyedService> BuildFakeGaiaCookieManagerServiceWithURLLoader(

chrome/browser/signin/identity_test_environment_profile_adaptor.cc

@@ -68,9 +68,7 @@ void IdentityTestEnvironmentProfileAdaptor::
 // static
 TestingProfile::TestingFactories
 IdentityTestEnvironmentProfileAdaptor::GetIdentityTestEnvironmentFactories() {
-  return {{GaiaCookieManagerServiceFactory::GetInstance(),
-           base::BindRepeating(&BuildFakeGaiaCookieManagerService)},
-          {ProfileOAuth2TokenServiceFactory::GetInstance(),
+  return {{ProfileOAuth2TokenServiceFactory::GetInstance(),
            base::BindRepeating(&BuildFakeProfileOAuth2TokenService)},
           {SigninManagerFactory::GetInstance(),
            base::BindRepeating(&BuildFakeSigninManagerForTesting)}};

chrome/browser/signin/signin_ui_util_unittest.cc

@@ -135,9 +135,7 @@ class DiceSigninUiUtilTest : public BrowserWithTestWindowTest {
     return {{SigninManagerFactory::GetInstance(),
              base::BindRepeating(&BuildFakeSigninManagerForTesting)},
             {ProfileOAuth2TokenServiceFactory::GetInstance(),
-             base::BindRepeating(&BuildFakeProfileOAuth2TokenService)},
-            {GaiaCookieManagerServiceFactory::GetInstance(),
-             base::BindRepeating(&BuildFakeGaiaCookieManagerService)}};
+             base::BindRepeating(&BuildFakeProfileOAuth2TokenService)}};
   }
 
   // BrowserWithTestWindowTest: