Commit 061e1733 authored by agrieve's avatar agrieve Committed by Commit Bot

trybot_commit_size_checker.py: UI tweaks

* Summary needs to use <br> rather than \n.
* Show actual value before max value in explanations.
* Put the two SuperSize result links together.

Change-Id: Iafc6b0c53fd804f6f162acae33cbd2d864354fce
Reviewed-on: https://chromium-review.googlesource.com/c/1394911Reviewed-by: default avatarEric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619782}
parent 3f3dc7c8
...@@ -65,8 +65,8 @@ class _SizeDelta(collections.namedtuple( ...@@ -65,8 +65,8 @@ class _SizeDelta(collections.namedtuple(
@property @property
def explanation(self): def explanation(self):
ret = '{}: expected max: {} {}, got {} {}'.format( ret = '{}: {} {} (max is {} {})'.format(
self.name, self.expected, self.units, self.actual, self.units) self.name, self.actual, self.units, self.expected, self.units)
if self.details and not self.IsAllowable(): if self.details and not self.IsAllowable():
ret += '\n' + self.details ret += '\n' + self.details
return ret return ret
...@@ -244,10 +244,11 @@ PASSING: ...@@ -244,10 +244,11 @@ PASSING:
checks_text += _FAILURE_GUIDANCE checks_text += _FAILURE_GUIDANCE
status_code = 1 if failing_deltas and not is_roller else 0 status_code = 1 if failing_deltas and not is_roller else 0
summary = """ summary = '<br>'.join([
Normalized apk size delta: {} '',
Dex method count delta: {}\ 'Normalized apk size delta: {}'.format(resource_sizes_delta.actual),
""".format(resource_sizes_delta.actual, dex_delta.actual) 'Dex method count delta: {}'.format(dex_delta.actual),
])
# TODO(agrieve): Remove once recipe is updated: details, normalized_apk_size # TODO(agrieve): Remove once recipe is updated: details, normalized_apk_size
results_json = { results_json = {
...@@ -265,14 +266,14 @@ Dex method count delta: {}\ ...@@ -265,14 +266,14 @@ Dex method count delta: {}\
'name': '>>> Resource Sizes Diff (high-level metrics) <<<', 'name': '>>> Resource Sizes Diff (high-level metrics) <<<',
'lines': resource_sizes_lines, 'lines': resource_sizes_lines,
}, },
{
'name': '>>> SuperSize Text Diff <<<',
'lines': supersize_diff_lines,
},
{ {
'name': '>>> Dex Method Diff <<<', 'name': '>>> Dex Method Diff <<<',
'lines': dex_delta_lines, 'lines': dex_delta_lines,
}, },
{
'name': '>>> SuperSize Text Diff <<<',
'lines': supersize_diff_lines,
},
{ {
'name': '>>> Supersize HTML Diff <<<', 'name': '>>> Supersize HTML Diff <<<',
'url': _HTML_REPORT_BASE_URL + '{{' + _NDJSON_FILENAME + '}}', 'url': _HTML_REPORT_BASE_URL + '{{' + _NDJSON_FILENAME + '}}',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment