Move kFirstDynamicTableIndex to http2_hpack_constants.h

Move the const value kFirstDynamicTableIndex from hpack_decoder_tables.h
to http2_hpack_constants.h
Remove the TODO.

BUG=
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I10ab0c08065414958c71aa8f9988464d0afd56d5
Reviewed-on: https://chromium-review.googlesource.com/844407Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526906}

net/http2/hpack/decoder/hpack_decoder_state_test.cc

@@ -11,6 +11,7 @@
 
 #include "base/logging.h"
 #include "net/http2/hpack/hpack_string.h"
+#include "net/http2/hpack/http2_hpack_constants.h"
 #include "net/http2/http2_constants.h"
 #include "net/http2/platform/api/http2_string.h"
 #include "net/http2/tools/failure.h"

net/http2/hpack/decoder/hpack_decoder_tables.cc

@@ -5,6 +5,7 @@
 #include "net/http2/hpack/decoder/hpack_decoder_tables.h"
 
 #include "base/logging.h"
+#include "net/http2/hpack/http2_hpack_constants.h"
 
 namespace net {
 namespace {

net/http2/hpack/decoder/hpack_decoder_tables.h

@@ -31,9 +31,6 @@ namespace test {
 class HpackDecoderTablesPeer;
 }  // namespace test
 
-// TODO(jamessynge): Move to hpack_constants.h
-const size_t kFirstDynamicTableIndex = 62;
-
 // HpackDecoderTablesDebugListener supports a QUIC experiment, enabling
 // the gathering of information about the time-line of use of HPACK
 // dynamic table entries.

net/http2/hpack/decoder/hpack_decoder_tables_test.cc

@@ -9,6 +9,7 @@
 #include <vector>
 
 #include "base/logging.h"
+#include "net/http2/hpack/http2_hpack_constants.h"
 #include "net/http2/platform/api/http2_string.h"
 #include "net/http2/tools/failure.h"
 #include "net/http2/tools/http2_random.h"

net/http2/hpack/http2_hpack_constants.h

@@ -17,6 +17,8 @@
 
 namespace net {
 
+const size_t kFirstDynamicTableIndex = 62;
+
 enum class HpackEntryType {
   // Entry is an index into the static or dynamic table. Decoding it has no
   // effect on the dynamic table.
@@ -55,7 +57,6 @@ HTTP2_EXPORT_PRIVATE Http2String HpackEntryTypeToString(HpackEntryType v);
 // Inserts the name of the enum member into |out|.
 HTTP2_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& out,
                                               HpackEntryType v);
-
 }  // namespace net
 
 #endif  // NET_HTTP2_HPACK_HTTP2_HPACK_CONSTANTS_H_