Commit 07cf285f authored by Sean Kau's avatar Sean Kau Committed by Commit Bot

Add tests to ExternalPrinters for empty lists.

Verify that an empty blacklist and whitelist are handled properly by
adding a unit test for the behavior.

Bug: None
Change-Id: I3eda6222b211f4306acad7a9c0030b834d6e694e
Reviewed-on: https://chromium-review.googlesource.com/1211980Reviewed-by: default avatarXiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589586}
parent 884a7162
...@@ -238,6 +238,38 @@ TEST_F(ExternalPrintersTest, WhitelistPolicySet) { ...@@ -238,6 +238,38 @@ TEST_F(ExternalPrintersTest, WhitelistPolicySet) {
EXPECT_EQ("LexaPrint", printers.at("First").display_name()); EXPECT_EQ("LexaPrint", printers.at("First").display_name());
} }
// Verify that an empty blacklist results in no printer limits.
TEST_F(ExternalPrintersTest, EmptyBlacklistAllPrinters) {
auto data = std::make_unique<std::string>(kBulkPolicyContentsJson);
external_printers_->ClearData();
external_printers_->SetData(std::move(data));
external_printers_->SetAccessMode(ExternalPrinters::BLACKLIST_ONLY);
scoped_task_environment_.RunUntilIdle();
EXPECT_FALSE(external_printers_->IsPolicySet());
external_printers_->SetBlacklist({});
scoped_task_environment_.RunUntilIdle();
EXPECT_TRUE(external_printers_->IsPolicySet());
const auto& printers = external_printers_->GetPrinters();
EXPECT_EQ(kNumPrinters, printers.size());
}
// Verify that an empty whitelist results in no printers.
TEST_F(ExternalPrintersTest, EmptyWhitelistNoPrinters) {
auto data = std::make_unique<std::string>(kBulkPolicyContentsJson);
external_printers_->ClearData();
external_printers_->SetData(std::move(data));
external_printers_->SetAccessMode(ExternalPrinters::WHITELIST_ONLY);
scoped_task_environment_.RunUntilIdle();
EXPECT_FALSE(external_printers_->IsPolicySet());
external_printers_->SetWhitelist({});
scoped_task_environment_.RunUntilIdle();
EXPECT_TRUE(external_printers_->IsPolicySet());
const auto& printers = external_printers_->GetPrinters();
EXPECT_EQ(0U, printers.size());
}
// Verify that switching from whitelist to blacklist behaves correctly. // Verify that switching from whitelist to blacklist behaves correctly.
TEST_F(ExternalPrintersTest, BlacklistToWhitelistSwap) { TEST_F(ExternalPrintersTest, BlacklistToWhitelistSwap) {
auto data = std::make_unique<std::string>(kBulkPolicyContentsJson); auto data = std::make_unique<std::string>(kBulkPolicyContentsJson);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment