Commit 0823d6a7 authored by Scott Wu's avatar Scott Wu Committed by Commit Bot

Add null check to prevent crash when saving password.

This check is needed since iOS Chrome is returning nullptr in GetPasswordAutofillManager()
https://cs.chromium.org/chromium/src/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm

Bug: 890655
Change-Id: I33951b54d0e618f861284df7aeabcbf3d9e1681b
Reviewed-on: https://chromium-review.googlesource.com/1253164
Commit-Queue: Scott Wu <scottwu@chromium.org>
Reviewed-by: default avatarVaclav Brozek <vabr@chromium.org>
Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595702}
parent dfc813a8
...@@ -591,8 +591,14 @@ void PasswordManager::UpdateFormManagers() { ...@@ -591,8 +591,14 @@ void PasswordManager::UpdateFormManagers() {
// The autofill manager will be repopulated again when the credentials // The autofill manager will be repopulated again when the credentials
// are retrieved. // are retrieved.
for (PasswordManagerDriver* driver : drivers) for (PasswordManagerDriver* driver : drivers) {
// GetPasswordAutofillManager() is returning nullptr in iOS Chrome, since
// PasswordAutofillManager is not instantiated on iOS Chrome.
// See //ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm
if (driver->GetPasswordAutofillManager()) {
driver->GetPasswordAutofillManager()->DeleteFillData(); driver->GetPasswordAutofillManager()->DeleteFillData();
}
}
} }
void PasswordManager::DropFormManagers() { void PasswordManager::DropFormManagers() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment