Commit 0904ee3f authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

Revert "Revert "Update V8 to version 6.3.113.""

This reverts commit b50598f3.

Reason for revert: This was just an mksnapshot flake, see:
https://crbug.com/700525 

Cycled already green before revert was in.

Original change's description:
> Revert "Update V8 to version 6.3.113."
> 
> This reverts commit cb14e960.
> 
> Reason for revert: Compile error on Windows: 
>  FAILED: gen/v8/snapshot.cc snapshot_blob.bin 
> C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../v8/tools/run.py ./mksnapshot --startup_src gen/v8/snapshot.cc --random-seed 314159265 --startup_blob snapshot_blob.bin
> ==== C stack trace ===============================
> 	v8::internal::CEntryStub::MajorKey [0x01250990+0]
> 	v8::internal::CodeStub::FindCodeInCache [0x010F8D09+25]
> 	v8::internal::CodeStub::GetCode [0x010FAAA9+57]
> 	v8::internal::MacroAssembler::CallRuntime [0x01495804+148]
> 	v8::internal::TypeofDescriptor::TypeofDescriptor [0x014E4DB9+665]
> 	v8::internal::SetupIsolateDelegate::PopulateWithPlaceholders [0x014E53DE+46]
> 	v8::internal::SetupIsolateDelegate::SetupBuiltinsInternal [0x014E5603+19]
> 	v8::internal::SetupIsolateDelegate::SetupBuiltins [0x0149DDD1+17]
> 	v8::internal::Isolate::Init [0x012E1778+4792]
> 	v8::SnapshotCreator::SnapshotCreator [0x01058C26+150]
> 	v8::V8::CreateSnapshotDataBlob [0x0105B181+33]
> 	main [0x01051690+192]
> 	__scrt_common_main_seh [0x015C7EEB+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
> 	BaseThreadInitThunk [0x7786338A+18]
> 	RtlInitializeExceptionChain [0x77E69A02+99]
> 	RtlInitializeExceptionChain [0x77E699D5+54]
> 
> Original change's description:
> > Update V8 to version 6.3.113.
> > 
> > Summary of changes available at:
> > https://chromium.googlesource.com/v8/v8/+log/726c1912..e3965fde
> > 
> > Please follow these instructions for assigning/CC'ing issues:
> > https://github.com/v8/v8/wiki/Triaging%20issues
> > 
> > Please close rolling in case of a roll revert:
> > https://v8-roll.appspot.com/
> > This only works with a Google account.
> > 
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> > 
> > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org
> > 
> > Change-Id: I52a756ba5f107262265018de222b0213e1ee1d92
> > Reviewed-on: https://chromium-review.googlesource.com/663297
> > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
> > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#501250}
> 
> TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org
> 
> Change-Id: I71255d8fcb1b281550f5f5d43e0671d36cb29c55
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/663599
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501266}

TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org,sebsg@chromium.org

Change-Id: I5a4c7f19bc2584cbc3bc72b8983de5ade2f5595e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/663697Reviewed-by: default avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501279}
parent 4ba1c8da
......@@ -44,7 +44,7 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling V8
# and whatever else without interference from each other.
'v8_revision': '726c1912373d6c58237b2c4d8dd1e5aad2a81d7c',
'v8_revision': 'e3965fde0b4bf12c604660290921c8c1e7a3fa09',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling swarming_client
# and whatever else without interference from each other.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment