Commit 090a2a50 authored by Daniel Bratell's avatar Daniel Bratell Committed by Commit Bot

Don't compile app_icon_factory except for ChromeOS.

Compiling app_icon_factory  code triggered compilation errors in some
Windows and Mac builds since the code references app_list which
only exists in ChromeOS. In most builds it was ok because the generated
object file was unused and got stripped by the linker before the dangling
references was found.

BUG=826982

TBR=nigeltao@chromium.org,rdevlin.cronin@chromium.org,dominickn@chromium.org

Change-Id: I25f0fa090f3466bcc83e06a070c7aa6c8600976d
Reviewed-on: https://chromium-review.googlesource.com/c/1373450Reviewed-by: default avatarDaniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#615856}
parent db433ca4
...@@ -2589,8 +2589,6 @@ jumbo_split_static_library("browser") { ...@@ -2589,8 +2589,6 @@ jumbo_split_static_library("browser") {
sources += [ sources += [
"accessibility/invert_bubble_prefs.cc", "accessibility/invert_bubble_prefs.cc",
"accessibility/invert_bubble_prefs.h", "accessibility/invert_bubble_prefs.h",
"apps/app_service/app_icon_factory.cc",
"apps/app_service/app_icon_factory.h",
"apps/app_service/app_icon_source.cc", "apps/app_service/app_icon_source.cc",
"apps/app_service/app_icon_source.h", "apps/app_service/app_icon_source.h",
"apps/app_service/app_service_proxy.cc", "apps/app_service/app_service_proxy.cc",
...@@ -3121,6 +3119,8 @@ jumbo_split_static_library("browser") { ...@@ -3121,6 +3119,8 @@ jumbo_split_static_library("browser") {
if (is_chromeos) { if (is_chromeos) {
sources += [ sources += [
"apps/app_service/app_icon_factory.cc",
"apps/app_service/app_icon_factory.h",
"apps/app_service/built_in_chromeos_apps.cc", "apps/app_service/built_in_chromeos_apps.cc",
"apps/app_service/built_in_chromeos_apps.h", "apps/app_service/built_in_chromeos_apps.h",
"apps/app_service/extension_apps.cc", "apps/app_service/extension_apps.cc",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment