Commit 09a41cdf authored by Robert Ogden's avatar Robert Ogden Committed by Commit Bot

HTTPS Previews: Add IPv6 Test

There was a bug server side where encoding a IPv6 URL wasn't working
correctly. This is a preemptive test to make sure the encoding in Chrome
is correct (it already is).

Change-Id: I17dd2393133fc02f01de0b2ef381fc05067bf72d
Reviewed-on: https://chromium-review.googlesource.com/c/1336508
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: default avatarTarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608168}
parent 81b9c997
...@@ -23,11 +23,12 @@ TEST(PreviewsLitePageNavigationThrottleTest, TestGetPreviewsURL) { ...@@ -23,11 +23,12 @@ TEST(PreviewsLitePageNavigationThrottleTest, TestGetPreviewsURL) {
struct TestCase { struct TestCase {
std::string previews_host; std::string previews_host;
std::string original_url; std::string original_url;
std::string previews_url; std::string expected_previews_url;
std::string experiment; std::string experiment;
}; };
const TestCase kTestCases[]{ const TestCase kTestCases[]{
// Use https://play.golang.org/p/HUM2HxmUTOW to compute |previews_url|. // Use https://play.golang.org/p/HUM2HxmUTOW to compute
// |expected_previews_url|.
{ {
"https://previews.host.com", "https://previews.host.com",
"https://original.host.com/path/path/path?query=yes", "https://original.host.com/path/path/path?query=yes",
...@@ -86,6 +87,12 @@ TEST(PreviewsLitePageNavigationThrottleTest, TestGetPreviewsURL) { ...@@ -86,6 +87,12 @@ TEST(PreviewsLitePageNavigationThrottleTest, TestGetPreviewsURL) {
"&x=enable_HTCPCP", "&x=enable_HTCPCP",
"enable_HTCPCP", "enable_HTCPCP",
}, },
{
"https://previews.host.com", "https://[::1]:12345",
"https://2ikmbopbfxagkb7uer2vgfxmbzu2vw4qq3d3ixe3h2hfhgcabvua."
"previews.host.com/p?u=https%3A%2F%2F%5B%3A%3A1%5D%3A12345%2F",
"",
},
}; };
for (const TestCase& test_case : kTestCases) { for (const TestCase& test_case : kTestCases) {
...@@ -97,6 +104,6 @@ TEST(PreviewsLitePageNavigationThrottleTest, TestGetPreviewsURL) { ...@@ -97,6 +104,6 @@ TEST(PreviewsLitePageNavigationThrottleTest, TestGetPreviewsURL) {
EXPECT_EQ(PreviewsLitePageNavigationThrottle::GetPreviewsURLForURL( EXPECT_EQ(PreviewsLitePageNavigationThrottle::GetPreviewsURLForURL(
GURL(test_case.original_url)), GURL(test_case.original_url)),
GURL(test_case.previews_url)); GURL(test_case.expected_previews_url));
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment