Revert "win: Make oilpan plugin work better with delayed template parsing."

This reverts commit 28c1b109.

The delayed_parsing.cpp file has no license which is causing license check
failures.

TBR=hans@chromium.org,thakis@chromium.org,rnk@chromium.org
BUG=486571

Review URL: https://codereview.chromium.org/1146563002

Cr-Commit-Position: refs/heads/master@{#330289}

tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

@@ -17,7 +17,6 @@
 #include "clang/AST/RecursiveASTVisitor.h"
 #include "clang/Frontend/CompilerInstance.h"
 #include "clang/Frontend/FrontendPluginRegistry.h"
-#include "clang/Sema/Sema.h"
 
 using namespace clang;
 using std::string;
@@ -145,23 +144,6 @@ const char kClassMustDeclareGCMixinTraceMethod[] =
     "[blink-gc] Class %0 which inherits from GarbageCollectedMixin must"
     " locally declare and override trace(Visitor*)";
 
-// Use a local RAV implementation to simply collect all FunctionDecls marked for
-// late template parsing. This happens with the flag -fdelayed-template-parsing,
-// which is on by default in MSVC-compatible mode.
-std::set<FunctionDecl*> GetLateParsedFunctionDecls(TranslationUnitDecl* decl) {
-  struct Visitor : public RecursiveASTVisitor<Visitor> {
-    bool VisitFunctionDecl(FunctionDecl* function_decl) {
-      if (function_decl->isLateTemplateParsed())
-        late_parsed_decls.insert(function_decl);
-      return true;
-    }
-
-    std::set<FunctionDecl*> late_parsed_decls;
-  } v;
-  v.TraverseDecl(decl);
-  return v.late_parsed_decls;
-}
-
 struct BlinkGCPluginOptions {
   BlinkGCPluginOptions()
     : enable_oilpan(false)
@@ -1035,8 +1017,6 @@ class BlinkGCPluginConsumer : public ASTConsumer {
     if (diagnostic_.hasErrorOccurred())
       return;
 
-    ParseFunctionTemplates(context.getTranslationUnitDecl());
-
     CollectVisitor visitor;
     visitor.TraverseDecl(context.getTranslationUnitDecl());
 
@@ -1083,31 +1063,6 @@ class BlinkGCPluginConsumer : public ASTConsumer {
     }
   }
 
-  void ParseFunctionTemplates(TranslationUnitDecl* decl) {
-    if (!instance_.getLangOpts().DelayedTemplateParsing)
-      return;  // Nothing to do.
-
-    std::set<FunctionDecl*> late_parsed_decls =
-        GetLateParsedFunctionDecls(decl);
-    clang::Sema& sema = instance_.getSema();
-
-    for (const FunctionDecl* fd : late_parsed_decls) {
-      assert(fd->isLateTemplateParsed());
-
-      if (!Config::IsTraceMethod(fd))
-        continue;
-
-      if (instance_.getSourceManager().isInSystemHeader(
-              instance_.getSourceManager().getSpellingLoc(fd->getLocation())))
-        continue;
-
-      // Force parsing and AST building of the yet-uninstantiated function
-      // template trace method bodies.
-      clang::LateParsedTemplate* lpt = sema.LateParsedTemplateMap[fd];
-      sema.LateTemplateParser(sema.OpaqueParser, *lpt);
-    }
-  }
-
   // Main entry for checking a record declaration.
   void CheckRecord(RecordInfo* info) {
     if (IsIgnored(info))

tools/clang/blink_gc_plugin/Config.h

@@ -214,7 +214,7 @@ class Config {
     TRACE_AFTER_DISPATCH_IMPL_METHOD
   };
 
-  static TraceMethodType GetTraceMethodType(const clang::FunctionDecl* method) {
+  static TraceMethodType GetTraceMethodType(clang::FunctionDecl* method) {
     if (method->getNumParams() != 1)
       return NOT_TRACE_METHOD;
 
@@ -244,7 +244,7 @@ class Config {
     return NOT_TRACE_METHOD;
   }
 
-  static bool IsTraceMethod(const clang::FunctionDecl* method) {
+  static bool IsTraceMethod(clang::FunctionDecl* method) {
     return GetTraceMethodType(method) != NOT_TRACE_METHOD;
   }
 

tools/clang/blink_gc_plugin/tests/delayed_parsing.cpp

-#include "heap/stubs.h"
-
-namespace blink {
-
-struct HeapObject : public GarbageCollected<HeapObject> {
-    void trace(Visitor*) { }
-};
-
-template<typename T>
-class TemplateBase
-    : public GarbageCollected<TemplateBase<T> > {
-public:
-    void trace(Visitor* visitor) { visitor->trace(m_obj); }
-private:
-    Member<HeapObject> m_obj;
-};
-
-class Subclass : public TemplateBase<Subclass> {
-};
-
-}

tools/clang/blink_gc_plugin/tests/delayed_parsing.flags

--fdelayed-template-parsing