Skip to content

GitLab

T
tangled
Commit 0a318aff authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot
Browse files
Options

Sort flag descriptions. 

Move some out of place flag descriptions to the right sections.

Change-Id: I61569c122d8b5c93adcad002661a13fc33dcd14a
Reviewed-on: https://chromium-review.googlesource.com/c/1330893
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: default avatarBecca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607870}
parent e3199eeb
Hide whitespace changes
Inline Side-by-side
Showing with 95 additions and 106 deletions
chrome/browser/flag_descriptions.cc
View file @ 0a318aff
......@@ -273,13 +273,6 @@ const char kDatasaverPromptDescription[] =
"Store.";
const char kDatasaverPromptDemoMode[] = "Demo mode";
#if defined(DCHECK_IS_CONFIGURABLE)
const char kDcheckIsFatalName[] = "DCHECKs are fatal";
const char kDcheckIsFatalDescription[] =
"By default Chrome will evaluate in this build, but only log failures, "
"rather than crashing. If enabled, DCHECKs will crash the calling process.";
#endif // defined(DCHECK_IS_CONFIGURABLE)
const char kDebugPackedAppName[] = "Debugging for packed apps";
const char kDebugPackedAppDescription[] =
"Enables debugging context menu options such as Inspect Element for packed "
......@@ -1799,21 +1792,6 @@ const char kSingleTabMode[] = "Single-tab mode";
const char kSingleTabModeDescription[] =
"Windows with a single tab receive a special, minimal visual treatment.";
#if defined(OS_ANDROID)
const char kStrictSiteIsolationName[] = "Strict site isolation";
const char kStrictSiteIsolationDescription[] =
"Security mode that enables site isolation for all sites (SitePerProcess). "
"In this mode, each renderer process will contain pages from at most one "
"site, using out-of-process iframes when needed. "
"Check chrome://process-internals to see the current isolation mode. "
"Setting this flag to 'Enabled' turns on site isolation regardless of the "
"default. Here, 'Disabled' is a legacy value that actually means "
"'Default,' in which case site isolation may be already enabled based on "
"platform, enterprise policy, or field trial. See also "
"#site-isolation-trial-opt-out for how to disable site isolation for "
"testing.";
#endif
const char kSiteIsolationOptOutName[] = "Disable site isolation";
const char kSiteIsolationOptOutDescription[] =
"Disables site isolation "
......@@ -2139,6 +2117,13 @@ const char kWebrtcEchoCanceller3Name[] = "WebRTC Echo Canceller 3.";
const char kWebrtcEchoCanceller3Description[] =
"Experimental WebRTC echo canceller (AEC3).";
const char kWebrtcH264WithOpenh264FfmpegName[] =
"WebRTC H.264 software video encoder/decoder";
const char kWebrtcH264WithOpenh264FfmpegDescription[] =
"When enabled, an H.264 software video encoder/decoder pair is included. "
"If a hardware encoder/decoder is also available it may be used instead of "
"this encoder/decoder.";
const char kWebrtcHideLocalIpsWithMdnsName[] =
"Anonymize local IPs exposed by WebRTC.";
const char kWebrtcHideLocalIpsWithMdnsDecription[] =
......@@ -2193,6 +2178,14 @@ const char kWebrtcStunOriginDescription[] =
"When enabled, Stun messages generated by WebRTC will contain the Origin "
"header.";
const char kWebrtcUnifiedPlanByDefaultName[] =
"WebRTC: Use Unified Plan SDP Semantics by default";
const char kWebrtcUnifiedPlanByDefaultDescription[] =
"RTCPeerConnections generate and expect the standards compliant SDP format "
"called \"Unified Plan\", unless \"Plan B\" is explicitly specified by "
"passing {sdpSemantics:'plan-b'} to the RTCPeerConnection constructor. "
"RTCRtpTransceiver support is also enabled in Unified Plan.";
const char kWebSocketHandshakeReuseConnectionName[] =
"Enable WebSocket connection reuse for authentication";
const char kWebSocketHandshakeReuseConnectionDescription[] =
......@@ -2368,9 +2361,10 @@ const char kContextualSearchUnityIntegrationName[] =
const char kContextualSearchUnityIntegrationDescription[] =
"Enables integration of Tap to Search with Unified Consent.";
const char kExploreSitesName[] = "Explore websites";
const char kExploreSitesDescription[] =
"Enables portal from new tab page to explore websites.";
const char kDisplayCutoutAPIName[] =
"Enable support for the Display Cutout API";
const char kDisplayCutoutAPIDescription[] =
"Enables developers to support devices that have a display cutout.";
const char kDontPrefetchLibrariesName[] = "Don't Prefetch Libraries";
const char kDontPrefetchLibrariesDescription[] =
......@@ -2522,6 +2516,10 @@ const char kEphemeralTabName[] = "An Ephemeral Tab in an Overlay Panel";
const char kEphemeralTabDescription[] =
"Enable a 'sneak peek' at a linked page in an overlay.";
const char kExploreSitesName[] = "Explore websites";
const char kExploreSitesDescription[] =
"Enables portal from new tab page to explore websites.";
const char kGrantNotificationsToDSEName[] =
"Grant notifications to the Default Search Engine";
const char kGrantNotificationsToDSENameDescription[] =
......@@ -2764,6 +2762,19 @@ const char kSiteExplorationUiName[] = "Site Exploration UI";
const char kSiteExplorationUiDescription[] =
"Show site suggestions in the Exploration UI";
const char kStrictSiteIsolationName[] = "Strict site isolation";
const char kStrictSiteIsolationDescription[] =
"Security mode that enables site isolation for all sites (SitePerProcess). "
"In this mode, each renderer process will contain pages from at most one "
"site, using out-of-process iframes when needed. "
"Check chrome://process-internals to see the current isolation mode. "
"Setting this flag to 'Enabled' turns on site isolation regardless of the "
"default. Here, 'Disabled' is a legacy value that actually means "
"'Default,' in which case site isolation may be already enabled based on "
"platform, enterprise policy, or field trial. See also "
"#site-isolation-trial-opt-out for how to disable site isolation for "
"testing.";
const char kTranslateAndroidManualTriggerName[] =
"Enable manual translate trigger";
const char kTranslateAndroidManualTriggerDescription[] =
......@@ -2843,11 +2854,11 @@ const char kEnableAudioFocusEnabledDuckFlash[] =
const char kEnableAudioFocusEnabledNoEnforce[] =
"Enabled (without enforcement of a single active media session)";
const char kInfiniteSessionRestoreName[] = "Infinite Session Restore";
const char kInfiniteSessionRestoreDescription[] =
"Reduces the number of tabs being loaded simultaneously during session "
"restore, to improve responsiveness of the foreground tab. This requires "
"#enable-page-almost-idle.";
const char kEnableWebAuthenticationBleSupportName[] =
"Web Authentication API BLE support";
const char kEnableWebAuthenticationBleSupportDescription[] =
"Enable support for using Web Authentication API via Bluetooth security "
"keys";
const char kEnableWebAuthenticationCtap2SupportName[] =
"Enable Web Authentication API support for CTAP2 security keys";
......@@ -2861,24 +2872,16 @@ const char kEnableWebAuthenticationTestingAPIDescription[] =
"implementation from the real world, and allows configuring virtual "
"authenticator devices for testing";
const char kEnableWebAuthenticationBleSupportName[] =
"Web Authentication API BLE support";
const char kEnableWebAuthenticationBleSupportDescription[] =
"Enable support for using Web Authentication API via Bluetooth security "
"keys";
const char kHappinessTrackingSurveysForDesktopName[] =
"Happiness Tracking Surveys";
const char kHappinessTrackingSurveysForDesktopDescription[] =
"Enable showing Happiness Tracking Surveys to users on Desktop";
const char kOmniboxRichEntitySuggestionsName[] =
"Omnibox rich entity suggestions";
const char kOmniboxRichEntitySuggestionsDescription[] =
"Display entity suggestions using images and an enhanced layout; showing "
"more context and descriptive text about the entity. Has no effect unless "
"either the #upcoming-ui-features flag is Enabled or the #top-chrome-md "
"flag is set to Refresh or Touchable Refresh.";
const char kInfiniteSessionRestoreName[] = "Infinite Session Restore";
const char kInfiniteSessionRestoreDescription[] =
"Reduces the number of tabs being loaded simultaneously during session "
"restore, to improve responsiveness of the foreground tab. This requires "
"#enable-page-almost-idle.";
const char kOmniboxDriveSuggestionsName[] =
"Omnibox Google Drive Document suggestions";
......@@ -2892,12 +2895,27 @@ const char kOmniboxNewAnswerLayoutDescription[] =
"effect unless either the #upcoming-ui-features flag is Enabled or the "
"#top-chrome-md flag is set to Refresh or Touchable Refresh.";
const char kOmniboxPedalSuggestionsName[] = "Omnibox Pedal suggestions";
const char kOmniboxPedalSuggestionsDescription[] =
"Enable omnibox Pedal suggestions using either a side button in suggestion "
"or a dedicated suggestion item beneath the triggering line item. Omnibox "
"Pedals accelerate actions within Chrome by detecting user intent and "
"offering direct access to the end goal.";
const char kOmniboxReverseAnswersName[] = "Omnibox reverse answers";
const char kOmniboxReverseAnswersDescription[] =
"Display answers with rows reversed (swapped); except definitions. Has no "
"effect unless either the #upcoming-ui-features flag is Enabled or the "
"#top-chrome-md flag is set to Refresh or Touchable Refresh.";
const char kOmniboxRichEntitySuggestionsName[] =
"Omnibox rich entity suggestions";
const char kOmniboxRichEntitySuggestionsDescription[] =
"Display entity suggestions using images and an enhanced layout; showing "
"more context and descriptive text about the entity. Has no effect unless "
"either the #upcoming-ui-features flag is Enabled or the #top-chrome-md "
"flag is set to Refresh or Touchable Refresh.";
const char kOmniboxTabSwitchSuggestionsName[] =
"Omnibox tab switch suggestions";
const char kOmniboxTabSwitchSuggestionsDescription[] =
......@@ -2905,13 +2923,6 @@ const char kOmniboxTabSwitchSuggestionsDescription[] =
"Has no effect unless either the #upcoming-ui-features flag is Enabled or "
"the #top-chrome-md flag is set to Refresh or Touchable Refresh.";
const char kOmniboxPedalSuggestionsName[] = "Omnibox Pedal suggestions";
const char kOmniboxPedalSuggestionsDescription[] =
"Enable omnibox Pedal suggestions using either a side button in suggestion "
"or a dedicated suggestion item beneath the triggering line item. Omnibox "
"Pedals accelerate actions within Chrome by detecting user intent and "
"offering direct access to the end goal.";
const char kOmniboxTailSuggestionsName[] = "Omnibox tail suggestions";
const char kOmniboxTailSuggestionsDescription[] =
"Enable receiving tail suggestions, a type of search suggestion based on "
......@@ -3290,9 +3301,9 @@ const char kEnableAppsGridGapFeatureDescription[] =
"Enables gaps at the end of each page and enables dragging an item to an "
"empty page in launcher.";
extern const char kEnableArcUnifiedAudioFocusName[] =
const char kEnableArcUnifiedAudioFocusName[] =
"Enable unified audio focus on ARC";
extern const char kEnableArcUnifiedAudioFocusDescription[] =
const char kEnableArcUnifiedAudioFocusDescription[] =
"If audio focus is enabled in Chrome then this will delegate audio focus "
"control in Android apps to Chrome.";
......@@ -3717,6 +3728,13 @@ const char kExperimentalUiDescription[] = "Use all upcoming UI features.";
// Feature flags --------------------------------------------------------------
#if defined(DCHECK_IS_CONFIGURABLE)
const char kDcheckIsFatalName[] = "DCHECKs are fatal";
const char kDcheckIsFatalDescription[] =
"By default Chrome will evaluate in this build, but only log failures, "
"rather than crashing. If enabled, DCHECKs will crash the calling process.";
#endif // defined(DCHECK_IS_CONFIGURABLE)
#if BUILDFLAG(ENABLE_VR)
const char kWebVrVsyncAlignName[] = "WebVR VSync-aligned timing";
......@@ -3775,21 +3793,6 @@ const char kPnaclSubzeroDescription[] =
#endif // BUILDFLAG(ENABLE_NACL)
const char kWebrtcH264WithOpenh264FfmpegName[] =
"WebRTC H.264 software video encoder/decoder";
const char kWebrtcH264WithOpenh264FfmpegDescription[] =
"When enabled, an H.264 software video encoder/decoder pair is included. "
"If a hardware encoder/decoder is also available it may be used instead of "
"this encoder/decoder.";
const char kWebrtcUnifiedPlanByDefaultName[] =
"WebRTC: Use Unified Plan SDP Semantics by default";
const char kWebrtcUnifiedPlanByDefaultDescription[] =
"RTCPeerConnections generate and expect the standards compliant SDP format "
"called \"Unified Plan\", unless \"Plan B\" is explicitly specified by "
"passing {sdpSemantics:'plan-b'} to the RTCPeerConnection constructor. "
"RTCRtpTransceiver support is also enabled in Unified Plan.";
#if defined(TOOLKIT_VIEWS) || defined(OS_ANDROID)
const char kAutofillCreditCardUploadName[] =
......@@ -3800,15 +3803,6 @@ const char kAutofillCreditCardUploadDescription[] =
#endif // defined(TOOLKIT_VIEWS) || defined(OS_ANDROID)
#if defined(OS_ANDROID)
const char kDisplayCutoutAPIName[] =
"Enable support for the Display Cutout API";
const char kDisplayCutoutAPIDescription[] =
"Enables developers to support devices that have a display cutout.";
#endif // defined(OS_ANDROID)
// ============================================================================
// Don't just add flags to the end, put them in the right section in
// alphabetical order just like the header file.
......
chrome/browser/flag_descriptions.h
View file @ 0a318aff
......@@ -194,11 +194,6 @@ extern const char kDatasaverPromptName[];
extern const char kDatasaverPromptDescription[];
extern const char kDatasaverPromptDemoMode[];
#if defined(DCHECK_IS_CONFIGURABLE)
extern const char kDcheckIsFatalName[];
extern const char kDcheckIsFatalDescription[];
#endif // defined(DCHECK_IS_CONFIGURABLE)
extern const char kDebugPackedAppName[];
extern const char kDebugPackedAppDescription[];
......@@ -1085,11 +1080,6 @@ extern const char kSingleClickAutofillDescription[];
extern const char kSingleTabMode[];
extern const char kSingleTabModeDescription[];
#if defined(OS_ANDROID)
extern const char kStrictSiteIsolationName[];
extern const char kStrictSiteIsolationDescription[];
#endif
extern const char kSiteIsolationOptOutName[];
extern const char kSiteIsolationOptOutDescription[];
extern const char kSiteIsolationOptOutChoiceDefault[];
......@@ -1287,6 +1277,9 @@ extern const char kWebPaymentsModifiersDescription[];
extern const char kWebrtcEchoCanceller3Name[];
extern const char kWebrtcEchoCanceller3Description[];
extern const char kWebrtcH264WithOpenh264FfmpegName[];
extern const char kWebrtcH264WithOpenh264FfmpegDescription[];
extern const char kWebrtcHideLocalIpsWithMdnsName[];
extern const char kWebrtcHideLocalIpsWithMdnsDecription[];
......@@ -1319,8 +1312,6 @@ extern const char kWebrtcSrtpEncryptedHeadersDescription[];
extern const char kWebrtcStunOriginName[];
extern const char kWebrtcStunOriginDescription[];
extern const char kWebrtcH264WithOpenh264FfmpegName[];
extern const char kWebrtcH264WithOpenh264FfmpegDescription[];
extern const char kWebrtcUnifiedPlanByDefaultName[];
extern const char kWebrtcUnifiedPlanByDefaultDescription[];
......@@ -1427,8 +1418,8 @@ extern const char kContextualSearchSecondTapDescription[];
extern const char kContextualSearchUnityIntegrationName[];
extern const char kContextualSearchUnityIntegrationDescription[];
extern const char kExploreSitesName[];
extern const char kExploreSitesDescription[];
extern const char kDisplayCutoutAPIName[];
extern const char kDisplayCutoutAPIDescription[];
extern const char kDontPrefetchLibrariesName[];
extern const char kDontPrefetchLibrariesDescription[];
......@@ -1517,6 +1508,9 @@ extern const char kEnableWebPaymentsMethodSectionOrderV2Description[];
extern const char kEphemeralTabName[];
extern const char kEphemeralTabDescription[];
extern const char kExploreSitesName[];
extern const char kExploreSitesDescription[];
extern const char kGrantNotificationsToDSEName[];
extern const char kGrantNotificationsToDSENameDescription[];
......@@ -1662,6 +1656,9 @@ extern const char kSiteExplorationUiDescription[];
extern const char kSpannableInlineAutocompleteName[];
extern const char kSpannableInlineAutocompleteDescription[];
extern const char kStrictSiteIsolationName[];
extern const char kStrictSiteIsolationDescription[];
extern const char kTranslateAndroidManualTriggerName[];
extern const char kTranslateAndroidManualTriggerDescription[];
......@@ -1711,15 +1708,15 @@ extern const char kEnableAudioFocusEnabled[];
extern const char kEnableAudioFocusEnabledDuckFlash[];
extern const char kEnableAudioFocusEnabledNoEnforce[];
extern const char kEnableWebAuthenticationBleSupportName[];
extern const char kEnableWebAuthenticationBleSupportDescription[];
extern const char kEnableWebAuthenticationCtap2SupportName[];
extern const char kEnableWebAuthenticationCtap2SupportDescription[];
extern const char kEnableWebAuthenticationTestingAPIName[];
extern const char kEnableWebAuthenticationTestingAPIDescription[];
extern const char kEnableWebAuthenticationBleSupportName[];
extern const char kEnableWebAuthenticationBleSupportDescription[];
extern const char kHappinessTrackingSurveysForDesktopName[];
extern const char kHappinessTrackingSurveysForDesktopDescription[];
......@@ -1729,21 +1726,21 @@ extern const char kInfiniteSessionRestoreDescription[];
extern const char kOmniboxDriveSuggestionsName[];
extern const char kOmniboxDriveSuggestionsDescriptions[];
extern const char kOmniboxRichEntitySuggestionsName[];
extern const char kOmniboxRichEntitySuggestionsDescription[];
extern const char kOmniboxNewAnswerLayoutName[];
extern const char kOmniboxNewAnswerLayoutDescription[];
extern const char kOmniboxPedalSuggestionsName[];
extern const char kOmniboxPedalSuggestionsDescription[];
extern const char kOmniboxReverseAnswersName[];
extern const char kOmniboxReverseAnswersDescription[];
extern const char kOmniboxRichEntitySuggestionsName[];
extern const char kOmniboxRichEntitySuggestionsDescription[];
extern const char kOmniboxTabSwitchSuggestionsName[];
extern const char kOmniboxTabSwitchSuggestionsDescription[];
extern const char kOmniboxPedalSuggestionsName[];
extern const char kOmniboxPedalSuggestionsDescription[];
extern const char kOmniboxTailSuggestionsName[];
extern const char kOmniboxTailSuggestionsDescription[];
......@@ -2257,6 +2254,11 @@ extern const char kDirectManipulationStylusDescription[];
// Feature flags --------------------------------------------------------------
#if defined(DCHECK_IS_CONFIGURABLE)
extern const char kDcheckIsFatalName[];
extern const char kDcheckIsFatalDescription[];
#endif // defined(DCHECK_IS_CONFIGURABLE)
#if BUILDFLAG(ENABLE_VR)
extern const char kWebVrVsyncAlignName[];
......@@ -2305,13 +2307,6 @@ extern const char kAutofillCreditCardUploadDescription[];
#endif // defined(TOOLKIT_VIEWS) || defined(OS_ANDROID)
#if defined(OS_ANDROID)
extern const char kDisplayCutoutAPIName[];
extern const char kDisplayCutoutAPIDescription[];
#endif // defined(OS_ANDROID)
// ============================================================================
// Don't just add flags to the end, put them in the right section in
// alphabetical order. See top instructions for more.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment