[bindings] Use std::string instead StringPiece as ScripId type

Changes to use std:string as ScriptId type which has been changed to
base::StringPiece on CastWebContents. Using base::StringPiece breaks the
normal behavior of injecting JS bindings and the browsertest. Changing
it back to std::string fixed the problem.

Bug: internal b/163431947, b/132986916
Test: cast_shell_internal_browsertest, CQ
Change-Id: I2a4cef5f208880816a4be3068e4e460dd9cf9fcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350314Reviewed-by: Sean Topping <seantopping@chromium.org>
Auto-Submit: Jiawei Li <lijiawei@chromium.org>
Commit-Queue: Jiawei Li <lijiawei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797101}

chromecast/browser/cast_web_contents.h

@@ -14,7 +14,6 @@
 #include "base/optional.h"
 #include "base/process/process.h"
 #include "base/strings/string16.h"
-#include "base/strings/string_piece_forward.h"
 #include "chromecast/common/mojom/feature_manager.mojom.h"
 #include "content/public/common/media_playback_renderer_type.mojom.h"
 #include "services/service_manager/public/cpp/binder_registry.h"
@@ -343,7 +342,7 @@ class CastWebContents {
 
   // Returns the script injector instance, which injects scripts at page load
   // time.
-  virtual on_load_script_injector::OnLoadScriptInjectorHost<base::StringPiece>*
+  virtual on_load_script_injector::OnLoadScriptInjectorHost<std::string>*
   script_injector() = 0;
 
   // Injects on-load scripts into the WebContents' main frame.

chromecast/browser/cast_web_contents_impl.cc

@@ -10,7 +10,6 @@
 #include "base/bind_helpers.h"
 #include "base/no_destructor.h"
 #include "base/optional.h"
-#include "base/strings/string_piece.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/sequenced_task_runner_handle.h"
 #include "base/values.h"
@@ -335,7 +334,7 @@ void CastWebContentsImpl::ClearRenderWidgetHostView() {
   }
 }
 
-on_load_script_injector::OnLoadScriptInjectorHost<base::StringPiece>*
+on_load_script_injector::OnLoadScriptInjectorHost<std::string>*
 CastWebContentsImpl::script_injector() {
   return &script_injector_;
 }

chromecast/browser/cast_web_contents_impl.h

@@ -19,7 +19,6 @@
 #include "base/memory/weak_ptr.h"
 #include "base/optional.h"
 #include "base/sequence_checker.h"
-#include "base/strings/string_piece_forward.h"
 #include "base/time/time.h"
 #include "chromecast/browser/cast_media_blocker.h"
 #include "chromecast/browser/cast_web_contents.h"
@@ -71,7 +70,7 @@ class CastWebContentsImpl : public CastWebContents,
   void BlockMediaLoading(bool blocked) override;
   void BlockMediaStarting(bool blocked) override;
   void EnableBackgroundVideoPlayback(bool enabled) override;
-  on_load_script_injector::OnLoadScriptInjectorHost<base::StringPiece>*
+  on_load_script_injector::OnLoadScriptInjectorHost<std::string>*
   script_injector() override;
   void InjectScriptsIntoMainFrame() override;
   void PostMessageToMainFrame(
@@ -178,7 +177,7 @@ class CastWebContentsImpl : public CastWebContents,
   bool notifying_;
   int last_error_;
 
-  on_load_script_injector::OnLoadScriptInjectorHost<base::StringPiece>
+  on_load_script_injector::OnLoadScriptInjectorHost<std::string>
       script_injector_;
 
   base::ObserverList<Observer>::Unchecked observer_list_;

chromecast/browser/test/mock_cast_web_view.h

@@ -38,8 +38,7 @@ class MockCastWebContents : public CastWebContents {
   MOCK_METHOD(void, BlockMediaLoading, (bool), (override));
   MOCK_METHOD(void, BlockMediaStarting, (bool), (override));
   MOCK_METHOD(void, EnableBackgroundVideoPlayback, (bool), (override));
-  MOCK_METHOD(
-      on_load_script_injector::OnLoadScriptInjectorHost<base::StringPiece>*,
+  MOCK_METHOD(on_load_script_injector::OnLoadScriptInjectorHost<std::string>*,
               script_injector,
               (),
               (override));