Add chrome://settings buttons to choose opt-in to account passwords storage

Feature kEnablePasswordsAccountStorage disabled:
https://screenshot.googleplex.com/AaNqS7OxpNw

Feature enabled, user not opted in:
https://screenshot.googleplex.com/RBR6E3yzmkk

Feature enabled, user opted in:
https://screenshot.googleplex.com/4GbzCGPeddp

On click of the opt-in button, a reauth flow will be triggered. On
click of the opt-out button, no reauth is triggered. The UI is only
temporary and will be updated once mocks are available.

Bug: 1049141
Change-Id: Iceb293f3809e8995056a7c36989a6abeb462db62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108030Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#753165}

chrome/app/settings_strings.grdp

@@ -509,6 +509,14 @@
   <message name="IDS_SETTINGS_PASSWORDS_MANAGE_PASSWORDS" desc="Shown in the passwords section of settings. Descriptive text to inform that passwords can be accessed online. Has a link.">
     View and manage saved passwords in your <ph name="BEGIN_LINK">&lt;a is="action-link" href="$1" target="_blank"&gt;</ph>Google Account<ph name="END_LINK">&lt;/a&gt;</ph>
   </message>
+  <!-- TODO(crbug.com/1062344): Make it translateable and use definitive label once final mocks are available. -->
+  <message translateable="false" name="IDS_SETTINGS_PASSWORDS_OPT_IN_ACCOUNT_STORAGE_LABEL" desc="Label for a button in the passwords section of settings triggering opt in to passwords account storage.">
+    Opt-in to account storage
+  </message>
+  <!-- TODO(crbug.com/1062344): Make it translateable and use definitive label once final mocks are available. -->
+  <message translateable="false" name="IDS_SETTINGS_PASSWORDS_OPT_OUT_ACCOUNT_STORAGE_LABEL" desc="Label for a button in the passwords section of settings triggering opt out of passwords account storage.">
+    Opt-out of account storage
+  </message>
   <message name="IDS_SETTINGS_PASSWORDS_EXPORT_MENU_ITEM" desc="A menu item in the More Actions menu above the password list in Chrome's settings. Selecting this action will open a dialog, through which the user can export their passwords outside of Chrome.">
     Export passwords...
   </message>

chrome/browser/resources/settings/autofill_page/password_manager_proxy.js

@@ -151,6 +151,12 @@
    */
   isOptedInForAccountStorage() {}
 
+  /**
+   * Triggers the opt-in or opt-out flow for the account storage.
+   * @param {boolean} optIn Whether the user wants to opt in or opt out.
+   */
+  optInForAccountStorage(optIn) {}
+
   /**
    * Requests the start of the bulk password check.
    */
@@ -382,6 +388,11 @@ PasswordManagerProxy.PasswordCheckStatus;
     });
   }
 
+  /** @override */
+  optInForAccountStorage(optIn) {
+    chrome.passwordsPrivate.optInForAccountStorage(optIn);
+  }
+
   /** @override */
   startBulkPasswordCheck() {
     chrome.passwordsPrivate.startPasswordCheck();

chrome/browser/resources/settings/autofill_page/passwords_section.html

@@ -158,6 +158,16 @@
       <!-- This span lays out the url correctly, relative to the label. -->
       <span>$i18nRaw{managePasswordsLabel}</span>
     </div>
+    <template is="dom-if" if="[[enableAccountStorage_]]">
+      <cr-button on-click="onOptIn_"
+          hidden$="[[isOptedInForAccountStorage_]]">
+          $i18n{optInAccountStorageLabel}
+      </cr-button>
+      <cr-button on-click="onOptOut_"
+          hidden$="[[!isOptedInForAccountStorage_]]">
+          $i18n{optOutAccountStorageLabel}
+      </cr-button>
+    </template>
     <div class="settings-box first">
       <h2 id="savedPasswordsHeading" class="start">
         $i18n{savedPasswordsHeading}

chrome/browser/resources/settings/autofill_page/passwords_section.js

@@ -152,6 +152,14 @@ Polymer({
       }
     },
 
+    /** @private */
+    enableAccountStorage_: {
+      type: Boolean,
+      value() {
+        return loadTimeData.getBoolean('enableAccountStorage');
+      }
+    },
+
     /** @private */
     showPasswordEditDialog_: Boolean,
 
@@ -594,6 +602,16 @@ Polymer({
     cr.ui.focusWithoutInk(assert(this.activeDialogAnchorStack_.pop()));
   },
 
+  /** @private */
+  onOptIn_: function() {
+    this.passwordManager_.optInForAccountStorage(true);
+  },
+
+  /** @private */
+  onOptOut_: function() {
+    this.passwordManager_.optInForAccountStorage(false);
+  },
+
   /**
    * Returns true if the list exists and has items.
    * @param {Array<Object>} list

chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc

@@ -845,6 +845,10 @@ void AddAutofillStrings(content::WebUIDataSource* html_source,
       {"noExceptionsFound", IDS_SETTINGS_PASSWORDS_EXCEPTIONS_NONE},
       {"import", IDS_PASSWORD_MANAGER_IMPORT_BUTTON},
       {"exportMenuItem", IDS_SETTINGS_PASSWORDS_EXPORT_MENU_ITEM},
+      {"optInAccountStorageLabel",
+       IDS_SETTINGS_PASSWORDS_OPT_IN_ACCOUNT_STORAGE_LABEL},
+      {"optOutAccountStorageLabel",
+       IDS_SETTINGS_PASSWORDS_OPT_OUT_ACCOUNT_STORAGE_LABEL},
       {"undoRemovePassword", IDS_SETTINGS_PASSWORD_UNDO},
       {"passwordDeleted", IDS_SETTINGS_PASSWORD_DELETED_PASSWORD},
       {"passwordRowMoreActionsButton", IDS_SETTINGS_PASSWORD_ROW_MORE_ACTIONS},

chrome/browser/ui/webui/settings/settings_ui.cc

@@ -268,6 +268,11 @@ SettingsUI::SettingsUI(content::WebUI* web_ui)
                           base::FeatureList::IsEnabled(
                               password_manager::features::kPasswordImport));
 
+  html_source->AddBoolean(
+      "enableAccountStorage",
+      base::FeatureList::IsEnabled(
+          password_manager::features::kEnablePasswordsAccountStorage));
+
   html_source->AddBoolean(
       "syncSetupFriendlySettings",
       base::FeatureList::IsEnabled(features::kSyncSetupFriendlySettings));