Skip to content

GitLab

T
tangled
Commit 0c415398 authored by Philip Rogers's avatar Philip Rogers Committed by Commit Bot
Browse files
Options

[BlinkGenPropertyTrees] Wire up popup painting 

This patch fixes two bugs where popups were not painted:
1) Popups were not hooked up because the BGPT/SPV2 AttachRootLayer
function was not implemented on WebPagePopupImpl. This has been
implemented.
2) Popup layers were not painted. Popups are not attached to the
viewport layers and were not found via the recursive paint walk. Popups
are now special-cased so they are painted.

A DCHECK has been added in layer_tree_host to make this sort of bug
easier to debug. Instead of NPE in some random layer code, we now
DCHECK.

Bug: 853951
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia7bbcd4c27f860ada232d28c89ab672d60995aec
Reviewed-on: https://chromium-review.googlesource.com/1117216Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570960}
parent 62d16d51
Show whitespace changes
Inline Side-by-side
Showing with 65 additions and 207 deletions
cc/trees/layer_tree_host.cc
View file @ 0c415398
......@@ -787,6 +787,21 @@ bool LayerTreeHost::DoUpdateLayers(Layer* root_layer) {
property_trees->AsTracedValue());
}
#if DCHECK_IS_ON()
// Ensure property tree nodes were created for all layers. When using layer
// lists, this can fail if blink doesn't setup layers or nodes correctly in
// |PaintArtifactCompositor|. When not using layer lists, this can fail if
// |PropertyTreeBuilder::BuildPropertyTrees| fails to create property tree
// nodes.
for (auto* layer : *this) {
DCHECK(property_trees_.effect_tree.Node(layer->effect_tree_index()));
DCHECK(
property_trees_.transform_tree.Node(layer->transform_tree_index()));
DCHECK(property_trees_.clip_tree.Node(layer->clip_tree_index()));
DCHECK(property_trees_.scroll_tree.Node(layer->scroll_tree_index()));
}
#endif
draw_property_utils::UpdatePropertyTrees(this, property_trees);
draw_property_utils::FindLayersThatNeedUpdates(this, property_trees,
&update_layer_list);
......
third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
View file @ 0c415398
......@@ -486,148 +486,6 @@ crbug.com/853943 fast/borders/overflow-hidden-border-radius-force-backing-store.
# Something with the pattern is wrong. Needs investigation.
crbug.com/853947 fast/canvas/synchronous-create-pattern.html [ Failure ]
# Form-related popup tests are crashing.
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-appearance-ar.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-appearance-coarse.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-appearance-minimum-date.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-appearance-required.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-appearance-ru.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-appearance-step.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-appearance-zoom125.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-appearance-zoom200.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-appearance.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-date-types.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-datetimelocal-with-step.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-datetimelocal.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-key-operations.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-mouse-operations.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-pre-100-year.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-should-not-change-datetimelocal-time.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-touch-operations.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-type-change-onchange.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/calendar-picker-with-step.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/date-open-picker-with-f4-key.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/date-picker-ax.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/date-picker-choose-default-value-after-set-value.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/date-picker-events.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/datetimelocal-change-type-on-input-crash.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/datetimelocal-open-picker-with-f4-key.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/datetimelocal-picker-choose-default-value-after-set-value.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/datetimelocal-picker-events.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/month-open-picker-with-f4-key.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/month-picker-appearance-step.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/month-picker-appearance.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/month-picker-ax.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/month-picker-choose-default-value-after-set-value.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/month-picker-key-operations.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/month-picker-mouse-operations.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/month-picker-touch-operations.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/month-picker-with-step.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/week-open-picker-with-f4-key.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/week-picker-appearance-step.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/week-picker-appearance.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/week-picker-ax.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/week-picker-choose-default-value-after-set-value.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/week-picker-close-no-crash.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/week-picker-key-operations.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/week-picker-mouse-operations.html [ Crash ]
crbug.com/853951 fast/forms/calendar-picker/week-picker-touch-operations.html [ Crash ]
crbug.com/853951 fast/forms/color/color-suggestion-picker-appearance-value-attribute.html [ Crash ]
crbug.com/853951 fast/forms/color/color-suggestion-picker-appearance-zoom125.html [ Crash ]
crbug.com/853951 fast/forms/color/color-suggestion-picker-appearance-zoom200.html [ Pass Failure Crash ]
crbug.com/853951 fast/forms/color/color-suggestion-picker-appearance.html [ Crash ]
crbug.com/853951 fast/forms/color/color-suggestion-picker-crash-on-set-value.html [ Crash ]
crbug.com/853951 fast/forms/color/color-suggestion-picker-one-row-appearance.html [ Crash ]
crbug.com/853951 fast/forms/color/color-suggestion-picker-two-row-appearance.html [ Crash ]
crbug.com/853951 fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html [ Pass Failure Crash ]
crbug.com/853951 fast/forms/page-popup/page-popup-adjust-rect.html [ Crash ]
crbug.com/853951 fast/forms/page-popup/page-popup-hide-window.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-coarse.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-empty.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-fractional-width.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-long.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-many.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-minimum-font.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-rtl-default.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-rtl.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-single-option.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-styled.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-tall.html [ Pass Failure Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-texttransform.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-transform.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-zoom.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-zoom090.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance-zoom110.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-appearance.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-ax.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-crash-on-cancel.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-crash-on-close.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-crash-on-select.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-crash-on-style-update.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-event-order.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-font-face.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-key-operations.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-mouse-operations.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-multiline-title.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-nested-style.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-non-latin-update-from-element.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-open-partially-visible.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-position.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-resize-after-open.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-size.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-touch-operations.html [ Crash ]
crbug.com/853951 fast/forms/select-popup/popup-menu-update-from-element.html [ Crash ]
crbug.com/853951 fast/forms/select/menulist-popup-item-style.html [ Crash ]
crbug.com/853951 fast/forms/select/menulist-popup-open-hide-using-keyboard.html [ Crash ]
crbug.com/853951 fast/forms/select/menulist-popup-type-ahead-style-change.html [ Crash ]
crbug.com/853951 fast/forms/select/menulist-update-text-popup.html [ Crash ]
crbug.com/853951 fast/forms/select/optgroup-clicking.html [ Crash ]
crbug.com/853951 fast/forms/select/select-popup-close-no-crash.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html [ Pass Failure Crash ]
crbug.com/853951 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html [ Pass Failure Crash ]
crbug.com/853951 fast/forms/suggestion-picker/date-suggestion-picker-appearance.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-min-max-attribute.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-reset-value-after-reload.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-step-attribute.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/month-suggestion-picker-appearance.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/month-suggestion-picker-min-max-attribute.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/month-suggestion-picker-mouse-operations.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/month-suggestion-picker-reset-value-after-reload.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/month-suggestion-picker-step-attribute.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/time-suggestion-picker-appearance.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/time-suggestion-picker-key-operations.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/week-suggestion-picker-appearance.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/week-suggestion-picker-key-operations.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/week-suggestion-picker-min-max-attribute.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/week-suggestion-picker-mouse-operations.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/week-suggestion-picker-reset-value-after-reload.html [ Crash ]
crbug.com/853951 fast/forms/suggestion-picker/week-suggestion-picker-step-attribute.html [ Crash ]
# Composited multicolumn paints differently.
crbug.com/854192 fast/multicol/composited-layer-nested.html [ Failure ]
crbug.com/854192 fast/multicol/vertical-rl/composited-relpos-overlapping-will-change.html [ Failure ]
......
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
View file @ 0c415398
......@@ -886,63 +886,44 @@ crbug.com/462142 fast/css3-text/css3-text-decoration/text-decoration-style-inher
Bug(none) fast/events/overflow-composited-scroll-fake-mouse-move.html [ Skip ]
crbug.com/654554 compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-ar.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-coarse.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-minimum-date.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-required.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-ru.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-step.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-zoom125.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-zoom200.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/month-picker-appearance-step.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/month-picker-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/week-picker-appearance-step.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/calendar-picker/week-picker-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/color/color-suggestion-picker-appearance-zoom125.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/color/color-suggestion-picker-appearance-zoom200.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/color/color-suggestion-picker-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/color/color-suggestion-picker-one-row-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/color/color-suggestion-picker-two-row-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-empty.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-fractional-width.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-long.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-many.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-minimum-font.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-rtl-default.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-rtl.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-single-option.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-styled.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-tall.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-texttransform.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-transform.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-zoom.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-zoom090.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-zoom110.html [ Timeout Crash Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/select/input-select-after-resize.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/date-suggestion-picker-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/month-suggestion-picker-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/time-suggestion-picker-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar.html [ Crash Timeout Failure ]
crbug.com/654554 fast/forms/suggestion-picker/week-suggestion-picker-appearance.html [ Crash Timeout Failure ]
crbug.com/654554 compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-ar.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-coarse.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-minimum-date.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-required.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-ru.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-step.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-zoom125.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance-zoom200.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/calendar-picker-appearance.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/month-picker-appearance-step.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/month-picker-appearance.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/week-picker-appearance-step.html [ Failure ]
crbug.com/654554 fast/forms/calendar-picker/week-picker-appearance.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-empty.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-fractional-width.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-long.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-many.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-minimum-font.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-rtl-default.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-rtl.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-single-option.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-styled.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-tall.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-texttransform.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-transform.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-zoom.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-zoom090.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance-zoom110.html [ Failure ]
crbug.com/654554 fast/forms/select-popup/popup-menu-appearance.html [ Failure ]
crbug.com/654554 fast/forms/select/input-select-after-resize.html [ Failure ]
crbug.com/654554 fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html [ Failure ]
crbug.com/654554 fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html [ Failure ]
crbug.com/654554 fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl.html [ Failure ]
crbug.com/654554 fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar.html [ Failure ]
crbug.com/654554 fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html [ Failure ]
crbug.com/654554 fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl.html [ Failure ]
Bug(none) css3/blending/background-blend-mode-overlapping-accelerated-elements.html [ Failure ]
Bug(none) css3/blending/effect-background-blend-mode-stacking.html [ Failure Crash ]
......@@ -1408,7 +1389,6 @@ Bug(none) compositing/squashing/frame-clip-squashed-scrolled.html [ Failure ]
Bug(none) fast/block/positioning/vertical-rl/002.html [ Failure ]
Bug(none) rootscroller/gesture-scroll-document-not-root-scroller.html [ Failure ]
Bug(none) fast/forms/color/color-suggestion-picker-appearance-value-attribute.html [ Crash ]
Bug(none) fast/scroll-snap/snap-scrolls-visual-viewport.html [ Crash ]
Bug(none) paint/invalidation/vertical-align1.html [ Failure ]
Bug(none) paint/invalidation/vertical-align2.html [ Failure ]
......
third_party/blink/renderer/core/exported/web_page_popup_impl.cc
View file @ 0c415398
......@@ -222,7 +222,12 @@ class PagePopupChromeClient final : public EmptyChromeClient {
void AttachRootGraphicsLayer(GraphicsLayer* graphics_layer,
LocalFrame* local_root) override {
popup_->SetRootGraphicsLayer(graphics_layer);
popup_->SetRootLayer(graphics_layer ? graphics_layer->CcLayer() : nullptr);
}
void AttachRootLayer(scoped_refptr<cc::Layer> layer,
LocalFrame* local_root) override {
popup_->SetRootLayer(layer.get());
}
void SetToolTip(LocalFrame&,
......@@ -359,9 +364,8 @@ void WebPagePopupImpl::SetWindowRect(const IntRect& rect_in_screen) {
WidgetClient()->SetWindowRect(rect_in_screen);
}
void WebPagePopupImpl::SetRootGraphicsLayer(GraphicsLayer* layer) {
root_graphics_layer_ = layer;
root_layer_ = layer ? layer->CcLayer() : nullptr;
void WebPagePopupImpl::SetRootLayer(cc::Layer* layer) {
root_layer_ = layer;
is_accelerated_compositing_active_ = !!layer;
if (layer_tree_view_) {
......
third_party/blink/renderer/core/exported/web_page_popup_impl.h
View file @ 0c415398
......@@ -45,7 +45,6 @@ class Layer;
namespace blink {
class CompositorAnimationHost;
class GraphicsLayer;
class Page;
class PagePopupChromeClient;
class PagePopupClient;
......@@ -115,7 +114,7 @@ class CORE_EXPORT WebPagePopupImpl final : public WebPagePopup,
bool InitializePage();
void DestroyPage();
void InitializeLayerTreeView();
void SetRootGraphicsLayer(GraphicsLayer*);
void SetRootLayer(cc::Layer*);
WebRect WindowRectInScreen() const;
......@@ -128,7 +127,6 @@ class CORE_EXPORT WebPagePopupImpl final : public WebPagePopup,
WebLayerTreeView* layer_tree_view_ = nullptr;
scoped_refptr<cc::Layer> root_layer_;
GraphicsLayer* root_graphics_layer_ = nullptr;
std::unique_ptr<CompositorAnimationHost> animation_host_;
bool is_accelerated_compositing_active_ = false;
......
third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
View file @ 0c415398
......@@ -730,6 +730,9 @@ GraphicsLayer* PaintLayerCompositor::RootGraphicsLayer() const {
GraphicsLayer* PaintLayerCompositor::PaintRootGraphicsLayer() const {
if (RuntimeEnabledFeatures::BlinkGenPropertyTreesEnabled()) {
if (layout_view_.GetDocument().GetPage()->GetChromeClient().IsPopup())
return RootGraphicsLayer();
// Start painting at the inner viewport container layer which is an ancestor
// of both the main contents layers and the scrollbar layers.
if (IsMainFrame() && GetVisualViewport().ContainerLayer())
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment