Commit 0d3a759a authored by Nicolas Ouellet-Payeur's avatar Nicolas Ouellet-Payeur Committed by Commit Bot

[BrowserSwitcher] Clean up DISALLOW_COPY_AND_ASSIGN

Change-Id: I2a9f6b033b78d610fcae2f0c880613043a403db9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089991Reviewed-by: default avatarJulian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748247}
parent 63482931
...@@ -149,8 +149,6 @@ class BrowserSwitcherBrowserTest : public InProcessBrowserTest { ...@@ -149,8 +149,6 @@ class BrowserSwitcherBrowserTest : public InProcessBrowserTest {
private: private:
base::ScopedTempDir temp_dir_; base::ScopedTempDir temp_dir_;
policy::MockConfigurationPolicyProvider provider_; policy::MockConfigurationPolicyProvider provider_;
DISALLOW_COPY_AND_ASSIGN(BrowserSwitcherBrowserTest);
}; };
IN_PROC_BROWSER_TEST_F(BrowserSwitcherBrowserTest, RunsExternalCommand) { IN_PROC_BROWSER_TEST_F(BrowserSwitcherBrowserTest, RunsExternalCommand) {
......
...@@ -17,10 +17,11 @@ class BrowserSwitcherPolicyMigrator ...@@ -17,10 +17,11 @@ class BrowserSwitcherPolicyMigrator
BrowserSwitcherPolicyMigrator(); BrowserSwitcherPolicyMigrator();
~BrowserSwitcherPolicyMigrator() override; ~BrowserSwitcherPolicyMigrator() override;
void Migrate(policy::PolicyBundle* bundle) override; BrowserSwitcherPolicyMigrator(const BrowserSwitcherPolicyMigrator&) = delete;
BrowserSwitcherPolicyMigrator& operator=(
const BrowserSwitcherPolicyMigrator&) = delete;
private: void Migrate(policy::PolicyBundle* bundle) override;
DISALLOW_COPY_AND_ASSIGN(BrowserSwitcherPolicyMigrator);
}; };
} // namespace browser_switcher } // namespace browser_switcher
......
...@@ -176,8 +176,6 @@ class BrowserSwitcherServiceTest : public InProcessBrowserTest { ...@@ -176,8 +176,6 @@ class BrowserSwitcherServiceTest : public InProcessBrowserTest {
#if defined(OS_WIN) #if defined(OS_WIN)
base::ScopedTempDir fake_appdata_dir_; base::ScopedTempDir fake_appdata_dir_;
#endif #endif
DISALLOW_COPY_AND_ASSIGN(BrowserSwitcherServiceTest);
}; };
IN_PROC_BROWSER_TEST_F(BrowserSwitcherServiceTest, ExternalSitelistInvalidUrl) { IN_PROC_BROWSER_TEST_F(BrowserSwitcherServiceTest, ExternalSitelistInvalidUrl) {
......
...@@ -24,6 +24,10 @@ class BrowserSwitcherServiceFactory : public BrowserContextKeyedServiceFactory { ...@@ -24,6 +24,10 @@ class BrowserSwitcherServiceFactory : public BrowserContextKeyedServiceFactory {
static BrowserSwitcherService* GetForBrowserContext( static BrowserSwitcherService* GetForBrowserContext(
content::BrowserContext* browser_context); content::BrowserContext* browser_context);
BrowserSwitcherServiceFactory(const BrowserSwitcherServiceFactory&) = delete;
BrowserSwitcherServiceFactory& operator=(
const BrowserSwitcherServiceFactory&) = delete;
private: private:
friend struct base::DefaultSingletonTraits<BrowserSwitcherServiceFactory>; friend struct base::DefaultSingletonTraits<BrowserSwitcherServiceFactory>;
...@@ -35,8 +39,6 @@ class BrowserSwitcherServiceFactory : public BrowserContextKeyedServiceFactory { ...@@ -35,8 +39,6 @@ class BrowserSwitcherServiceFactory : public BrowserContextKeyedServiceFactory {
content::BrowserContext* context) const override; content::BrowserContext* context) const override;
content::BrowserContext* GetBrowserContextToUse( content::BrowserContext* GetBrowserContextToUse(
content::BrowserContext* context) const override; content::BrowserContext* context) const override;
DISALLOW_COPY_AND_ASSIGN(BrowserSwitcherServiceFactory);
}; };
} // namespace browser_switcher } // namespace browser_switcher
......
...@@ -94,6 +94,10 @@ class BrowserSwitcherSitelistImpl : public BrowserSwitcherSitelist { ...@@ -94,6 +94,10 @@ class BrowserSwitcherSitelistImpl : public BrowserSwitcherSitelist {
explicit BrowserSwitcherSitelistImpl(const BrowserSwitcherPrefs* prefs); explicit BrowserSwitcherSitelistImpl(const BrowserSwitcherPrefs* prefs);
~BrowserSwitcherSitelistImpl() override; ~BrowserSwitcherSitelistImpl() override;
BrowserSwitcherSitelistImpl(const BrowserSwitcherSitelistImpl&) = delete;
BrowserSwitcherSitelistImpl& operator=(const BrowserSwitcherSitelistImpl&) =
delete;
// BrowserSwitcherSitelist // BrowserSwitcherSitelist
Decision GetDecision(const GURL& url) const override; Decision GetDecision(const GURL& url) const override;
void SetIeemSitelist(ParsedXml&& sitelist) override; void SetIeemSitelist(ParsedXml&& sitelist) override;
...@@ -112,8 +116,6 @@ class BrowserSwitcherSitelistImpl : public BrowserSwitcherSitelist { ...@@ -112,8 +116,6 @@ class BrowserSwitcherSitelistImpl : public BrowserSwitcherSitelist {
RuleSet external_sitelist_; RuleSet external_sitelist_;
const BrowserSwitcherPrefs* const prefs_; const BrowserSwitcherPrefs* const prefs_;
DISALLOW_COPY_AND_ASSIGN(BrowserSwitcherSitelistImpl);
}; };
} // namespace browser_switcher } // namespace browser_switcher
......
...@@ -21,11 +21,11 @@ class ParsedXml { ...@@ -21,11 +21,11 @@ class ParsedXml {
base::Optional<std::string>&& error); base::Optional<std::string>&& error);
~ParsedXml(); ~ParsedXml();
ParsedXml(const ParsedXml&) = delete;
ParsedXml& operator=(const ParsedXml&) = delete;
std::vector<std::string> rules; std::vector<std::string> rules;
base::Optional<std::string> error; base::Optional<std::string> error;
private:
DISALLOW_COPY_AND_ASSIGN(ParsedXml);
}; };
// Parses the XML contained in |xml|, and calls |callback| with the parsed XML // Parses the XML contained in |xml|, and calls |callback| with the parsed XML
......
...@@ -39,9 +39,6 @@ class IeemSitelistParserTest : public InProcessBrowserTest { ...@@ -39,9 +39,6 @@ class IeemSitelistParserTest : public InProcessBrowserTest {
public: public:
IeemSitelistParserTest() = default; IeemSitelistParserTest() = default;
~IeemSitelistParserTest() override = default; ~IeemSitelistParserTest() override = default;
private:
DISALLOW_COPY_AND_ASSIGN(IeemSitelistParserTest);
}; };
IN_PROC_BROWSER_TEST_F(IeemSitelistParserTest, BadXml) { IN_PROC_BROWSER_TEST_F(IeemSitelistParserTest, BadXml) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment