Commit 0d5005df authored by rbpotter's avatar rbpotter Committed by Commit Bot

Printing: Remove unused NEW_PAGE print job notification

All observers of print job notifications have this notification
commented with don't care, and don't do anything with it. Remove.

Bug: None
Change-Id: Ia669135a311ad1fc3090bb7de974c4a0718a4d0a
Reviewed-on: https://chromium-review.googlesource.com/802755Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521010}
parent 0204c1b2
...@@ -373,7 +373,6 @@ void PrintJob::OnNotifyPrintJobEvent(const JobEventDetails& event_details) { ...@@ -373,7 +373,6 @@ void PrintJob::OnNotifyPrintJobEvent(const JobEventDetails& event_details) {
break; break;
} }
case JobEventDetails::NEW_DOC: case JobEventDetails::NEW_DOC:
case JobEventDetails::NEW_PAGE:
case JobEventDetails::JOB_DONE: case JobEventDetails::JOB_DONE:
case JobEventDetails::ALL_PAGES_REQUESTED: { case JobEventDetails::ALL_PAGES_REQUESTED: {
// Don't care. // Don't care.
......
...@@ -186,9 +186,6 @@ class JobEventDetails : public base::RefCountedThreadSafe<JobEventDetails> { ...@@ -186,9 +186,6 @@ class JobEventDetails : public base::RefCountedThreadSafe<JobEventDetails> {
// A new document started printing. // A new document started printing.
NEW_DOC, NEW_DOC,
// A new page started printing.
NEW_PAGE,
// A page is done printing. // A page is done printing.
PAGE_DONE, PAGE_DONE,
......
...@@ -138,7 +138,6 @@ void PrintJobManager::OnPrintJobEvent( ...@@ -138,7 +138,6 @@ void PrintJobManager::OnPrintJobEvent(
case JobEventDetails::USER_INIT_DONE: case JobEventDetails::USER_INIT_DONE:
case JobEventDetails::USER_INIT_CANCELED: case JobEventDetails::USER_INIT_CANCELED:
case JobEventDetails::DEFAULT_INIT_DONE: case JobEventDetails::DEFAULT_INIT_DONE:
case JobEventDetails::NEW_PAGE:
case JobEventDetails::PAGE_DONE: case JobEventDetails::PAGE_DONE:
case JobEventDetails::DOC_DONE: case JobEventDetails::DOC_DONE:
case JobEventDetails::ALL_PAGES_REQUESTED: { case JobEventDetails::ALL_PAGES_REQUESTED: {
......
...@@ -403,13 +403,6 @@ void PrintJobWorker::SpoolPage(PrintedPage* page) { ...@@ -403,13 +403,6 @@ void PrintJobWorker::SpoolPage(PrintedPage* page) {
DCHECK(task_runner_->RunsTasksInCurrentSequence()); DCHECK(task_runner_->RunsTasksInCurrentSequence());
DCHECK_NE(page_number_, PageNumber::npos()); DCHECK_NE(page_number_, PageNumber::npos());
// Signal everyone that the page is about to be printed.
owner_->PostTask(
FROM_HERE,
base::Bind(&NotificationCallback, base::RetainedRef(owner_),
JobEventDetails::NEW_PAGE, printing_context_->job_id(),
base::RetainedRef(document_), base::RetainedRef(page)));
// Preprocess. // Preprocess.
if (printing_context_->NewPage() != PrintingContext::OK) { if (printing_context_->NewPage() != PrintingContext::OK) {
OnFailure(); OnFailure();
......
...@@ -363,7 +363,6 @@ void PrintViewManagerBase::OnNotifyPrintJobEvent( ...@@ -363,7 +363,6 @@ void PrintViewManagerBase::OnNotifyPrintJobEvent(
break; break;
} }
case JobEventDetails::NEW_DOC: case JobEventDetails::NEW_DOC:
case JobEventDetails::NEW_PAGE:
case JobEventDetails::PAGE_DONE: case JobEventDetails::PAGE_DONE:
case JobEventDetails::DOC_DONE: { case JobEventDetails::DOC_DONE: {
// Don't care about the actual printing process. // Don't care about the actual printing process.
......
...@@ -98,7 +98,6 @@ class PrintingLayoutTest : public PrintingTest<InProcessBrowserTest>, ...@@ -98,7 +98,6 @@ class PrintingLayoutTest : public PrintingTest<InProcessBrowserTest>,
case printing::JobEventDetails::NEW_DOC: case printing::JobEventDetails::NEW_DOC:
case printing::JobEventDetails::USER_INIT_DONE: case printing::JobEventDetails::USER_INIT_DONE:
case printing::JobEventDetails::DEFAULT_INIT_DONE: case printing::JobEventDetails::DEFAULT_INIT_DONE:
case printing::JobEventDetails::NEW_PAGE:
case printing::JobEventDetails::PAGE_DONE: case printing::JobEventDetails::PAGE_DONE:
case printing::JobEventDetails::DOC_DONE: case printing::JobEventDetails::DOC_DONE:
case printing::JobEventDetails::ALL_PAGES_REQUESTED: { case printing::JobEventDetails::ALL_PAGES_REQUESTED: {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment