Commit 0e45f27a authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/prefs.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

TBR=battre@chromium.org
R=battre@chromium.org

Bug: 925652
Change-Id: Ibe9c02c27b69efa50cba51922b498bed6a411d5e
Reviewed-on: https://chromium-review.googlesource.com/c/1438378Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628527}
parent 653c1f4b
...@@ -193,6 +193,6 @@ TEST_P(ChromeCommandLinePrefStoreProxyTest, CommandLine) { ...@@ -193,6 +193,6 @@ TEST_P(ChromeCommandLinePrefStoreProxyTest, CommandLine) {
GetParam().proxy_rules.Matches(proxy_config()->value().proxy_rules())); GetParam().proxy_rules.Matches(proxy_config()->value().proxy_rules()));
} }
INSTANTIATE_TEST_CASE_P(ChromeCommandLinePrefStoreProxyTestInstance, INSTANTIATE_TEST_SUITE_P(ChromeCommandLinePrefStoreProxyTestInstance,
ChromeCommandLinePrefStoreProxyTest, ChromeCommandLinePrefStoreProxyTest,
testing::ValuesIn(kCommandLineTestParams)); testing::ValuesIn(kCommandLineTestParams));
...@@ -158,15 +158,10 @@ bool SupportsRegistryValidation() { ...@@ -158,15 +158,10 @@ bool SupportsRegistryValidation() {
} }
#define PREF_HASH_BROWSER_TEST(fixture, test_name) \ #define PREF_HASH_BROWSER_TEST(fixture, test_name) \
IN_PROC_BROWSER_TEST_P(fixture, PRE_##test_name) { \ IN_PROC_BROWSER_TEST_P(fixture, PRE_##test_name) { SetupPreferences(); } \
SetupPreferences(); \ IN_PROC_BROWSER_TEST_P(fixture, test_name) { VerifyReactionToPrefAttack(); } \
} \ INSTANTIATE_TEST_SUITE_P( \
IN_PROC_BROWSER_TEST_P(fixture, test_name) { \ fixture##Instance, fixture, \
VerifyReactionToPrefAttack(); \
} \
INSTANTIATE_TEST_CASE_P( \
fixture##Instance, \
fixture, \
testing::Values( \ testing::Values( \
chrome_prefs::internals::kSettingsEnforcementGroupNoEnforcement, \ chrome_prefs::internals::kSettingsEnforcementGroupNoEnforcement, \
chrome_prefs::internals::kSettingsEnforcementGroupEnforceAlways, \ chrome_prefs::internals::kSettingsEnforcementGroupEnforceAlways, \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment