Commit 0ea06548 authored by Ramin Halavati's avatar Ramin Halavati Committed by Commit Bot

Update NetErrorDiagnosticDialog for ephemeral Guest profiles.

Net Error diagnostic dialog is updated to be NOT shown for ephemeral
Guest profiles.

This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop|
flag.
Please see go/ephemeral-guest-profiles for more context.

Bug: 1125474
Change-Id: I468af46df1095e642d76945929327c0aa9106e6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470521Reviewed-by: default avatarAsanka Herath <asanka@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817362}
parent 55d8642f
......@@ -89,7 +89,8 @@ bool CanShowNetworkDiagnosticsDialog(content::WebContents* web_contents) {
Profile::FromBrowserContext(web_contents->GetBrowserContext());
// The Windows diagnostic tool logs URLs it's run with, so it shouldn't be
// used with incognito or guest profiles. See https://crbug.com/929141
return !profile->IsOffTheRecord() && !profile->IsGuestSession();
return !profile->IsIncognitoProfile() && !profile->IsGuestSession() &&
!profile->IsEphemeralGuestProfile();
}
void ShowNetworkDiagnosticsDialog(content::WebContents* web_contents,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment