Commit 0ebb7d62 authored by Marc Treib's avatar Marc Treib Committed by Commit Bot

Retire Sync.PeakAnalysis.* histograms

Bug: 1138332
Change-Id: Ib9a8e253545fcaaa34ede661258ed7ae0b53e68b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474873
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: default avatarWeilun Shi <sweilun@chromium.org>
Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818279}
parent 88281bb4
...@@ -146,12 +146,6 @@ std::unique_ptr<HttpPostProviderFactory> CreateHttpBridgeFactory( ...@@ -146,12 +146,6 @@ std::unique_ptr<HttpPostProviderFactory> CreateHttpBridgeFactory(
network_time_update_callback); network_time_update_callback);
} }
void EmitUmaMetricWithEmitTimeMinutes(const std::string& histogram_name) {
base::Time::Exploded now_exploded;
base::Time::Now().UTCExplode(&now_exploded);
base::UmaHistogramExactLinear(histogram_name, now_exploded.minute, 60);
}
std::string GenerateCacheGUID() { std::string GenerateCacheGUID() {
// Generate a GUID with 128 bits of randomness. // Generate a GUID with 128 bits of randomness.
const int kGuidBytes = 128 / 8; const int kGuidBytes = 128 / 8;
...@@ -327,9 +321,6 @@ void ProfileSyncService::Initialize() { ...@@ -327,9 +321,6 @@ void ProfileSyncService::Initialize() {
if (HasDisableReason(DISABLE_REASON_ENTERPRISE_POLICY) || if (HasDisableReason(DISABLE_REASON_ENTERPRISE_POLICY) ||
(HasDisableReason(DISABLE_REASON_NOT_SIGNED_IN) && (HasDisableReason(DISABLE_REASON_NOT_SIGNED_IN) &&
auth_manager_->IsActiveAccountInfoFullyLoaded())) { auth_manager_->IsActiveAccountInfoFullyLoaded())) {
// TODO(crbug/1031162): Remove once traffic investigation is closed.
EmitUmaMetricWithEmitTimeMinutes(
"Sync.PeakAnalysis.StopOnSyncPermanentlyDisabled");
StopImpl(CLEAR_DATA); StopImpl(CLEAR_DATA);
} }
...@@ -387,9 +378,6 @@ void ProfileSyncService::AccountStateChanged() { ...@@ -387,9 +378,6 @@ void ProfileSyncService::AccountStateChanged() {
if (!IsSignedIn()) { if (!IsSignedIn()) {
// The account was signed out, so shut down. // The account was signed out, so shut down.
sync_disabled_by_admin_ = false; sync_disabled_by_admin_ = false;
// TODO(crbug/1031162): Remove once traffic investigation is closed.
EmitUmaMetricWithEmitTimeMinutes(
"Sync.PeakAnalysis.StopAfterAccountStateChanged");
StopImpl(CLEAR_DATA); StopImpl(CLEAR_DATA);
DCHECK(!engine_); DCHECK(!engine_);
} else { } else {
...@@ -425,9 +413,6 @@ void ProfileSyncService::CredentialsChanged() { ...@@ -425,9 +413,6 @@ void ProfileSyncService::CredentialsChanged() {
// then shut down. This happens when the user signs out on the web, i.e. we're // then shut down. This happens when the user signs out on the web, i.e. we're
// in the "Sync paused" state. // in the "Sync paused" state.
if (!IsEngineAllowedToRun()) { if (!IsEngineAllowedToRun()) {
// TODO(crbug/1031162): Remove once traffic investigation is closed.
EmitUmaMetricWithEmitTimeMinutes(
"Sync.PeakAnalysis.StopAfterCredentialsChanged");
// This will notify observers if appropriate. // This will notify observers if appropriate.
StopImpl(KEEP_DATA); StopImpl(KEEP_DATA);
return; return;
...@@ -1485,9 +1470,6 @@ ProfileSyncService::GetTypeStatusMapForDebugging() { ...@@ -1485,9 +1470,6 @@ ProfileSyncService::GetTypeStatusMapForDebugging() {
void ProfileSyncService::OnSyncManagedPrefChange(bool is_sync_managed) { void ProfileSyncService::OnSyncManagedPrefChange(bool is_sync_managed) {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (is_sync_managed) { if (is_sync_managed) {
// TODO(crbug/1031162): Remove once traffic investigation is closed.
EmitUmaMetricWithEmitTimeMinutes(
"Sync.PeakAnalysis.StopOnSyncManagedPrefChange");
StopImpl(CLEAR_DATA); StopImpl(CLEAR_DATA);
} else { } else {
// Sync is no longer disabled by policy. Try starting it up if appropriate. // Sync is no longer disabled by policy. Try starting it up if appropriate.
......
...@@ -616,7 +616,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -616,7 +616,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="Sync.PeakAnalysis.StopAfterAccountStateChanged" units="hits" <histogram name="Sync.PeakAnalysis.StopAfterAccountStateChanged" units="hits"
expires_after="M88"> expires_after="2020-10-15">
<obsolete>
Removed 2020-10.
</obsolete>
<owner>tschumann@chromium.org</owner> <owner>tschumann@chromium.org</owner>
<owner>treib@chromium.org</owner> <owner>treib@chromium.org</owner>
<summary> <summary>
...@@ -630,7 +633,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -630,7 +633,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="Sync.PeakAnalysis.StopAfterCredentialsChanged" units="hits" <histogram name="Sync.PeakAnalysis.StopAfterCredentialsChanged" units="hits"
expires_after="M88"> expires_after="2020-10-15">
<obsolete>
Removed 2020-10.
</obsolete>
<owner>tschumann@chromium.org</owner> <owner>tschumann@chromium.org</owner>
<owner>treib@chromium.org</owner> <owner>treib@chromium.org</owner>
<summary> <summary>
...@@ -643,7 +649,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -643,7 +649,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="Sync.PeakAnalysis.StopOnSyncManagedPrefChange" units="hits" <histogram name="Sync.PeakAnalysis.StopOnSyncManagedPrefChange" units="hits"
expires_after="M88"> expires_after="2020-10-15">
<obsolete>
Removed 2020-10.
</obsolete>
<owner>tschumann@chromium.org</owner> <owner>tschumann@chromium.org</owner>
<owner>treib@chromium.org</owner> <owner>treib@chromium.org</owner>
<summary> <summary>
...@@ -655,7 +664,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -655,7 +664,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="Sync.PeakAnalysis.StopOnSyncPermanentlyDisabled" units="hits" <histogram name="Sync.PeakAnalysis.StopOnSyncPermanentlyDisabled" units="hits"
expires_after="M88"> expires_after="2020-10-15">
<obsolete>
Removed 2020-10.
</obsolete>
<owner>tschumann@chromium.org</owner> <owner>tschumann@chromium.org</owner>
<owner>treib@chromium.org</owner> <owner>treib@chromium.org</owner>
<summary> <summary>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment