Skip to content

GitLab

T
tangled
Commit 0ec9f388 authored by Alec Douglas's avatar Alec Douglas Committed by Commit Bot
Browse files
Options

[Android] Disable remote playback on test video 

The testEnterExitFullscreenWithControlsButton test in
VideoFullscreenOrientationLockTest attempts to click on the
fullscreen button in the video controls panel via hardcoded
offsets from the bounds of the video element.

These offsets assume there are no other buttons placed to the
right of the fullscreen button, but in some circumstances the
cast button will appear and cause the test to fail when the
fullscreen button is not where the test expects it to be.

This commit ensures that the test video never shows the cast
button in the controls panel.

Note: The download button does not need to be disabled because
the media src is detected as being a local file and this causes
the download button to not be shown.

BUG=None

TEST=Every test class that uses video-player.html:
     FullscreenVideoTest, VideoFullscreenOrientationLockTest,
     VideoFullscreenOrientationLockChromeTest, FullscreenActivityTest

Change-Id: Ia14b8e515f0ea6510bfa54fce0fa2f809d4a22b1
Reviewed-on: https://chromium-review.googlesource.com/915017Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536774}
parent 88084756
Show whitespace changes
Inline Side-by-side
Showing with 1 addition and 1 deletion
content/test/data/media/video-player.html
View file @ 0ec9f388
......@@ -5,7 +5,7 @@
<meta name=viewport content='width=device-width initial-scale=1.0'>
</head>
<body>
<video controls id=video src=bear.webm></video>
<video controls id=video src=bear.webm controlsList='noremoteplayback'></video>
<button id='fullscreen'>fullscreen</button>
</body>
<script>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment