Commit 0f7e4682 authored by Mikel Astiz's avatar Mikel Astiz Committed by Commit Bot

Do not instantiate base::FieldTrialList explicitly in tests

The test suite already instantiates a FieldTrialList as per
https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so
it's no longer necessary to do so explicitly in tests.

This patch addresses unit tests under:
/chrome/browser/metrics/perf

This CL was uploaded by git cl split.

R=gmx@chromium.org

Bug: 1018667
Change-Id: I8ad604b8c375a8fbe4f3ba49c1f51940fe2adbb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917504
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: default avatarGabriel Marin <gmx@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715760}
parent b10daed7
...@@ -722,7 +722,7 @@ TEST_F(PerfCollectorTest, JankinessCollectionDurationElapsed) { ...@@ -722,7 +722,7 @@ TEST_F(PerfCollectorTest, JankinessCollectionDurationElapsed) {
class PerfCollectorCollectionParamsTest : public testing::Test { class PerfCollectorCollectionParamsTest : public testing::Test {
public: public:
PerfCollectorCollectionParamsTest() : field_trial_list_(nullptr) {} PerfCollectorCollectionParamsTest() {}
void TearDown() override { void TearDown() override {
variations::testing::ClearAllVariationParams(); variations::testing::ClearAllVariationParams();
...@@ -731,8 +731,6 @@ class PerfCollectorCollectionParamsTest : public testing::Test { ...@@ -731,8 +731,6 @@ class PerfCollectorCollectionParamsTest : public testing::Test {
protected: protected:
content::BrowserTaskEnvironment task_environment_; content::BrowserTaskEnvironment task_environment_;
base::FieldTrialList field_trial_list_;
DISALLOW_COPY_AND_ASSIGN(PerfCollectorCollectionParamsTest); DISALLOW_COPY_AND_ASSIGN(PerfCollectorCollectionParamsTest);
}; };
......
...@@ -118,7 +118,7 @@ class TestProfileProvider : public ProfileProvider { ...@@ -118,7 +118,7 @@ class TestProfileProvider : public ProfileProvider {
// real collections from debugd. // real collections from debugd.
class ProfileProviderRealCollectionTest : public testing::Test { class ProfileProviderRealCollectionTest : public testing::Test {
public: public:
ProfileProviderRealCollectionTest() : field_trial_list_(nullptr) {} ProfileProviderRealCollectionTest() {}
void SetUp() override { void SetUp() override {
chromeos::DBusThreadManager::Initialize(); chromeos::DBusThreadManager::Initialize();
...@@ -167,7 +167,6 @@ class ProfileProviderRealCollectionTest : public testing::Test { ...@@ -167,7 +167,6 @@ class ProfileProviderRealCollectionTest : public testing::Test {
// last. // last.
content::BrowserTaskEnvironment task_environment_; content::BrowserTaskEnvironment task_environment_;
base::FieldTrialList field_trial_list_;
scoped_refptr<base::FieldTrial> field_trial_; scoped_refptr<base::FieldTrial> field_trial_;
std::unique_ptr<TestProfileProvider> profile_provider_; std::unique_ptr<TestProfileProvider> profile_provider_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment