Commit 0fb787c6 authored by Carlos Caballero's avatar Carlos Caballero Committed by Commit Bot

[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in spellcheck

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I4db49f716e36e362b36b059579a4c5a75eb8730c
Reviewed-on: https://chromium-review.googlesource.com/c/1352767Reviewed-by: default avatarSami Kyöstilä <skyostil@chromium.org>
Reviewed-by: default avatarRachel Blum <groby@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#611833}
parent 2f5059a4
......@@ -9,10 +9,10 @@
#include <memory>
#include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/metrics/histogram_samples.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_task_environment.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
......@@ -27,7 +27,7 @@ class SpellcheckHostMetricsTest : public testing::Test {
void RecordWordCountsForTesting() { metrics_->RecordWordCounts(); }
private:
base::MessageLoop loop_;
base::test::ScopedTaskEnvironment task_environment_;
std::unique_ptr<SpellCheckHostMetrics> metrics_;
};
......
......@@ -8,11 +8,11 @@
#include "base/bind.h"
#include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_task_environment.h"
#include "components/spellcheck/common/spellcheck_result.h"
#include "content/public/test/test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
......@@ -36,19 +36,21 @@ class SpellcheckPlatformMacTest: public testing::Test {
private:
void QuitMessageLoop() {
ASSERT_TRUE(message_loop_.IsBoundToCurrentThread());
ASSERT_TRUE(
task_environment_.GetMainThreadTaskRunner()->BelongsToCurrentThread());
base::RunLoop::QuitCurrentWhenIdleDeprecated();
}
void CompletionCallback(const std::vector<SpellCheckResult>& results) {
results_ = results;
callback_finished_ = true;
message_loop_.task_runner()->PostTask(
task_environment_.GetMainThreadTaskRunner()->PostTask(
FROM_HERE, base::BindOnce(&SpellcheckPlatformMacTest::QuitMessageLoop,
base::Unretained(this)));
}
base::MessageLoopForUI message_loop_;
base::test::ScopedTaskEnvironment task_environment_{
base::test::ScopedTaskEnvironment::MainThreadType::UI};
spellcheck_platform::ScopedEnglishLanguageForTest scoped_language_;
};
......
......@@ -12,11 +12,11 @@
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_task_environment.h"
#include "build/build_config.h"
#include "components/spellcheck/common/spellcheck_common.h"
#include "components/spellcheck/common/spellcheck_result.h"
......@@ -127,7 +127,7 @@ class SpellCheckTest : public testing::Test {
private:
spellcheck::EmptyLocalInterfaceProvider embedder_provider_;
std::unique_ptr<SpellCheck> spell_check_;
base::MessageLoop loop_;
base::test::ScopedTaskEnvironment task_environment_;
};
// A fake completion object for verification.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment