Skip to content

GitLab

T
tangled
Commit 0fd5cf35 authored by Ned Nguyen's avatar Ned Nguyen Committed by Commit Bot
Browse files
Options

Remove storage.indexeddb_* benchmarks 

THis benchmark doesn't use our supported harnesses

Bug: 717539
Change-Id: Id90301a5d8632d81edab30d815fb15479b7d2fe2
Reviewed-on: https://chromium-review.googlesource.com/684416Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Reviewed-by: default avatarAnnie Sullivan <sullivan@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#504385}
parent 2824ef26
Expand all Show whitespace changes
Inline Side-by-side
Showing with 1081 additions and 4094 deletions
testing/buildbot/chromium.perf.fyi.json
View file @ 0fd5cf35
......@@ -3784,130 +3784,6 @@
"upload_test_results": false
}
},
{
"args": [
"storage.indexeddb_endure",
"-v",
"--upload-results",
"--browser=release_x64",
"--output-format=chartjson"
],
"isolate_name": "telemetry_perf_tests",
"name": "storage.indexeddb_endure",
"override_compile_targets": [
"telemetry_perf_tests"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "8086:22b1",
"id": "build150-b1",
"os": "Windows-10-10586",
"pool": "Chrome-perf-fyi"
}
],
"expiration": 36000,
"hard_timeout": 10800,
"ignore_task_failure": false,
"io_timeout": 600,
"upload_test_results": false
}
},
{
"args": [
"storage.indexeddb_endure",
"-v",
"--upload-results",
"--browser=reference",
"--output-format=chartjson",
"--max-failures=5",
"--output-trace-tag=_ref"
],
"isolate_name": "telemetry_perf_tests",
"name": "storage.indexeddb_endure.reference",
"override_compile_targets": [
"telemetry_perf_tests"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "8086:22b1",
"id": "build150-b1",
"os": "Windows-10-10586",
"pool": "Chrome-perf-fyi"
}
],
"expiration": 36000,
"hard_timeout": 10800,
"ignore_task_failure": true,
"io_timeout": 600,
"upload_test_results": false
}
},
{
"args": [
"storage.indexeddb_endure_tracing",
"-v",
"--upload-results",
"--browser=release_x64",
"--output-format=chartjson"
],
"isolate_name": "telemetry_perf_tests",
"name": "storage.indexeddb_endure_tracing",
"override_compile_targets": [
"telemetry_perf_tests"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "8086:22b1",
"id": "build153-b1",
"os": "Windows-10-10586",
"pool": "Chrome-perf-fyi"
}
],
"expiration": 36000,
"hard_timeout": 10800,
"ignore_task_failure": false,
"io_timeout": 600,
"upload_test_results": false
}
},
{
"args": [
"storage.indexeddb_endure_tracing",
"-v",
"--upload-results",
"--browser=reference",
"--output-format=chartjson",
"--max-failures=5",
"--output-trace-tag=_ref"
],
"isolate_name": "telemetry_perf_tests",
"name": "storage.indexeddb_endure_tracing.reference",
"override_compile_targets": [
"telemetry_perf_tests"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "8086:22b1",
"id": "build153-b1",
"os": "Windows-10-10586",
"pool": "Chrome-perf-fyi"
}
],
"expiration": 36000,
"hard_timeout": 10800,
"ignore_task_failure": true,
"io_timeout": 600,
"upload_test_results": false
}
},
{
"args": [
"system_health.common_desktop",
......@@ -8177,130 +8053,6 @@
"upload_test_results": false
}
},
{
"args": [
"storage.indexeddb_endure",
"-v",
"--upload-results",
"--browser=release_x64",
"--output-format=chartjson"
],
"isolate_name": "telemetry_perf_tests",
"name": "storage.indexeddb_endure",
"override_compile_targets": [
"telemetry_perf_tests"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "1002:9874",
"id": "build214-b4",
"os": "Windows-10-10586",
"pool": "Chrome-perf-fyi"
}
],
"expiration": 36000,
"hard_timeout": 10800,
"ignore_task_failure": false,
"io_timeout": 600,
"upload_test_results": false
}
},
{
"args": [
"storage.indexeddb_endure",
"-v",
"--upload-results",
"--browser=reference",
"--output-format=chartjson",
"--max-failures=5",
"--output-trace-tag=_ref"
],
"isolate_name": "telemetry_perf_tests",
"name": "storage.indexeddb_endure.reference",
"override_compile_targets": [
"telemetry_perf_tests"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "1002:9874",
"id": "build214-b4",
"os": "Windows-10-10586",
"pool": "Chrome-perf-fyi"
}
],
"expiration": 36000,
"hard_timeout": 10800,
"ignore_task_failure": true,
"io_timeout": 600,
"upload_test_results": false
}
},
{
"args": [
"storage.indexeddb_endure_tracing",
"-v",
"--upload-results",
"--browser=release_x64",
"--output-format=chartjson"
],
"isolate_name": "telemetry_perf_tests",
"name": "storage.indexeddb_endure_tracing",
"override_compile_targets": [
"telemetry_perf_tests"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "1002:9874",
"id": "build217-b4",
"os": "Windows-10-10586",
"pool": "Chrome-perf-fyi"
}
],
"expiration": 36000,
"hard_timeout": 10800,
"ignore_task_failure": false,
"io_timeout": 600,
"upload_test_results": false
}
},
{
"args": [
"storage.indexeddb_endure_tracing",
"-v",
"--upload-results",
"--browser=reference",
"--output-format=chartjson",
"--max-failures=5",
"--output-trace-tag=_ref"
],
"isolate_name": "telemetry_perf_tests",
"name": "storage.indexeddb_endure_tracing.reference",
"override_compile_targets": [
"telemetry_perf_tests"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "1002:9874",
"id": "build217-b4",
"os": "Windows-10-10586",
"pool": "Chrome-perf-fyi"
}
],
"expiration": 36000,
"hard_timeout": 10800,
"ignore_task_failure": true,
"io_timeout": 600,
"upload_test_results": false
}
},
{
"args": [
"system_health.common_desktop",
......
testing/buildbot/chromium.perf.json
View file @ 0fd5cf35
This diff is collapsed.
tools/perf/benchmark.csv
View file @ 0fd5cf35
......@@ -9,7 +9,7 @@ blink_perf.canvas,junov@chromium.org,
blink_perf.css,rune@opera.com,
blink_perf.dom,"jbroman@chromium.org, yukishiino@chromium.org, haraken@chromium.org",
blink_perf.events,hayato@chromium.org,
blink_perf.image_decoder,"cblume@chromium.org",
blink_perf.image_decoder,cblume@chromium.org,
blink_perf.layout,eae@chromium.org,
blink_perf.owp_storage,dmurph@chromium.org,
blink_perf.paint,wangxianzhu@chromium.org,
......@@ -89,8 +89,6 @@ speedometer,"bmeurer@chromium.org, mvstanton@chromium.org",
speedometer2,"verwaest@chromium.org, mvstanton@chromium.org",
start_with_url.cold.startup_pages,pasko@chromium.org,
start_with_url.warm.startup_pages,pasko@chromium.org,
storage.indexeddb_endure,cmumford@chromium.org,
storage.indexeddb_endure_tracing,cmumford@chromium.org,
system_health.common_desktop,"charliea@chromium.org, nednguyen@chromium.org",
system_health.common_mobile,"charliea@chromium.org, nednguyen@chromium.org",
system_health.memory_desktop,perezju@chromium.org,
......
tools/perf/benchmarks/benchmark_smoke_unittest.py
View file @ 0fd5cf35
......@@ -22,7 +22,6 @@ from telemetry.testing import progress_reporter
from py_utils import discover
from benchmarks import battor
from benchmarks import indexeddb_perf
from benchmarks import jetstream
from benchmarks import kraken
from benchmarks import octane
......@@ -88,7 +87,6 @@ def SmokeTestGenerator(benchmark, num_pages=1):
# The list of benchmark modules to be excluded from our smoke tests.
_BLACK_LIST_TEST_MODULES = {
indexeddb_perf, # Always fails on Win7 & Android Tests builder.
octane, # Often fails & take long time to timeout on cq bot.
rasterize_and_record_micro, # Always fails on cq bot.
speedometer, # Takes 101 seconds.
......
tools/perf/benchmarks/indexeddb_perf.py deleted 100644 → 0
View file @ 2824ef26
# Copyright 2013 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Runs Chromium's IndexedDB performance test. These test:
Databases:
create/delete
Keys:
create/delete
Indexes:
create/delete
Data access:
Random read/write
Read cache
Cursors:
Read & random writes
Walking multiple
Seeking.
"""
import json
from core import perf_benchmark
from telemetry import benchmark
from telemetry import story
from telemetry.page import legacy_page_test
from telemetry.value import scalar
from metrics import memory
from metrics import power
import page_sets
from telemetry.timeline import chrome_trace_category_filter
from telemetry.web_perf import timeline_based_measurement
IDB_CATEGORY = 'IndexedDB'
TIMELINE_REQUIRED_CATEGORY = 'blink.console'
class _IndexedDbMeasurement(legacy_page_test.LegacyPageTest):
def __init__(self):
super(_IndexedDbMeasurement, self).__init__()
self._memory_metric = None
self._power_metric = None
def WillStartBrowser(self, platform):
"""Initialize metrics once right before the browser has been launched."""
self._power_metric = power.PowerMetric(platform)
def DidStartBrowser(self, browser):
"""Initialize metrics once right after the browser has been launched."""
self._memory_metric = memory.MemoryMetric(browser)
def DidNavigateToPage(self, page, tab):
self._memory_metric.Start(page, tab)
self._power_metric.Start(page, tab)
def ValidateAndMeasurePage(self, page, tab, results):
tab.WaitForDocumentReadyStateToBeComplete()
tab.WaitForJavaScriptCondition('window.done', timeout=600)
self._power_metric.Stop(page, tab)
self._memory_metric.Stop(page, tab)
self._memory_metric.AddResults(tab, results)
self._power_metric.AddResults(tab, results)
result_dict = json.loads(tab.EvaluateJavaScript(
'JSON.stringify(automation.getResults());'))
total = 0.0
for key in result_dict:
if key == 'OverallTestDuration':
continue
msec = float(result_dict[key])
results.AddValue(scalar.ScalarValue(
results.current_page, key, 'ms', msec, important=False))
total += msec
results.AddValue(scalar.ScalarValue(
results.current_page, 'Total Perf', 'ms', total))
def CustomizeBrowserOptions(self, options):
memory.MemoryMetric.CustomizeBrowserOptions(options)
power.PowerMetric.CustomizeBrowserOptions(options)
@benchmark.Owner(emails=['cmumford@chromium.org'])
class IndexedDbOriginalSectioned(perf_benchmark.PerfBenchmark):
"""Chromium's IndexedDB Performance tests."""
test = _IndexedDbMeasurement
page_set = page_sets.IndexedDBEndurePageSet
@classmethod
def Name(cls):
return 'storage.indexeddb_endure'
def GetExpectations(self):
class StoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # Nothing disabled.
return StoryExpectations()
@benchmark.Owner(emails=['cmumford@chromium.org'])
class IndexedDbTracing(perf_benchmark.PerfBenchmark):
"""IndexedDB Performance tests that use tracing."""
page_set = page_sets.IndexedDBEndurePageSet
def CreateCoreTimelineBasedMeasurementOptions(self):
cat_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter()
cat_filter.AddIncludedCategory(IDB_CATEGORY)
cat_filter.AddIncludedCategory(TIMELINE_REQUIRED_CATEGORY)
return timeline_based_measurement.Options(
overhead_level=cat_filter)
@classmethod
def Name(cls):
return 'storage.indexeddb_endure_tracing'
@classmethod
def ValueCanBeAddedPredicate(cls, value, is_first_result):
return 'idb' in value.name
def GetExpectations(self):
class StoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # Nothing disabled.
return StoryExpectations()
tools/perf/page_sets/indexeddb_endure_page.py deleted 100644 → 0
View file @ 2824ef26
# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
from telemetry.page import page as page_module
from telemetry import story
class IndexedDBEndurePage(page_module.Page):
def __init__(self, subtest, page_set):
super(IndexedDBEndurePage, self).__init__(
url='file://indexeddb_perf/perf_test.html',
page_set=page_set,
name='indexeddb-endure-' + subtest)
self._subtest = subtest
def RunPageInteractions(self, action_runner):
action_runner.ExecuteJavaScript(
'window.testFilter = {{ subtest }};', subtest=self._subtest)
with action_runner.CreateInteraction('Action_Test'):
action_runner.ExecuteJavaScript('window.test();')
action_runner.WaitForJavaScriptCondition(
'window.done', timeout=600)
class IndexedDBEndurePageSet(story.StorySet):
"""The IndexedDB Endurance page set.
This page set exercises various common operations in IndexedDB.
"""
def __init__(self):
super(IndexedDBEndurePageSet, self).__init__()
tests = [
'testCreateAndDeleteDatabases',
'testCreateAndDeleteDatabase',
'testCreateKeysInStores',
'testRandomReadsAndWritesWithoutIndex',
'testRandomReadsAndWritesWithIndex',
'testReadCacheWithoutIndex',
'testReadCacheWithIndex',
'testCreateAndDeleteIndex',
'testWalkingMultipleCursors',
'testCursorSeeksWithoutIndex',
'testCursorSeeksWithIndex'
]
for test in tests:
self.AddStory(IndexedDBEndurePage(test, self))
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment