Commit 10174d09 authored by Meredith Lane's avatar Meredith Lane Committed by Commit Bot

Adds button label to extensions/shortcuts

The button for clearing an entered keyboard shortcut for extensions was
unlabeled, causing it to have no accessible name. This change adds the
Clear string to the grit resources.

BUG=870718

Change-Id: I19699be4b845db27a70d54b91ebdcdb108e71694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599766
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Reviewed-by: default avatarAlice Boxhall <aboxhall@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659784}
parent 03e0a118
......@@ -36,7 +36,8 @@
'$i18nPolymer{shortcutTooManyModifiers}',
'$i18nPolymer{shortcutNeedCharacter}')]]"
value="[[computeText_(capturing_, shortcut, pendingShortcut_)]]">
<cr-icon-button id="clear" slot="suffix" class="icon-cancel no-overlap"
<cr-icon-button id="clear" aria-label="$i18nPolymer{clear}"
slot="suffix" class="icon-cancel no-overlap"
hidden$="[[computeClearHidden_(capturing_, shortcut)]]"
on-click="onClearTap_"></cr-icon-button>
</cr-input>
......
......@@ -118,6 +118,7 @@ content::WebUIDataSource* CreateMdExtensionsSource(Profile* profile,
{"back", IDS_ACCNAME_BACK},
{"cancel", IDS_CANCEL},
{"close", IDS_CLOSE},
{"clear", IDS_CLEAR},
{"confirm", IDS_CONFIRM},
{"controlledSettingPolicy", IDS_CONTROLLED_SETTING_POLICY},
{"done", IDS_DONE},
......
......@@ -238,6 +238,9 @@
<message name="IDS_CLOSE" desc="A generic term for Close on buttons and menus.">
Close
</message>
<message name="IDS_CLEAR" desc="A generic term for Clearing input fields.">
Clear
</message>
<message name="IDS_DONE" desc="A generic term for Done on buttons and menus.">
Done
</message>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment