Commit 10ad7502 authored by Andrey Kosyakov's avatar Andrey Kosyakov Committed by Commit Bot

Disable multiple flaky ExtensionsMenuViewBrowserTest

TBR: rdevlin.cronin@chromium.org
Bug: 1050712
Change-Id: I1d2ce1c3f849f9886d704ea9b2dbac7136041ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047496
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740435}
parent e74c7934
...@@ -279,7 +279,14 @@ class ExtensionsMenuViewBrowserTest : public ExtensionsToolbarBrowserTest { ...@@ -279,7 +279,14 @@ class ExtensionsMenuViewBrowserTest : public ExtensionsToolbarBrowserTest {
std::string ui_test_name_; std::string ui_test_name_;
}; };
IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest, InvokeUi_default) { // TODO(crbug.com/1050712): the test is flaky.
// TODO(crbug.com/1050712): the test is flaky.
#if defined(OS_MACOSX) || defined(OS_LINUX)
#define MAYBE_InvokeUi_default DISABLED_InvokeUi_default
#else
#define MAYBE_InvokeUi_default InvokeUi_default
#endif
IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest, MAYBE_InvokeUi_default) {
LoadTestExtension("extensions/uitest/long_name"); LoadTestExtension("extensions/uitest/long_name");
LoadTestExtension("extensions/uitest/window_open"); LoadTestExtension("extensions/uitest/window_open");
...@@ -356,12 +363,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest, ...@@ -356,12 +363,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest,
ShowAndVerifyUi(); ShowAndVerifyUi();
} }
#if (defined(OS_WIN) && defined(MEMORY_SANITIZER)) // TODO(crbug.com/1050712): the test is flaky.
#define MAYBE_TriggerPopup DISABLED_TriggerPopup IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest, DISABLED_TriggerPopup) {
#else
#define MAYBE_TriggerPopup TriggerPopup
#endif
IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest, TriggerPopup) {
LoadTestExtension("extensions/simple_with_popup"); LoadTestExtension("extensions/simple_with_popup");
ShowUi(""); ShowUi("");
VerifyUi(); VerifyUi();
...@@ -446,7 +449,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest, ...@@ -446,7 +449,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest,
EXPECT_FALSE(ExtensionsMenuView::IsShowing()); EXPECT_FALSE(ExtensionsMenuView::IsShowing());
} }
#if defined(OS_WIN) // TODO(crbug.com/1050712): the test is flaky.
#if defined(OS_WIN) || defined(OS_LINUX)
#define MAYBE_CreatesOneMenuItemPerExtension \ #define MAYBE_CreatesOneMenuItemPerExtension \
DISABLED_CreatesOneMenuItemPerExtension DISABLED_CreatesOneMenuItemPerExtension
#else #else
...@@ -463,8 +467,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest, ...@@ -463,8 +467,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest,
DismissUi(); DismissUi();
} }
// TODO(crbug.com/1050712): the test is flaky.
#if defined(OS_WIN)
#define MAYBE_PinningDisabledInIncognito DISABLED_PinningDisabledInIncognito
#else
#define MAYBE_PinningDisabledInIncognito PinningDisabledInIncognito
#endif
IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest, IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewBrowserTest,
PinningDisabledInIncognito) { MAYBE_PinningDisabledInIncognito) {
LoadTestExtension("extensions/uitest/window_open", true); LoadTestExtension("extensions/uitest/window_open", true);
SetUpIncognitoBrowser(); SetUpIncognitoBrowser();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment