Rename HttpssvcMetrics::in_progress_ to already_recorded_ for clarity.

This CL also deletes an unnecessary std::vector local variable from
HttpssvcExperimentDomainCache::IsControl.

Bug: 1052476
Change-Id: Ic160ad593028be880246861f328ec287723958b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295322Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787900}

net/dns/httpssvc_metrics.cc

@@ -59,7 +59,6 @@ bool HttpssvcExperimentDomainCache::IsExperimental(base::StringPiece domain) {
 }
 
 bool HttpssvcExperimentDomainCache::IsControl(base::StringPiece domain) {
-  std::vector<base::StringPiece> control_domains;
   if (!base::FeatureList::IsEnabled(features::kDnsHttpssvc))
     return false;
   if (features::kDnsHttpssvcControlDomainWildcard.Get())
@@ -153,8 +152,8 @@ void HttpssvcMetrics::RecordIntegrityMetrics() {
   DCHECK(base::FeatureList::IsEnabled(features::kDnsHttpssvc));
   DCHECK(features::kDnsHttpssvcUseIntegrity.Get());
 
-  DCHECK(in_progress_);
-  in_progress_ = false;
+  DCHECK(!already_recorded_);
+  already_recorded_ = true;
 
   // We really have no metrics to record without |integrity_resolve_time_| and
   // |non_integrity_resolve_times_|. If this HttpssvcMetrics is in an

net/dns/httpssvc_metrics.h

@@ -93,10 +93,10 @@ class NET_EXPORT_PRIVATE HttpssvcMetrics {
 
   void set_doh_provider_id(base::Optional<std::string> doh_provider_id);
 
+  const bool expect_intact_;
   // RecordIntegrityMetrics() will do nothing when |disqualified_| is true.
   bool disqualified_ = false;
-  const bool expect_intact_;
-  bool in_progress_ = true;
+  bool already_recorded_ = false;
   base::Optional<std::string> doh_provider_id_;
   base::Optional<enum HttpssvcDnsRcode> rcode_integrity_;
   size_t num_integrity_records_ = 0;