Commit 1322c499 authored by Yulun Wu's avatar Yulun Wu Committed by Commit Bot

Restore classic app list folder view colors.

This CL addresses changes in:

https://chromium-review.googlesource.com/c/chromium/src/+/2417241

Bug: 1134800
Change-Id: I9ce7301dcdfe9940a10f3920e2901a051ff0f0e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462556Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Reviewed-by: default avatarYulun Wu <yulunwu@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815686}
parent 08c4fd64
...@@ -105,19 +105,22 @@ SkColor AppListColorProviderImpl::GetSearchBoxIconColor() const { ...@@ -105,19 +105,22 @@ SkColor AppListColorProviderImpl::GetSearchBoxIconColor() const {
AshColorProvider::ContentLayerType::kButtonIconColor); AshColorProvider::ContentLayerType::kButtonIconColor);
} }
SkColor AppListColorProviderImpl::GetFolderBackgroundColor() const { SkColor AppListColorProviderImpl::GetFolderBackgroundColor(
return ash_color_provider_->GetBaseLayerColor( SkColor default_color) const {
AshColorProvider::BaseLayerType::kTransparent80); return DeprecatedGetBaseLayerColor(
AshColorProvider::BaseLayerType::kTransparent80, default_color);
} }
SkColor AppListColorProviderImpl::GetFolderTitleTextColor() const { SkColor AppListColorProviderImpl::GetFolderTitleTextColor(
return ash_color_provider_->GetContentLayerColor( SkColor default_color) const {
AshColorProvider::ContentLayerType::kTextColorPrimary); return DeprecatedGetContentLayerColor(
AshColorProvider::ContentLayerType::kTextColorPrimary, default_color);
} }
SkColor AppListColorProviderImpl::GetFolderHintTextColor() const { SkColor AppListColorProviderImpl::GetFolderHintTextColor() const {
return ash_color_provider_->GetContentLayerColor( return DeprecatedGetContentLayerColor(
AshColorProvider::ContentLayerType::kTextColorSecondary); AshColorProvider::ContentLayerType::kTextColorSecondary,
gfx::kGoogleGrey600);
} }
SkColor AppListColorProviderImpl::GetFolderNameBackgroundColor( SkColor AppListColorProviderImpl::GetFolderNameBackgroundColor(
......
...@@ -32,8 +32,8 @@ class AppListColorProviderImpl : public AppListColorProvider { ...@@ -32,8 +32,8 @@ class AppListColorProviderImpl : public AppListColorProvider {
SkColor GetPageSwitcherInkDropHighlightColor() const override; SkColor GetPageSwitcherInkDropHighlightColor() const override;
SkColor GetSearchBoxIconColor() const override; SkColor GetSearchBoxIconColor() const override;
SkColor GetSearchBoxCardBackgroundColor() const override; SkColor GetSearchBoxCardBackgroundColor() const override;
SkColor GetFolderBackgroundColor() const override; SkColor GetFolderBackgroundColor(SkColor default_color) const override;
SkColor GetFolderTitleTextColor() const override; SkColor GetFolderTitleTextColor(SkColor default_color) const override;
SkColor GetFolderHintTextColor() const override; SkColor GetFolderHintTextColor() const override;
SkColor GetFolderNameBackgroundColor(bool active) const override; SkColor GetFolderNameBackgroundColor(bool active) const override;
SkColor GetFolderNameBorderColor(bool active) const override; SkColor GetFolderNameBorderColor(bool active) const override;
......
...@@ -56,7 +56,8 @@ SkColor TestAppListColorProvider::GetAppListItemTextColor() const { ...@@ -56,7 +56,8 @@ SkColor TestAppListColorProvider::GetAppListItemTextColor() const {
return gfx::kGoogleGrey200; return gfx::kGoogleGrey200;
} }
SkColor TestAppListColorProvider::GetFolderBackgroundColor() const { SkColor TestAppListColorProvider::GetFolderBackgroundColor(
SkColor default_color) const {
return gfx::kGoogleGrey900; return gfx::kGoogleGrey900;
} }
...@@ -76,7 +77,8 @@ SkColor TestAppListColorProvider::GetSearchBoxIconColor() const { ...@@ -76,7 +77,8 @@ SkColor TestAppListColorProvider::GetSearchBoxIconColor() const {
return gfx::kGoogleGrey200; return gfx::kGoogleGrey200;
} }
SkColor TestAppListColorProvider::GetFolderTitleTextColor() const { SkColor TestAppListColorProvider::GetFolderTitleTextColor(
SkColor default_color) const {
return gfx::kGoogleGrey200; return gfx::kGoogleGrey200;
} }
......
...@@ -32,8 +32,8 @@ class TestAppListColorProvider : public AppListColorProvider { ...@@ -32,8 +32,8 @@ class TestAppListColorProvider : public AppListColorProvider {
SkColor GetPageSwitcherInkDropHighlightColor() const override; SkColor GetPageSwitcherInkDropHighlightColor() const override;
SkColor GetSearchBoxIconColor() const override; SkColor GetSearchBoxIconColor() const override;
SkColor GetSearchBoxCardBackgroundColor() const override; SkColor GetSearchBoxCardBackgroundColor() const override;
SkColor GetFolderBackgroundColor() const override; SkColor GetFolderBackgroundColor(SkColor default_color) const override;
SkColor GetFolderTitleTextColor() const override; SkColor GetFolderTitleTextColor(SkColor default_color) const override;
SkColor GetFolderHintTextColor() const override; SkColor GetFolderHintTextColor() const override;
SkColor GetFolderNameBackgroundColor(bool active) const override; SkColor GetFolderNameBackgroundColor(bool active) const override;
SkColor GetFolderNameBorderColor(bool active) const override; SkColor GetFolderNameBorderColor(bool active) const override;
......
...@@ -92,7 +92,8 @@ class BackgroundAnimation : public AppListFolderView::Animation, ...@@ -92,7 +92,8 @@ class BackgroundAnimation : public AppListFolderView::Animation,
: folder_view_->folder_item_icon_bounds(); : folder_view_->folder_item_icon_bounds();
to_rect -= background_view_->bounds().OffsetFromOrigin(); to_rect -= background_view_->bounds().OffsetFromOrigin();
const SkColor background_color = const SkColor background_color =
AppListColorProvider::Get()->GetFolderBackgroundColor(); AppListColorProvider::Get()->GetFolderBackgroundColor(
folder_view_->GetAppListConfig().folder_background_color());
const SkColor from_color = const SkColor from_color =
show_ ? folder_view_->GetAppListConfig().folder_bubble_color() show_ ? folder_view_->GetAppListConfig().folder_bubble_color()
: background_color; : background_color;
...@@ -150,10 +151,14 @@ class FolderItemTitleAnimation : public AppListFolderView::Animation, ...@@ -150,10 +151,14 @@ class FolderItemTitleAnimation : public AppListFolderView::Animation,
animation_(this), animation_(this),
folder_view_(folder_view) { folder_view_(folder_view) {
// Calculate the source and target states. // Calculate the source and target states.
from_color_ = show_ ? AppListColorProvider::Get()->GetFolderTitleTextColor() from_color_ = show_
? AppListColorProvider::Get()->GetFolderTitleTextColor(
folder_view_->GetAppListConfig().grid_title_color())
: SK_ColorTRANSPARENT; : SK_ColorTRANSPARENT;
to_color_ = show_ ? SK_ColorTRANSPARENT to_color_ = show_
: AppListColorProvider::Get()->GetFolderTitleTextColor(); ? SK_ColorTRANSPARENT
: AppListColorProvider::Get()->GetFolderTitleTextColor(
folder_view_->GetAppListConfig().grid_title_color());
animation_.SetTweenType(gfx::Tween::FAST_OUT_SLOW_IN); animation_.SetTweenType(gfx::Tween::FAST_OUT_SLOW_IN);
animation_.SetSlideDuration( animation_.SetSlideDuration(
...@@ -827,7 +832,8 @@ void AppListFolderView::HideViewImmediately() { ...@@ -827,7 +832,8 @@ void AppListFolderView::HideViewImmediately() {
if (activated_folder_item_view) { if (activated_folder_item_view) {
activated_folder_item_view->SetIconVisible(true); activated_folder_item_view->SetIconVisible(true);
activated_folder_item_view->title()->SetEnabledColor( activated_folder_item_view->title()->SetEnabledColor(
AppListColorProvider::Get()->GetFolderTitleTextColor()); AppListColorProvider::Get()->GetFolderTitleTextColor(
GetAppListConfig().grid_title_color()));
activated_folder_item_view->title()->SetVisible(true); activated_folder_item_view->title()->SetVisible(true);
} }
} }
......
...@@ -61,7 +61,8 @@ class FolderHeaderView::FolderNameView : public views::Textfield, ...@@ -61,7 +61,8 @@ class FolderHeaderView::FolderNameView : public views::Textfield,
color_provider->GetFolderNameBackgroundColor(is_active), color_provider->GetFolderNameBackgroundColor(is_active),
AppListConfig::instance().folder_name_border_radius())); AppListConfig::instance().folder_name_border_radius()));
const SkColor text_color = color_provider->GetFolderTitleTextColor(); const SkColor text_color =
color_provider->GetFolderTitleTextColor(gfx::kGoogleGrey700);
SetTextColor(text_color); SetTextColor(text_color);
SetSelectionTextColor(text_color); SetSelectionTextColor(text_color);
SetSelectionBackgroundColor(color_provider->GetFolderNameSelectionColor()); SetSelectionBackgroundColor(color_provider->GetFolderNameSelectionColor());
......
...@@ -31,8 +31,8 @@ class ASH_PUBLIC_EXPORT AppListColorProvider { ...@@ -31,8 +31,8 @@ class ASH_PUBLIC_EXPORT AppListColorProvider {
virtual SkColor GetPageSwitcherInkDropHighlightColor() const = 0; virtual SkColor GetPageSwitcherInkDropHighlightColor() const = 0;
virtual SkColor GetSearchBoxIconColor() const = 0; virtual SkColor GetSearchBoxIconColor() const = 0;
virtual SkColor GetSearchBoxCardBackgroundColor() const = 0; virtual SkColor GetSearchBoxCardBackgroundColor() const = 0;
virtual SkColor GetFolderBackgroundColor() const = 0; virtual SkColor GetFolderBackgroundColor(SkColor default_color) const = 0;
virtual SkColor GetFolderTitleTextColor() const = 0; virtual SkColor GetFolderTitleTextColor(SkColor default_color) const = 0;
virtual SkColor GetFolderHintTextColor() const = 0; virtual SkColor GetFolderHintTextColor() const = 0;
virtual SkColor GetFolderNameBackgroundColor(bool active) const = 0; virtual SkColor GetFolderNameBackgroundColor(bool active) const = 0;
virtual SkColor GetFolderNameBorderColor(bool active) const = 0; virtual SkColor GetFolderNameBorderColor(bool active) const = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment