[DevTools] Remove --disable-internal-devtools-binary-protocol.

This is the minimal change. I'll simplify the code in a separate
change, and remove the test suites in a separate change.

The update to dom-getBoxModel-expected.txt is because the flag
won't have an effect any more.

Bug: 954618

Change-Id: Ib017e78c56fa19178b2d914bfcad96f9a2187596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575999Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652681}

chrome/browser/devtools/chrome_devtools_session.cc

@@ -11,7 +11,6 @@
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/browser/devtools_agent_host_client.h"
 #include "content/public/browser/devtools_manager_delegate.h"
-#include "content/public/common/content_switches.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/devtools/protocol/window_manager_handler.h"
@@ -54,9 +53,7 @@ void ChromeDevToolsSession::sendProtocolResponse(
 }
 
 static bool EnableInternalDevToolsBinaryProtocol() {
-  static bool disabled = base::CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kDisableInternalDevToolsBinaryProtocol);
-  return !disabled;
+  return true;
 }
 
 void ChromeDevToolsSession::HandleCommand(

content/browser/devtools/devtools_session_encoding.cc

@@ -9,7 +9,6 @@
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
-#include "content/public/common/content_switches.h"
 #include "third_party/inspector_protocol/encoding/encoding.h"
 
 using inspector_protocol_encoding::span;
@@ -37,9 +36,7 @@ class ContentShellPlatform : public Platform {
 };
 }  // namespace
 bool EnableInternalDevToolsBinaryProtocol() {
-  static bool disabled = base::CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kDisableInternalDevToolsBinaryProtocol);
-  return !disabled;
+  return true;
 }
 
 // TODO(johannes): Push error handling to client code after devtools_session.cc

content/public/common/content_switches.cc

@@ -216,13 +216,6 @@ const char kDisableNotifications[]          = "disable-notifications";
 // the use of persistent gpu memory buffers.
 const char kDisablePartialRaster[] = "disable-partial-raster";
 
-// By default, in devtools_session.cc, we use CBOR for protocol messages
-// except for sending JSON to clients that request it.
-// This switch undoes this default. We plan to remove it after after transition
-// to binary is sufficiently complete (2019-04-15).
-const char kDisableInternalDevToolsBinaryProtocol[] =
-    "disable-internal-devtools-binary-protocol";
-
 // Enable partial raster in the renderer.
 const char kEnablePartialRaster[] = "enable-partial-raster";
 

content/public/common/content_switches.h

@@ -73,7 +73,6 @@ CONTENT_EXPORT extern const char kDisableNewContentRenderingTimeout[];
 CONTENT_EXPORT extern const char kDisableNotifications[];
 CONTENT_EXPORT extern const char kDisableOriginTrialControlledBlinkFeatures[];
 CONTENT_EXPORT extern const char kDisablePartialRaster[];
-CONTENT_EXPORT extern const char kDisableInternalDevToolsBinaryProtocol[];
 CONTENT_EXPORT extern const char kEnablePartialRaster[];
 extern const char kDisablePepper3d[];
 CONTENT_EXPORT extern const char kDisablePepper3DImageChromium[];

headless/lib/browser/protocol/headless_devtools_session.cc

@@ -7,7 +7,6 @@
 #include "base/command_line.h"
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/browser/devtools_agent_host_client.h"
-#include "content/public/common/content_switches.h"
 #include "headless/lib/browser/protocol/browser_handler.h"
 #include "headless/lib/browser/protocol/headless_handler.h"
 #include "headless/lib/browser/protocol/page_handler.h"
@@ -16,9 +15,7 @@
 namespace headless {
 namespace protocol {
 static bool EnableInternalDevToolsBinaryProtocol() {
-  static bool disabled = base::CommandLine::ForCurrentProcess()->HasSwitch(
-      ::switches::kDisableInternalDevToolsBinaryProtocol);
-  return !disabled;
+  return true;
 }
 
 HeadlessDevToolsSession::HeadlessDevToolsSession(