Commit 1404113b authored by John Rummell's avatar John Rummell Committed by Commit Bot

Log warnings when WVTestLicenseServerConfig is unusable

On some bots getting the server command line is failing, so change
DVLOGs to WARNINGS so that the actual error can be seen.

Bug: 976083
Test: compiles
Change-Id: I654d3857806b48015ecda97431d8e264a8924ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946929
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: default avatarXiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720633}
parent c2a98130
...@@ -48,7 +48,7 @@ bool WVTestLicenseServerConfig::GetServerCommandLine( ...@@ -48,7 +48,7 @@ bool WVTestLicenseServerConfig::GetServerCommandLine(
base::FilePath license_server_path; base::FilePath license_server_path;
GetLicenseServerPath(&license_server_path); GetLicenseServerPath(&license_server_path);
if (!base::PathExists(license_server_path)) { if (!base::PathExists(license_server_path)) {
DVLOG(0) << "Missing license server file at " LOG(WARNING) << "Missing license server file at "
<< license_server_path.value(); << license_server_path.value();
return false; return false;
} }
...@@ -60,7 +60,8 @@ bool WVTestLicenseServerConfig::GetServerCommandLine( ...@@ -60,7 +60,8 @@ bool WVTestLicenseServerConfig::GetServerCommandLine(
if (!base::PathExists(config_path.Append(kKeysFileName)) || if (!base::PathExists(config_path.Append(kKeysFileName)) ||
!base::PathExists(config_path.Append(kPoliciesFileName)) || !base::PathExists(config_path.Append(kPoliciesFileName)) ||
!base::PathExists(config_path.Append(kProfilesFileName))) { !base::PathExists(config_path.Append(kProfilesFileName))) {
DVLOG(0) << "Missing license server configuration files."; LOG(WARNING) << "Missing license server configuration files at "
<< config_path;
return false; return false;
} }
...@@ -98,7 +99,7 @@ WVTestLicenseServerConfig::GetServerEnvironment() { ...@@ -98,7 +99,7 @@ WVTestLicenseServerConfig::GetServerEnvironment() {
// Add the Python protocol buffers files directory to Python path. // Add the Python protocol buffers files directory to Python path.
base::FilePath pyproto_dir; base::FilePath pyproto_dir;
if (!GetPyProtoPath(&pyproto_dir)) { if (!GetPyProtoPath(&pyproto_dir)) {
DVLOG(0) << "Cannot find pyproto directory required by license server."; LOG(WARNING) << "Cannot find pyproto directory required by license server.";
return base::nullopt; return base::nullopt;
} }
...@@ -122,8 +123,8 @@ bool WVTestLicenseServerConfig::SelectServerPort() { ...@@ -122,8 +123,8 @@ bool WVTestLicenseServerConfig::SelectServerPort() {
return true; return true;
} }
} }
DVLOG(0) << "Could not find an open port in the range of " << kMinPort << LOG(WARNING) << "Could not find an open port in the range of " << kMinPort
" to " << kMinPort + kPortRangeSize; << " to " << kMinPort + kPortRangeSize;
return false; return false;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment