Commit 14276294 authored by John Budorick's avatar John Budorick Committed by Commit Bot

Use instance IDs for non-android_deps cipd deps.

Updating android_deps is a bit more involved & will be in a
separate CL.

Bug: 877304
Change-Id: Ic297766125ffd638b8190033736d301ce650a86e
Reviewed-on: https://chromium-review.googlesource.com/c/1350879
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: default avataragrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612297}
parent 2fedc715
......@@ -192,31 +192,31 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling android_sdk_build-tools_version
# and whatever else without interference from each other.
'android_sdk_build-tools_version': 'version:27.0.3-cr0',
'android_sdk_build-tools_version': '125a2abaa0393cd68a2414ec79e514d5d0a80b58',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling android_sdk_emulator_version
# and whatever else without interference from each other.
'android_sdk_emulator_version': 'version:27.1.12-cr0',
'android_sdk_emulator_version': '731059df93885359487fd9d6085bc7804a23f9c8',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling android_sdk_extras_version
# and whatever else without interference from each other.
'android_sdk_extras_version': 'version:47.0.0-cr0',
'android_sdk_extras_version': '2f33032ef348e2ff37d90d53563f4cb030a879bf',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling android_sdk_platform-tools_version
# and whatever else without interference from each other.
'android_sdk_platform-tools_version': 'version:27.0.1-cr0',
'android_sdk_platform-tools_version': '7f31093ac2fc930abadb3bf65fc0a663a22cd6dc',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling android_sdk_platforms_version
# and whatever else without interference from each other.
'android_sdk_platforms_version': 'version:android-27-cr0',
'android_sdk_platforms_version': '6a79b931523181e147ddfc7db318bf0b2e34edb5',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling android_sdk_sources_version
# and whatever else without interference from each other.
'android_sdk_sources_version': 'version:android-27-cr1',
'android_sdk_sources_version': '8d8bd74d8f062449b8c44a663cc38a33ddf96752',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling android_sdk_tools_version
# and whatever else without interference from each other.
'android_sdk_tools_version': 'version:26.1.1-cr9',
'android_sdk_tools_version': '1a659d51804abb9461cd19aeffc2102e47a15a25',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling feed
# and whatever else without interference from each other.
......@@ -263,7 +263,7 @@ deps = {
'packages': [
{
'package': 'chromium/android_webview/tools/cts_archive',
'version': 'version:1.1',
'version': '3JR1LoM5xpNK_jcnwciobRW9H8TM3SUxuSGQJBjt6AUC',
},
],
'condition': 'checkout_android',
......@@ -288,7 +288,7 @@ deps = {
'packages': [
{
'package': 'chromium/chrome/test/data/safe_browsing/dmg',
'version': 'version:20180816.2',
'version': 'a543ae3f0b3e67dd5a1c75f63317231a1d242912',
},
],
'condition': 'checkout_mac',
......@@ -325,7 +325,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/firebase_ios',
'version': 'version:5.8.0',
'version': 'b44315eefb889f856af131d487cc61b46a78777b',
},
],
'condition': 'checkout_ios',
......@@ -442,7 +442,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/accessibility-test-framework',
'version': 'version:2.1-cr0',
'version': 'b5ec1e56e58e56bc1a0c77d43111c37f9b512c8a',
},
],
'condition': 'checkout_android',
......@@ -463,7 +463,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/android_support_test_runner',
'version': 'version:0.5-cr0',
'version': '96d4bf848cd210fdcbca6bcc8c1b4b39cbd93141',
},
],
'condition': 'checkout_android',
......@@ -474,7 +474,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/android_system_sdk',
'version': 'version:28-dp3-cr0',
'version': '0c0a94a9326c045c8aabb7fc418ea9c849b782f2',
},
],
'condition': 'checkout_android',
......@@ -490,7 +490,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/android_build_tools/aapt2',
'version': 'version:3.3.0-beta01-5013011-cr0',
'version': 'XPNW95mgY7ws_5lNsyjlq7DowuughMNsRIGuGCT0basC',
},
],
'condition': 'checkout_android',
......@@ -512,7 +512,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/android_tools_bundletool',
'version': 'version:0.7.1-cr0',
'version': 'bSpsD5lu4IO9FkDBSyjPNU2yibLq89K25354Hx8Ak-QC',
},
],
'condition': 'checkout_android',
......@@ -579,7 +579,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/apk-patch-size-estimator',
'version': 'version:0.2-cr0',
'version': 'b603e99dca9b90d6a99519c232cd811878283b08',
},
],
'condition': 'checkout_android',
......@@ -595,7 +595,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/bazel',
'version': 'version:0.10.0',
'version': '1794576f65a721eb0af320a0701e48d31f1b2415',
},
],
'condition': 'checkout_android',
......@@ -617,7 +617,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/bouncycastle',
'version': 'version:1.46-cr0',
'version': 'c078e87552ba26e776566fdaf0f22cd8712743d0',
},
],
'condition': 'checkout_android',
......@@ -631,7 +631,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/byte_buddy',
'version': 'version:1.8.8-cr0',
'version': 'c9b53316603fc2d997c899c7ca1707f809b918cd',
},
],
'condition': 'checkout_android',
......@@ -698,7 +698,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/espresso',
'version': 'version:2.2.1-cr0',
'version': 'c92dcfc4e894555a0b3c309f2b7939640eb1fee4',
},
],
'condition': 'checkout_android',
......@@ -749,7 +749,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/google-truth',
'version': 'version:0.40',
'version': '4d6fe892fc3150ab40ef1d619baf0038859eb6d2',
},
],
'condition': 'checkout_android',
......@@ -774,7 +774,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/gson',
'version': 'version:2.8.0-cr0',
'version': '681931c9778045903a0ed59856ce2dd8dd7bf7ca',
},
],
'condition': 'checkout_android',
......@@ -785,7 +785,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/guava',
'version': 'version:23.0-cr0',
'version': 'a6fba501f3a0de88b9be1daa2052632de5b96a46',
},
],
'condition': 'checkout_android',
......@@ -806,7 +806,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/hamcrest',
'version': 'version:1.3-cr0',
'version': '37eccfc658fe79695d6abb6dd497463c4372032f',
},
],
'condition': 'checkout_android',
......@@ -823,7 +823,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/icu4j',
'version': 'version:53.1-cr0',
'version': 'e87e5bed2b4935913ee26a3ebd0b723ee2344354',
},
],
'condition': 'checkout_android',
......@@ -834,7 +834,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/intellij',
'version': 'version:12.0-cr0',
'version': '77c2721b024b36ee073402c08e6d8428c0295336',
},
],
'condition': 'checkout_android',
......@@ -974,7 +974,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/objenesis',
'version': 'version:2.4-cr0',
'version': '9e367f55e5a65781ee77bfcbaa88fb82b30e75c0',
},
],
'condition': 'checkout_android',
......@@ -991,7 +991,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/ow2_asm',
'version': 'version:5.0.1-cr0',
'version': '0dcaea8bd839b3f2eb8415c327b40e8e398a373e',
},
],
'condition': 'checkout_android',
......@@ -1125,7 +1125,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/sqlite4java',
'version': 'version:0.282-cr0',
'version': '889660698187baa7c8b0d79f7bf58563125fbd66',
},
],
'condition': 'checkout_android',
......@@ -1182,7 +1182,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/xstream',
'version': 'version:1.4.8-cr0',
'version': '4278b1b78b86ab7a1a29e64d5aec9a47a9aab0fe',
},
],
'condition': 'checkout_android',
......@@ -1210,7 +1210,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/android_deps/libs/com_google_android_play_core_verification',
'version': 'version:1.3.7-cr0',
'version': 'CMX_sCQTYt-Pj3-xFaCMPNGK3TjVMfToP2glkNm1a4AC',
},
],
'condition': 'checkout_android',
......
......@@ -121,11 +121,6 @@ For more information about the package definition spec, see [the code][3].
To actually create your package, you'll need:
- the cipd.yaml file (described above)
- a package version. For third-party packages, this should typically include
the version of the third-party package itself. If you want to support future
modifications within a given version of a third-party package (e.g., if you
want to make chromium-specific changes), it's best to include a suffix with
a numerical component.
- [permission](#permissions-in-cipd).
Once you have those, you can create your package like so:
......@@ -134,9 +129,17 @@ Once you have those, you can create your package like so:
# Assuming that the third-party dependency in question is at version 1.2.3
# and this is the first chromium revision of that version.
$ cipd auth-login # One-time auth.
$ cipd create --pkg-def cipd.yaml -tag version:1.2.3-cr0
$ cipd create --pkg-def cipd.yaml
...
[P114210 10:14:17.215 client.go:931 I] cipd: instance
chromium/third_party/sample_cipd_dep:TX7HeY1_1JLwFVx-xiETOpT8YK4W5CbyO26SpmaMA0IC was
successfully registered
```
Take note of the instance ID printed in the log
(`TX7HeY1_1JLwFVx-xiETOpT8YK4W5CbyO26SpmaMA0IC` in the example above).
You'll be adding it to DEPS momentarily.
### 5. Add your CIPD package to DEPS
You can add your package to DEPS by adding an entry of the following form to
......@@ -154,7 +157,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/sample_cipd_dep',
'version': 'version:1.2.3-cr0',
'version': 'TX7HeY1_1JLwFVx-xiETOpT8YK4W5CbyO26SpmaMA0IC',
},
],
......@@ -168,8 +171,8 @@ deps = {
```
This will result in CIPD package `chromium/third_party/sample_cipd_dep` at
`version:1.2.3-cr0` being installed in `src/third_party/sample_cipd_dep`
(relative to the gclient root directory).
`TX7HeY1_1JLwFVx-xiETOpT8YK4W5CbyO26SpmaMA0IC` being installed in
`src/third_party/sample_cipd_dep` (relative to the gclient root directory).
## Updating a CIPD dependency
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment