Commit 14d55aaa authored by Joon Ahn's avatar Joon Ahn Committed by Commit Bot

Diagnostics: Add nullability modifiers for elements in test_utils

All non-primitive types need explicit non/null modifier as per style guide.

chrome/test/data/webui/chromeos/diagnostics:closure_compile

Bug: 1125150
Test: autoninja
Change-Id: Ic1a6ff8c08cb1fb8770158c3154eb0bec8879712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530191
Auto-Submit: Joon Ahn <joonbug@chromium.org>
Reviewed-by: default avatarZentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826372}
parent 22914292
...@@ -7,7 +7,7 @@ import {assertTrue} from '../../chai_assert.js'; ...@@ -7,7 +7,7 @@ import {assertTrue} from '../../chai_assert.js';
/** /**
* Helper function for getting an array of data-point elements from a * Helper function for getting an array of data-point elements from a
* diagnostics card. * diagnostics card.
* @param {T} element * @param {?T} element
* @template T * @template T
* @return {!NodeList<!DataPointElement>} * @return {!NodeList<!DataPointElement>}
*/ */
...@@ -19,7 +19,7 @@ export function getDataPointElements(element) { ...@@ -19,7 +19,7 @@ export function getDataPointElements(element) {
/** /**
* Helper function for getting a percent-bar-chart element from a * Helper function for getting a percent-bar-chart element from a
* diagnostics card. * diagnostics card.
* @param {T} element * @param {?T} element
* @template T * @template T
* @return {!PercentBarChartElement} * @return {!PercentBarChartElement}
*/ */
...@@ -31,7 +31,7 @@ export function getPercentBarChartElement(element) { ...@@ -31,7 +31,7 @@ export function getPercentBarChartElement(element) {
/** /**
* Helper function for getting a realtime-cpu-chart element from a * Helper function for getting a realtime-cpu-chart element from a
* diagnostics card. * diagnostics card.
* @param {CpuCardElement} element * @param {?CpuCardElement} element
* @return {!RealtimeCpuChartElement} * @return {!RealtimeCpuChartElement}
*/ */
export function getRealtimeCpuChartElement(element) { export function getRealtimeCpuChartElement(element) {
...@@ -42,7 +42,7 @@ export function getRealtimeCpuChartElement(element) { ...@@ -42,7 +42,7 @@ export function getRealtimeCpuChartElement(element) {
/** /**
* Helper function for getting an array of routine-result-entry * Helper function for getting an array of routine-result-entry
* element from a routine-result-list. * element from a routine-result-list.
* @param {RoutineResultListElement} element * @param {?RoutineResultListElement} element
* @return {!NodeList<!RoutineResultEntryElement>} * @return {!NodeList<!RoutineResultEntryElement>}
*/ */
export function getResultEntries(element) { export function getResultEntries(element) {
...@@ -52,7 +52,7 @@ export function getResultEntries(element) { ...@@ -52,7 +52,7 @@ export function getResultEntries(element) {
/** /**
* Helper function for getting the routine-result-list from an element. * Helper function for getting the routine-result-list from an element.
* @param {RoutineSectionElement} element * @param {?RoutineSectionElement} element
* @return {!RoutineResultListElement} * @return {!RoutineResultListElement}
*/ */
export function getResultList(element) { export function getResultList(element) {
...@@ -63,7 +63,7 @@ export function getResultList(element) { ...@@ -63,7 +63,7 @@ export function getResultList(element) {
/** /**
* Helper function for getting an array of routine-result-entry * Helper function for getting an array of routine-result-entry
* element from a routine-section. * element from a routine-section.
* @param {RoutineSectionElement} element * @param {?RoutineSectionElement} element
* @return {!NodeList<!RoutineResultEntryElement>} * @return {!NodeList<!RoutineResultEntryElement>}
*/ */
export function getResultEntriesFromSection(element) { export function getResultEntriesFromSection(element) {
...@@ -72,7 +72,7 @@ export function getResultEntriesFromSection(element) { ...@@ -72,7 +72,7 @@ export function getResultEntriesFromSection(element) {
/** /**
* Helper function for getting the Run Tests button from a routine-section. * Helper function for getting the Run Tests button from a routine-section.
* @param {RoutineSectionElement} element * @param {?RoutineSectionElement} element
* @return {!CrButtonElement} * @return {!CrButtonElement}
*/ */
export function getRunTestsButtonFromSection(element) { export function getRunTestsButtonFromSection(element) {
...@@ -97,7 +97,7 @@ export function getToggleTestReportButtonFromSection(element) { ...@@ -97,7 +97,7 @@ export function getToggleTestReportButtonFromSection(element) {
/** /**
* Helper function to check if a substring exists in an element. * Helper function to check if a substring exists in an element.
* @param {Element} element * @param {?Element} element
* @param {string} text substring to check * @param {string} text substring to check
* @throws {Error} * @throws {Error}
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment