Commit 15124163 authored by James Cook's avatar James Cook Committed by Chromium LUCI CQ

Fix spelling of "hostname" in a few comments

The variations code uses "osname" as a URL parameter. While grepping for
"osname" I noticed we misspell "hostname" in a few places.

Bug: none
Change-Id: I2b058f2732e90b90d57a222907ff39dd77cf365b
Tbr: xiyuan@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585653Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835892}
parent d369a3f7
...@@ -484,7 +484,7 @@ void SmbService::MountInternal( ...@@ -484,7 +484,7 @@ void SmbService::MountInternal(
mount_id, std::move(callback))); mount_id, std::move(callback)));
} else { } else {
// If using kerberos, the hostname should not be resolved since kerberos // If using kerberos, the hostname should not be resolved since kerberos
// service tickets are keyed on hosname. // service tickets are keyed on hostname.
const SmbUrl url = info.use_kerberos() const SmbUrl url = info.use_kerberos()
? info.share_url() ? info.share_url()
: share_finder_->GetResolvedUrl(info.share_url()); : share_finder_->GetResolvedUrl(info.share_url());
...@@ -678,7 +678,7 @@ void SmbService::Remount(const ProvidedFileSystemInfo& file_system_info) { ...@@ -678,7 +678,7 @@ void SmbService::Remount(const ProvidedFileSystemInfo& file_system_info) {
} }
// If using kerberos, the hostname should not be resolved since kerberos // If using kerberos, the hostname should not be resolved since kerberos
// service tickets are keyed on hosname. // service tickets are keyed on hostname.
const SmbUrl resolved_url = is_kerberos_chromad const SmbUrl resolved_url = is_kerberos_chromad
? parsed_url ? parsed_url
: share_finder_->GetResolvedUrl(parsed_url); : share_finder_->GetResolvedUrl(parsed_url);
......
...@@ -214,7 +214,7 @@ TEST_F(SOCKS5ClientSocketTest, ConnectAndDisconnectTwice) { ...@@ -214,7 +214,7 @@ TEST_F(SOCKS5ClientSocketTest, ConnectAndDisconnectTwice) {
} }
} }
// Test that we fail trying to connect to a hosname longer than 255 bytes. // Test that we fail trying to connect to a hostname longer than 255 bytes.
TEST_F(SOCKS5ClientSocketTest, LargeHostNameFails) { TEST_F(SOCKS5ClientSocketTest, LargeHostNameFails) {
// Create a string of length 256, where each character is 'x'. // Create a string of length 256, where each character is 'x'.
std::string large_host_name; std::string large_host_name;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment