Commit 154b3508 authored by Jun Mukai's avatar Jun Mukai Committed by Commit Bot

Exclude perf tests in interactive_ui_tests in sanitizer builds

A lot of performance tests have been disabled but most of the
cases they're flaky only on asan/lsan/msan bots, and that is
natural because the performance is worse due to additional
sanitizing. Also those performance numbers won't be helpful
anyways.

Considering that, it would be better to simply exclude them from
sanitizer builds.

This CL does not re-enable disabled tests. I'll do that after
this CL is landed, one-by-one, so that we can handle the
problem separately in case of unexpected failures on dbg/rel
bots.

Bug: 1057868
Test: build interactive_ui_tests on asan flag
Change-Id: I69c22ab575d95d2ba500556ae81ab603fde44b2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099328Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749747}
parent 4abb120b
...@@ -5913,6 +5913,13 @@ if (!is_android) { ...@@ -5913,6 +5913,13 @@ if (!is_android) {
} }
} }
# tab_spinner_interactive_uitest.cc is a UIPerformanceTest, so excluding
# it. See below for the details.
if (using_sanitizer) {
sources -=
[ "../browser/ui/views/tabs/tab_spinner_interactive_uitest.cc" ]
}
if (is_chromeos) { if (is_chromeos) {
deps += [ deps += [
"//chrome/browser/media/router:test_support", "//chrome/browser/media/router:test_support",
...@@ -5924,8 +5931,15 @@ if (!is_android) { ...@@ -5924,8 +5931,15 @@ if (!is_android) {
# Use only the _chromeos version on Ash / Chrome OS. # Use only the _chromeos version on Ash / Chrome OS.
"../browser/ui/views/test/view_event_test_platform_part_default.cc", "../browser/ui/views/test/view_event_test_platform_part_default.cc",
] ]
sources +=
[ "../browser/ui/app_list/app_list_client_interactive_uitest.cc" ]
# UIPerformanceTests in interactive_ui_tests. Since flakiness is usually
# observed on those tests when sanitizer is enabled, and considering that
# their performance numbers won't be useful anyways, these tests are
# excluded from builds with sanitizer. See https://crbug.com/1057868.
if (!using_sanitizer) {
sources += [ sources += [
"../browser/ui/app_list/app_list_client_interactive_uitest.cc",
"../browser/ui/ash/drag_to_overview_interactive_uitest.cc", "../browser/ui/ash/drag_to_overview_interactive_uitest.cc",
"../browser/ui/ash/homescreen_interactive_uitest.cc", "../browser/ui/ash/homescreen_interactive_uitest.cc",
"../browser/ui/ash/launcher_animations_interactive_uitest.cc", "../browser/ui/ash/launcher_animations_interactive_uitest.cc",
...@@ -5942,6 +5956,7 @@ if (!is_android) { ...@@ -5942,6 +5956,7 @@ if (!is_android) {
"base/perf/drag_event_generator.cc", "base/perf/drag_event_generator.cc",
"base/perf/drag_event_generator.h", "base/perf/drag_event_generator.h",
] ]
}
} else { # ! is_chromeos } else { # ! is_chromeos
# Non-ChromeOS notifications tests. # Non-ChromeOS notifications tests.
sources += [ sources += [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment