Remove dead AssistantManagerDelegate settings method

These methods (IsSettingSupported and SupportsModifySettings) are not
called by Libassistant anymore, and are removed from the API altogether
in 1.50

Bug: b/170170824
Change-Id: Ic9bbbfd06661ba8cfe128850bd07a6dc5a395508
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451401Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815630}

chromeos/services/assistant/assistant_manager_service_impl.cc

@@ -989,17 +989,6 @@ void AssistantManagerServiceImpl::OnGetDeviceSettings(
       /*is_user_initiated=*/true);
 }
 
-bool AssistantManagerServiceImpl::IsSettingSupported(
-    const std::string& setting_id) {
-  DVLOG(2) << "IsSettingSupported=" << setting_id;
-
-  return settings_delegate_->IsSettingSupported(setting_id);
-}
-
-bool AssistantManagerServiceImpl::SupportsModifySettings() {
-  return true;
-}
-
 void AssistantManagerServiceImpl::OnNotificationRemoved(
     const std::string& grouping_key) {
   ENSURE_MAIN_THREAD(&AssistantManagerServiceImpl::OnNotificationRemoved,

chromeos/services/assistant/assistant_manager_service_impl.h

@@ -196,8 +196,6 @@ class COMPONENT_EXPORT(ASSISTANT_SERVICE) AssistantManagerServiceImpl
   void OnRespondingStarted(bool is_error_response) override;
 
   // AssistantManagerDelegate overrides:
-  bool IsSettingSupported(const std::string& setting_id) override;
-  bool SupportsModifySettings() override;
   void OnConversationTurnStartedInternal(
       const assistant_client::ConversationTurnMetadata& metadata) override;
   void OnNotificationRemoved(const std::string& grouping_key) override;
@@ -279,9 +277,9 @@ class COMPONENT_EXPORT(ASSISTANT_SERVICE) AssistantManagerServiceImpl
   // Record the response type for each query. Note that query on device
   // actions (e.g. turn on Bluetooth, turn on WiFi) will cause duplicate
   // record because it interacts with server twice on on the same query.
-  // The first round interaction checks IsSettingSupported with no responses
-  // sent back and ends normally (will be recorded as kUnspecified), and
-  // settings modification proto along with any text/voice responses would
+  // The first round interaction checks if a setting is supported with no
+  // responses sent back and ends normally (will be recorded as kUnspecified),
+  // and settings modification proto along with any text/voice responses would
   // be sent back in the second round (recorded as kDeviceAction).
   void RecordQueryResponseTypeUMA();