Commit 1681b460 authored by Takayoshi Kochi's avatar Takayoshi Kochi Committed by Commit Bot

Convert media elements to use UA shadow instead of V0 shadow

Found some media control elements accidentally using V0 shadow
root instead of User-Agent shadow root, and this fixes the cases.

To avoid further misuses, I'll rename the API in the following CL
https://chromium-review.googlesource.com/c/chromium/src/+/1057047

Bug: 787717, 776656
Change-Id: I45274ccb399ae57ea7207402323f49efd2188d9c
Reviewed-on: https://chromium-review.googlesource.com/1056939Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558266}
parent 6b3cf241
......@@ -32,7 +32,7 @@ MediaControlLoadingPanelElement::MediaControlLoadingPanelElement(
MediaControlsImpl& media_controls)
: MediaControlDivElement(media_controls, kMediaControlsPanel) {
SetShadowPseudoId(AtomicString("-internal-media-controls-loading-panel"));
CreateShadowRootInternal();
CreateUserAgentShadowRoot();
// The loading panel should always start hidden.
SetIsWanted(false);
......
......@@ -18,7 +18,7 @@ MediaControlScrubbingMessageElement::MediaControlScrubbingMessageElement(
MediaControlsImpl& media_controls)
: MediaControlDivElement(media_controls, kMediaScrubbingMessage) {
SetShadowPseudoId(AtomicString("-internal-media-controls-scrubbing-message"));
CreateShadowRootInternal();
CreateUserAgentShadowRoot();
SetIsWanted(false);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment