Commit 17cf41e7 authored by Luum Habtemariam's avatar Luum Habtemariam Committed by Commit Bot

IppParserService: ConvertIppToMojo usage fix

ipp_converter::ConvertIppToMojo does not take ownership of the passed in
ipp_t*; this change reflects that.

Bug: None
Test: unitests still pass
Change-Id: I19cbdb084175a57ab533cd63099d54acae624c2b
Reviewed-on: https://chromium-review.googlesource.com/c/1493206Reviewed-by: default avatarSean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636478}
parent b8e35b24
......@@ -127,7 +127,7 @@ mojom::IppMessagePtr ExtractIppMessage(base::StringPiece request) {
return nullptr;
}
return ipp_converter::ConvertIppToMojo(ipp.release());
return ipp_converter::ConvertIppToMojo(ipp.get());
}
// Parse IPP request's |ipp_data|
......
......@@ -85,6 +85,7 @@ base::Optional<std::vector<uint8_t>> BuildIppRequest(
ipp_t* ipp);
// Mojom converter for ipp_t objects, return nullptr on failure.
// Note: This function does not take ownership of |ipp|.
chrome::mojom::IppMessagePtr ConvertIppToMojo(ipp_t* ipp);
// Common converters for working with arbitrary byte buffers.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment