Always surface RenderTest failures locally

Causes all RenderTest comparison failures to surface when running the
tests locally, even if the particular hardware/software combination is
not supported. This is so that developers using unsupported
configurations, e.g. an Android emulator, to develop locally can still
see pixel output.

Bug: 1057851
Change-Id: I3bc40966746a011eb4fd4a2eb3b16a76e5d8ea70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170549
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763512}

build/android/pylib/local/device/local_device_instrumentation_test_run.py

@@ -982,6 +982,14 @@ class LocalDeviceInstrumentationTestRun(
           fail_on_unsupported = fail_on_unsupported.lower() == 'true'
         if device.build_version_sdk not in RENDER_TEST_MODEL_SDK_CONFIGS.get(
             device.product_model, []) and not fail_on_unsupported:
+          if self._test_instance.skia_gold_properties.local_pixel_tests:
+            _AppendToLog(
+                results, 'Gold comparison for %s failed, but model %s with SDK '
+                '%d is not a supported configuration. This failure would be '
+                'ignored on the bots, but failing since tests are being run '
+                'locally.' % (render_name, device.product_model,
+                              device.build_version_sdk))
+          else:
             _AppendToLog(
                 results, 'Gold comparison for %s failed, but model %s with SDK '
                 '%d is not a supported configuration, so ignoring failure.' %