Skip to content

GitLab

T
tangled
Commit 189eeaf5 authored by dpapad's avatar dpapad Committed by Commit Bot
Browse files
Options

Show a favicon in chrome://version for Desktop (only). 

Using chrome://theme/current-channel-logo, which does not work on
iOS and Android.

Bug: 820678
Change-Id: I5b0028bd75dd52c55359264b7d72e8cd04d4be9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588799
Commit-Queue: Peter Boström <pbos@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807474}
parent 3f350b5e
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 1 deletion
chrome/browser/ui/views/tabs/tab_icon.cc
View file @ 189eeaf5
...@@ -40,8 +40,9 @@ constexpr int kLoadingAnimationStrokeWidthDp = 2; ...@@ -40,8 +40,9 @@ constexpr int kLoadingAnimationStrokeWidthDp = 2;
// the browser theme. // the browser theme.
bool ShouldThemifyFaviconForUrl(const GURL& url) { bool ShouldThemifyFaviconForUrl(const GURL& url) {
return url.SchemeIs(content::kChromeUIScheme) && return url.SchemeIs(content::kChromeUIScheme) &&
url.host_piece() != chrome::kChromeUIAppLauncherPageHost &&
url.host_piece() != chrome::kChromeUIHelpHost && url.host_piece() != chrome::kChromeUIHelpHost &&
url.host_piece() != chrome::kChromeUIAppLauncherPageHost; url.host_piece() != chrome::kChromeUIVersionHost;
} }
bool NetworkStateIsAnimated(TabNetworkState network_state) { bool NetworkStateIsAnimated(TabNetworkState network_state) {
......
components/version_ui/resources/about_version.html
View file @ 189eeaf5
...@@ -8,6 +8,10 @@ about:version template page ...@@ -8,6 +8,10 @@ about:version template page
<head> <head>
<meta charset="utf-8"> <meta charset="utf-8">
<title>$i18n{title}</title> <title>$i18n{title}</title>
<if expr="not is_android and not is_ios">
<link rel="icon" type="image/png" sizes="32x32"
href="chrome://theme/current-channel-logo">
</if>
<link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">
<if expr="is_android or is_ios"> <if expr="is_android or is_ios">
<meta name="viewport" content="width=device-width"> <meta name="viewport" content="width=device-width">
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment