Commit 1904cb6d authored by Joe Downing's avatar Joe Downing Committed by Commit Bot

Adding CustomAction to delete debug.log on uninstall

I noticed that we leave a crufty debug.log file in the directory
when our MSI is removed.  I added a custom action to clean it
up so we don't leave cruft on the system during upgrades or
uninstalls.

Change-Id: Ibbb13dcdcbc60dc95c3db4996d1243637354afe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033625Reviewed-by: default avatarJamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737478}
parent 8a512a25
...@@ -766,6 +766,13 @@ ...@@ -766,6 +766,13 @@
Impersonate="no" Impersonate="no"
Return="ignore"/> Return="ignore"/>
<CustomAction Id="remove_debug_log"
Directory="binaries"
ExeCommand='cmd /c del /f debug.log'
Execute="deferred"
Impersonate="no"
Return="ignore"/>
<InstallExecuteSequence> <InstallExecuteSequence>
<!-- Set REINSTALL=all and REINSTALLMODE=amus if the user reruns the <!-- Set REINSTALL=all and REINSTALLMODE=amus if the user reruns the
MSI, which will force reinstalling all files and services. --> MSI, which will force reinstalling all files and services. -->
...@@ -793,6 +800,9 @@ ...@@ -793,6 +800,9 @@
See http://msdn.microsoft.com/en-us/library/aa371197.aspx. --> See http://msdn.microsoft.com/en-us/library/aa371197.aspx. -->
<RemoveExistingProducts After="InstallInitialize" /> <RemoveExistingProducts After="InstallInitialize" />
<Custom Action="remove_debug_log" Before="RemoveFiles">
Installed AND (NOT MAINTENANCE)
</Custom>
<Custom Action="remove_symbolic_link" Before="RemoveFiles"> <Custom Action="remove_symbolic_link" Before="RemoveFiles">
Installed AND (NOT MAINTENANCE) Installed AND (NOT MAINTENANCE)
</Custom> </Custom>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment