Commit 1916748e authored by shenghuazhang's avatar shenghuazhang Committed by Commit bot

[Android] Refactor AwSettingsTest to replace deprecated package org.apache.http

BUG=488194

Review-Url: https://codereview.chromium.org/2627113002
Cr-Commit-Position: refs/heads/master@{#443120}
parent e70e635a
...@@ -20,9 +20,6 @@ import android.webkit.ValueCallback; ...@@ -20,9 +20,6 @@ import android.webkit.ValueCallback;
import android.webkit.WebSettings; import android.webkit.WebSettings;
import android.webkit.WebSettings.LayoutAlgorithm; import android.webkit.WebSettings.LayoutAlgorithm;
import org.apache.http.Header;
import org.apache.http.HttpRequest;
import org.chromium.android_webview.AwContents; import org.chromium.android_webview.AwContents;
import org.chromium.android_webview.AwSettings; import org.chromium.android_webview.AwSettings;
import org.chromium.android_webview.AwWebResourceResponse; import org.chromium.android_webview.AwWebResourceResponse;
...@@ -41,6 +38,7 @@ import org.chromium.content.browser.test.util.DOMUtils; ...@@ -41,6 +38,7 @@ import org.chromium.content.browser.test.util.DOMUtils;
import org.chromium.content.browser.test.util.HistoryUtils; import org.chromium.content.browser.test.util.HistoryUtils;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer; import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
import org.chromium.content_public.browser.WebContents; import org.chromium.content_public.browser.WebContents;
import org.chromium.net.test.EmbeddedTestServer;
import org.chromium.net.test.util.TestWebServer; import org.chromium.net.test.util.TestWebServer;
import org.chromium.ui.display.DisplayAndroid; import org.chromium.ui.display.DisplayAndroid;
...@@ -1751,31 +1749,28 @@ public class AwSettingsTest extends AwTestBase { ...@@ -1751,31 +1749,28 @@ public class AwSettingsTest extends AwTestBase {
final TestAwContentsClient contentClient = new TestAwContentsClient(); final TestAwContentsClient contentClient = new TestAwContentsClient();
final AwTestContainerView testContainerView = final AwTestContainerView testContainerView =
createAwTestContainerViewOnMainSync(contentClient); createAwTestContainerViewOnMainSync(contentClient);
AwContents awContents = testContainerView.getAwContents();
AwSettings settings = getAwSettingsOnUiThread(awContents);
final String customUserAgentString = final String customUserAgentString =
"testUserAgentWithTestServerUserAgent"; "testUserAgentWithTestServerUserAgent";
AwContents awContents = testContainerView.getAwContents();
AwSettings settings = getAwSettingsOnUiThread(awContents);
EmbeddedTestServer testServer =
EmbeddedTestServer.createAndStartServer(getInstrumentation().getContext());
String fileName = null; enableJavaScriptOnUiThread(awContents);
TestWebServer webServer = TestWebServer.start();
try {
final String httpPath = "/testUserAgentWithTestServer.html";
final String url = webServer.setResponse(httpPath, "foo", null);
try {
// Create url with echoheader echoing the User-Agent header in the the html body.
String url = testServer.getURL("/echoheader?User-Agent");
settings.setUserAgentString(customUserAgentString); settings.setUserAgentString(customUserAgentString);
loadUrlSync(awContents, loadUrlSync(awContents,
contentClient.getOnPageFinishedHelper(), contentClient.getOnPageFinishedHelper(),
url); url);
String userAgent = maybeStripDoubleQuotes(JSUtils.executeJavaScriptAndWaitForResult(
assertEquals(1, webServer.getRequestCount(httpPath)); this, awContents, contentClient.getOnEvaluateJavaScriptResultHelper(),
HttpRequest request = webServer.getLastRequest(httpPath); "document.body.textContent"));
Header[] matchingHeaders = request.getHeaders("User-Agent"); assertEquals(customUserAgentString, userAgent);
assertEquals(1, matchingHeaders.length);
Header header = matchingHeaders[0];
assertEquals(customUserAgentString, header.getValue());
} finally { } finally {
webServer.shutdown(); testServer.stopAndDestroyServer();
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment