Make HistoryQuickProvider::DeleteMatch also delete the underlying URL from the History Database.

BUG=383272

Review URL: https://codereview.chromium.org/329073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276777 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/autocomplete/history_provider.cc

@@ -26,10 +26,13 @@ void HistoryProvider::DeleteMatch(const AutocompleteMatch& match) {
   HistoryService* const history_service =
       HistoryServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
 
-  // Delete the match from the history DB.
+  // Delete the underlying URL along with all its visits from the history DB.
+  // The resulting HISTORY_URLS_DELETED notification will also cause all caches
+  // and indices to drop any data they might have stored pertaining to the URL.
   DCHECK(history_service);
   DCHECK(match.destination_url.is_valid());
   history_service->DeleteURL(match.destination_url);
+
   DeleteMatchFromMatches(match);
 }
 

chrome/browser/autocomplete/history_quick_provider.cc

@@ -89,14 +89,6 @@ void HistoryQuickProvider::Start(const AutocompleteInput& input,
   }
 }
 
-void HistoryQuickProvider::DeleteMatch(const AutocompleteMatch& match) {
-  DCHECK(match.deletable);
-  DCHECK(match.destination_url.is_valid());
-  // Delete the match from the InMemoryURLIndex.
-  GetIndex()->DeleteURL(match.destination_url);
-  DeleteMatchFromMatches(match);
-}
-
 HistoryQuickProvider::~HistoryQuickProvider() {}
 
 void HistoryQuickProvider::DoAutocomplete() {

chrome/browser/autocomplete/history_quick_provider.h

@@ -35,8 +35,6 @@ class HistoryQuickProvider : public HistoryProvider {
   virtual void Start(const AutocompleteInput& input,
                      bool minimal_changes) OVERRIDE;
 
-  virtual void DeleteMatch(const AutocompleteMatch& match) OVERRIDE;
-
   // Disable this provider. For unit testing purposes only. This is required
   // because this provider is closely associated with the HistoryURLProvider
   // and in order to properly test the latter the HistoryQuickProvider must

chrome/browser/autocomplete/history_quick_provider_unittest.cc

@@ -21,6 +21,7 @@
 #include "chrome/browser/autocomplete/autocomplete_result.h"
 #include "chrome/browser/autocomplete/history_url_provider.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
+#include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/history/history_backend.h"
 #include "chrome/browser/history/history_database.h"
 #include "chrome/browser/history/history_service.h"
@@ -35,7 +36,9 @@
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/bookmarks/test/bookmark_test_helpers.h"
+#include "content/public/browser/notification_service.h"
 #include "content/public/test/test_browser_thread.h"
+#include "content/public/test/test_utils.h"
 #include "sql/transaction.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ -146,6 +149,10 @@ class HistoryQuickProviderTest : public testing::Test,
                base::string16 expected_fill_into_edit,
                base::string16 autocompletion);
 
+  history::HistoryBackend* history_backend() {
+    return history_service_->history_backend_;
+  }
+
   base::MessageLoopForUI message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread file_thread_;
@@ -173,8 +180,7 @@ void HistoryQuickProviderTest::SetUp() {
   TemplateURLServiceFactory::GetInstance()->SetTestingFactoryAndUse(
       profile_.get(), &HistoryQuickProviderTest::CreateTemplateURLService);
   FillData();
-  provider_->GetIndex()->RebuildFromHistory(
-      history_service_->history_backend_->db());
+  provider_->GetIndex()->RebuildFromHistory(history_backend()->db());
 }
 
 void HistoryQuickProviderTest::TearDown() {
@@ -190,7 +196,7 @@ void HistoryQuickProviderTest::GetTestData(size_t* data_count,
 }
 
 void HistoryQuickProviderTest::FillData() {
-  sql::Connection& db(history_service_->history_backend_->db()->GetDB());
+  sql::Connection& db(history_backend()->db()->GetDB());
   ASSERT_TRUE(db.is_open());
 
   size_t data_count = 0;
@@ -507,15 +513,31 @@ TEST_F(HistoryQuickProviderTest, Spans) {
 }
 
 TEST_F(HistoryQuickProviderTest, DeleteMatch) {
+  GURL test_url("http://slashdot.org/favorite_page.html");
   std::vector<std::string> expected_urls;
-  expected_urls.push_back("http://slashdot.org/favorite_page.html");
+  expected_urls.push_back(test_url.spec());
   // Fill up ac_matches_; we don't really care about the test yet.
   RunTest(ASCIIToUTF16("slashdot"), false, expected_urls, true,
           ASCIIToUTF16("slashdot.org/favorite_page.html"),
                   ASCIIToUTF16(".org/favorite_page.html"));
   EXPECT_EQ(1U, ac_matches_.size());
+  EXPECT_TRUE(history_backend()->GetURL(test_url, NULL));
   provider_->DeleteMatch(ac_matches_[0]);
-  // Verify it's no longer an indexed visit.
+
+  // Check that the underlying URL is deleted from the history DB (this implies
+  // that all visits are gone as well). Also verify that a deletion notification
+  // is sent, in response to which the secondary data stores (InMemoryDatabase,
+  // InMemoryURLIndex) will drop any data they might have pertaining to the URL.
+  // To ensure that the deletion has been propagated everywhere before we start
+  // verifying post-deletion states, first wait until we see the notification.
+  content::WindowedNotificationObserver observer(
+        chrome::NOTIFICATION_HISTORY_URLS_DELETED,
+        content::NotificationService::AllSources());
+  observer.Wait();
+  EXPECT_FALSE(history_backend()->GetURL(test_url, NULL));
+
+  // Just to be on the safe side, explicitly verify that we have deleted enough
+  // data so that we will not be serving the same result again.
   expected_urls.clear();
   RunTest(ASCIIToUTF16("slashdot"), false, expected_urls, true,
           ASCIIToUTF16("NONE EXPECTED"), base::string16());