Commit 1a239f05 authored by Peter Kasting's avatar Peter Kasting Committed by Commit Bot

Adjust common theme tree colors.

Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=1024091#c1

Bug: 1024091
Change-Id: Idb0cab8c8b446d65a74568e9ccd8de6182349782
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913587
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714913}
parent 5dea43f2
...@@ -135,17 +135,12 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id, ...@@ -135,17 +135,12 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id,
// Tree // Tree
case NativeTheme::kColorId_TreeBackground: case NativeTheme::kColorId_TreeBackground:
return gfx::kGoogleGrey800; return color_utils::AlphaBlend(SK_ColorWHITE, gfx::kGoogleGrey900,
0.04f);
case NativeTheme::kColorId_TreeText: case NativeTheme::kColorId_TreeText:
return SkColorSetA(SK_ColorWHITE, 0xDD); case NativeTheme::kColorId_TreeSelectedText:
case NativeTheme::kColorId_TreeSelectionBackgroundFocused: case NativeTheme::kColorId_TreeSelectedTextUnfocused:
case NativeTheme::kColorId_TreeSelectionBackgroundUnfocused: return gfx::kGoogleGrey200;
return color_utils::AlphaBlend(
SK_ColorWHITE,
GetAuraColor(
NativeTheme::kColorId_LabelTextSelectionBackgroundFocused,
base_theme, color_scheme),
SkAlpha{0xDD});
// Material spinner/throbber // Material spinner/throbber
case NativeTheme::kColorId_ThrobberSpinningColor: case NativeTheme::kColorId_ThrobberSpinningColor:
...@@ -207,7 +202,7 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id, ...@@ -207,7 +202,7 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id,
// MenuItem // MenuItem
case NativeTheme::kColorId_TouchableMenuItemLabelColor: case NativeTheme::kColorId_TouchableMenuItemLabelColor:
return gfx::kGoogleGrey900; return kPrimaryTextColor;
case NativeTheme::kColorId_ActionableSubmenuVerticalSeparatorColor: case NativeTheme::kColorId_ActionableSubmenuVerticalSeparatorColor:
return SkColorSetA(gfx::kGoogleGrey900, 0x24); return SkColorSetA(gfx::kGoogleGrey900, 0x24);
case NativeTheme::kColorId_SelectedMenuItemForegroundColor: case NativeTheme::kColorId_SelectedMenuItemForegroundColor:
...@@ -228,7 +223,7 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id, ...@@ -228,7 +223,7 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id,
case NativeTheme::kColorId_HighlightedMenuItemBackgroundColor: case NativeTheme::kColorId_HighlightedMenuItemBackgroundColor:
return gfx::kGoogleGrey050; return gfx::kGoogleGrey050;
case NativeTheme::kColorId_HighlightedMenuItemForegroundColor: case NativeTheme::kColorId_HighlightedMenuItemForegroundColor:
return gfx::kGoogleGrey900; return kPrimaryTextColor;
case NativeTheme::kColorId_MenuItemAlertBackgroundColorMax: case NativeTheme::kColorId_MenuItemAlertBackgroundColorMax:
return SkColorSetA(gfx::kGoogleBlue600, 0x1A); return SkColorSetA(gfx::kGoogleBlue600, 0x1A);
case NativeTheme::kColorId_MenuItemAlertBackgroundColorMin: case NativeTheme::kColorId_MenuItemAlertBackgroundColorMin:
...@@ -299,10 +294,14 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id, ...@@ -299,10 +294,14 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id,
case NativeTheme::kColorId_TreeText: case NativeTheme::kColorId_TreeText:
case NativeTheme::kColorId_TreeSelectedText: case NativeTheme::kColorId_TreeSelectedText:
case NativeTheme::kColorId_TreeSelectedTextUnfocused: case NativeTheme::kColorId_TreeSelectedTextUnfocused:
return SK_ColorBLACK; return kPrimaryTextColor;
case NativeTheme::kColorId_TreeSelectionBackgroundFocused: case NativeTheme::kColorId_TreeSelectionBackgroundFocused:
case NativeTheme::kColorId_TreeSelectionBackgroundUnfocused: case NativeTheme::kColorId_TreeSelectionBackgroundUnfocused: {
return SkColorSetRGB(0xEE, 0xEE, 0xEE); const SkColor bg = base_theme->GetSystemColor(
NativeTheme::kColorId_TreeBackground, color_scheme);
return color_utils::BlendForMinContrast(bg, bg, base::nullopt, 1.67f)
.color;
}
// Table // Table
case NativeTheme::kColorId_TableBackground: case NativeTheme::kColorId_TableBackground:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment