Commit 1ad5c669 authored by Manas Verma's avatar Manas Verma Committed by Commit Bot

[Autofill] Updating strings for Save Card Sign-in Promo

Before: https://screenshot.googleplex.com/5YhNTQYuHV1
After: https://screenshot.googleplex.com/thg0VSMKzNX


Bug: 855186
Change-Id: I64b1ca9452330a847512c45220bda9173e1a1ac1
Reviewed-on: https://chromium-review.googlesource.com/1170141
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: default avatarEvan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582327}
parent 1236a162
......@@ -50,14 +50,11 @@ views::View* SaveCardManageCardsBubbleViews::CreateFootnoteView() {
NOTREACHED();
#endif
} else {
bool is_signin_promo = controller()->GetAccountInfo().IsEmpty();
footnote_view_ = new BubbleSyncPromoView(
sync_promo_delegate_.get(),
signin_metrics::AccessPoint::ACCESS_POINT_SAVE_CARD_BUBBLE,
is_signin_promo ? IDS_AUTOFILL_SIGNIN_PROMO_LINK_DICE_DISABLED
: IDS_AUTOFILL_SYNC_PROMO_LINK_DICE_DISABLED,
is_signin_promo ? IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE_DICE_DISABLED
: IDS_AUTOFILL_SYNC_PROMO_MESSAGE_DICE_DISABLED);
IDS_AUTOFILL_SIGNIN_PROMO_LINK_DICE_DISABLED,
IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE_DICE_DISABLED);
}
SetFootnoteViewForTesting(footnote_view_);
......
......@@ -59,14 +59,11 @@ SaveCardSignInPromoBubbleViews::CreateMainContentView() {
NOTREACHED();
#endif
} else {
bool is_signin_promo = controller()->GetAccountInfo().IsEmpty();
view->AddChildView(new BubbleSyncPromoView(
sync_promo_delegate_.get(),
signin_metrics::AccessPoint::ACCESS_POINT_SAVE_CARD_BUBBLE,
is_signin_promo ? IDS_AUTOFILL_SIGNIN_PROMO_LINK_DICE_DISABLED
: IDS_AUTOFILL_SYNC_PROMO_LINK_DICE_DISABLED,
is_signin_promo ? IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE_DICE_DISABLED
: IDS_AUTOFILL_SYNC_PROMO_MESSAGE_DICE_DISABLED));
IDS_AUTOFILL_SIGNIN_PROMO_LINK_DICE_DISABLED,
IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE_DICE_DISABLED));
}
return view;
}
......
......@@ -24,23 +24,17 @@
To use cards from your Google Account, sign in to Chrome
</message>
<message name="IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE" desc="Promo message for Sign-in Promo bubble (shown after a local save) to get people to sign in.">
To get your cards on all devices, sign in and turn on sync.
To use your cards on all devices, sign in and turn on sync.
</message>
<message name="IDS_AUTOFILL_SYNC_PROMO_MESSAGE" desc="Promo message for Sign-in Promo bubble (shown after a local save) to get people to sync.">
To get your cards on all devices, turn on sync.
To use your cards on all devices, turn on sync.
</message>
<message name="IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE_DICE_DISABLED" desc="Text of the sign in promo bubble and manage cards footnote.">
To get your cards on all your devices, <ph name="SIGN_IN_LINK">$1<ex>sign in</ex></ph>.
</message>
<message name="IDS_AUTOFILL_SYNC_PROMO_MESSAGE_DICE_DISABLED" desc="Text of the sync promo bubble and manage cards footnote.">
To get your cards on all your devices, <ph name="SYNC_LINK">$1<ex>turn on sync</ex></ph>.
To use your cards on all your devices, <ph name="SIGN_IN_LINK">$1<ex>sign in</ex></ph>.
</message>
<message name="IDS_AUTOFILL_SIGNIN_PROMO_LINK_DICE_DISABLED" desc="Text of the link to sign in from the save card sync promo.">
sign in to Chrome
</message>
<message name="IDS_AUTOFILL_SYNC_PROMO_LINK_DICE_DISABLED" desc="Text of the link to sync from the save card sync promo.">
turn on sync
</message>
<if expr="_google_chrome">
<message name="IDS_AUTOFILL_DELETE_AUTOCOMPLETE_SUGGESTION_CONFIRMATION_BODY" desc="Text in a dialog to confirm that the user wants to delete an autocomplete form history suggestion.">
Remove form suggestion from Chrome?
......
a89c37b7304b73ad2457c4257ba5490bfc85e77e
\ No newline at end of file
7fd0c1c2e9c2fc61cd96d78b46df278eb6a4b240
\ No newline at end of file
8b8a9d5c99f2660d412ce39345e67f3aa81b5f73
\ No newline at end of file
ce02819f305ffd9df521d015a4545fe6a86e102b
\ No newline at end of file
858dc993349162f2ec90e3c4baadf862e60c0047
\ No newline at end of file
13ec87c37f7618bac7417db8d5736047118bb69f
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment