Copy Link To Text: Surround selected text with quotes

Bug: 1105862
Change-Id: Ia3b9cb7d06a88005321806c78f1dbcf93d4ba544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438929Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812888}

chrome/browser/renderer_context_menu/copy_link_to_text_menu_observer.cc

@@ -79,7 +79,8 @@ void CopyLinkToTextMenuObserver::OnGeneratedSelector(
   std::string url = url_.spec();
   if (!selector.empty())
     url += kTextFragmentUrlClassifier + selector;
-  scw.WriteText(selected_text_ + base::UTF8ToUTF16("\n" + url));
+  scw.WriteText(base::UTF8ToUTF16("\"") + selected_text_ +
+                base::UTF8ToUTF16("\"\n" + url));
 }
 
 void CopyLinkToTextMenuObserver::OverrideGeneratedSelectorForTesting(

chrome/browser/renderer_context_menu/copy_link_to_text_menu_observer_interactive_uitest.cc

@@ -77,8 +77,8 @@ IN_PROC_BROWSER_TEST_F(CopyLinkToTextMenuObserverTest, CopiesLinkToText) {
   ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread();
   base::string16 text;
   clipboard->ReadText(ui::ClipboardBuffer::kCopyPaste, nullptr, &text);
-  EXPECT_EQ(
-      base::UTF8ToUTF16("hello world\nhttp://foo.com/#:~:text=hello%20world"),
+  EXPECT_EQ(base::UTF8ToUTF16(
+                "\"hello world\"\nhttp://foo.com/#:~:text=hello%20world"),
             text);
 }
 
@@ -95,5 +95,5 @@ IN_PROC_BROWSER_TEST_F(CopyLinkToTextMenuObserverTest,
   ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread();
   base::string16 text;
   clipboard->ReadText(ui::ClipboardBuffer::kCopyPaste, nullptr, &text);
-  EXPECT_EQ(base::UTF8ToUTF16("hello world\nhttp://foo.com/"), text);
+  EXPECT_EQ(base::UTF8ToUTF16("\"hello world\"\nhttp://foo.com/"), text);
 }