Commit 1c8eb140 authored by Ross McIlroy's avatar Ross McIlroy Committed by Commit Bot

[cleanup] Replace deprecated V8 functions in Translate.

Use As<Boolean>/<Integer>/<Number> instead of deprecated Value::BooleanValue/IntegerValue/
NumberValue.

BUG=v8:7786

Change-Id: I4123b5e135b58d3b6a88da6eec3fa8634dd06b5c
Reviewed-on: https://chromium-review.googlesource.com/1158406
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579808}
parent 1f714c69
......@@ -123,7 +123,7 @@ class TranslateScriptBrowserTest : public ChromeRenderViewTest {
// TranslateHelper::ExecuteScriptAndGetDoubleResult().
return 0.0;
}
return result->NumberValue();
return result.As<v8::Number>()->Value();
}
bool ExecuteScriptAndGetBoolResult(const std::string& script) {
......@@ -136,7 +136,7 @@ class TranslateScriptBrowserTest : public ChromeRenderViewTest {
NOTREACHED();
return false;
}
return result->BooleanValue();
return result.As<v8::Boolean>()->Value();
}
DISALLOW_COPY_AND_ASSIGN(TranslateScriptBrowserTest);
......
......@@ -213,7 +213,7 @@ bool TranslateHelper::ExecuteScriptAndGetBoolResult(const std::string& script,
return fallback;
}
return result->BooleanValue();
return result.As<v8::Boolean>()->Value();
}
std::string TranslateHelper::ExecuteScriptAndGetStringResult(
......@@ -254,7 +254,7 @@ double TranslateHelper::ExecuteScriptAndGetDoubleResult(
return 0.0;
}
return result->NumberValue();
return result.As<v8::Number>()->Value();
}
int64_t TranslateHelper::ExecuteScriptAndGetIntegerResult(
......@@ -272,7 +272,7 @@ int64_t TranslateHelper::ExecuteScriptAndGetIntegerResult(
return 0;
}
return result->IntegerValue();
return result.As<v8::Integer>()->Value();
}
// mojom::Page implementations.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment